[Compose compiler 1.5.4] stabilityConfigurationPath is listed as unsupported plugin option [309765121]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Nov 8, 2023 01:53PM

Jetpack Compose Compiler version: 20.10.01
Jetpack Compose compiler: 1.5.4

Android Studio Build: Hedgehog RC2
Kotlin version: 1.9.20

Steps to Reproduce or Code Sample to Reproduce:

I've added the following to the root gradle.kts file:

    tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
        kotlinOptions {
            freeCompilerArgs += listOf(
                "-P",
                "plugin:androidx.compose.compiler.plugins.kotlin:stabilityConfigurationPath=$rootDir/config/compose-stability-config.txt"
            )
        }
    }

This resulted in the following error:

e: Unsupported plugin option: androidx.compose.compiler.plugins.kotlin:stabilityConfigurationPath=/path/to/compose-stability-config.txt

Possible cause:

The new STABLE_CONFIG_PATH_OPTION was not added to the pluginOptions list. See: https://android-review.googlesource.com/c/platform/frameworks/support/+/2668595/21/compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/ComposePlugin.kt#164

Comments

[Deleted User] <[Deleted User]> #2Nov 8, 2023 01:56PM

Ignore this msg

as...@google.com <as...@google.com> #3Nov 8, 2023 01:59PM

Reassigned to be...@google.com.

Project: platform/frameworks/support
Branch: androidx-main

commit e7b4b06e67951ab47157d06ff314a5c8b2e8fdc6
Author: Andrei Shikov <ashikov@google.com>
Date: Mon Jan 08 15:54:51 2024

Count recursive local declarations as captures

Local declarations were already counted as captures for composable lambdas before, but the traversal ordering missed the recursive captures, converting some of them into singletons.

Test: Compiler test
Fixes: 318745941
Change-Id: I9097d1be71fb67b73e5027f723fd187c4272f6b4

M compose/compiler/compiler-hosted/integration-tests/src/androidUnitTest/kotlin/androidx/compose/compiler/plugins/kotlin/ComposeBytecodeCodegenTest.kt
M compose/compiler/compiler-hosted/integration-tests/src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/AbstractCodegenTest.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposerLambdaMemoization.kt

https://android-review.googlesource.com/2900890

ap...@google.com <ap...@google.com> #4Nov 9, 2023 10:38AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 3a12aeee59eee05b52f98a8e2c256086417d9edc
Author: Ben Trengrove <bentrengrove@google.com>
Date: Thu Nov 09 05:19:47 2023

Add stability config to plugin options

Change-Id: If74629e03591aea23d0ef3146d3578a3889cb647
Fixes: 309765121

M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/ComposePlugin.kt

https://android-review.googlesource.com/2823752

ol...@gmail.com <ol...@gmail.com> #5Nov 12, 2023 03:16PM

Hey. Will this fix be released as a part of 1.5.5 or maybe 1.5.4.1 quickfix?
Thanks.

[Deleted User] <[Deleted User]> #6Nov 20, 2023 01:29PM

I've retested the feature using the compose-compiler snapshot version and the fix is working perfectly! I was wondering the same. Is there any chance that this can be released soon in a bugfix release?

as...@google.com <as...@google.com> #7Nov 20, 2023 02:50PM

yes, it will be released as part of our biweekly release train this week i believe

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.compiler:compiler-hosted:1.5.5