[Compose compiler 1.5.4] stabilityConfigurationPath is listed as unsupported plugin option [309765121]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Nov 8, 2023 01:53PM

Jetpack Compose Compiler version: 20.10.01
Jetpack Compose compiler: 1.5.4

Android Studio Build: Hedgehog RC2
Kotlin version: 1.9.20

Steps to Reproduce or Code Sample to Reproduce:

I've added the following to the root gradle.kts file:

    tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
        kotlinOptions {
            freeCompilerArgs += listOf(
                "-P",
                "plugin:androidx.compose.compiler.plugins.kotlin:stabilityConfigurationPath=$rootDir/config/compose-stability-config.txt"
            )
        }
    }

This resulted in the following error:

e: Unsupported plugin option: androidx.compose.compiler.plugins.kotlin:stabilityConfigurationPath=/path/to/compose-stability-config.txt

Possible cause:

The new STABLE_CONFIG_PATH_OPTION was not added to the pluginOptions list. See: https://android-review.googlesource.com/c/platform/frameworks/support/+/2668595/21/compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/ComposePlugin.kt#164

Comments

[Deleted User] <[Deleted User]> #2Nov 8, 2023 01:56PM

I simpler example would be appreciated. I tried to download the pull request and build it but it relies on, for example, `rustc` to be installed which I don't have installed on my compose development machine.

Does the program work without the compiler switch. That is, is `"-P", "plugin:androidx.compose.compiler.plugins.kotlin:experimentalStrongSkipping=true",` required to reproduce or is just changing the runtime enough?

as...@google.com <as...@google.com> #3Nov 8, 2023 01:59PM

Reassigned to be...@google.com.

Yeah, changing compiler switch(enable/disable StrongSkipping, enable/disable nonSkippingGroup) has no effect, only changing runtime make sense.
Sorry for that, I will try to extract an example when I'm free.

ap...@google.com <ap...@google.com> #4Nov 9, 2023 10:38AM

Marked as fixed.

I have find a sample code to reproduce that

        setContent {
            val dialogState = remember { DialogState() }
            dialogState.Intercept()
            LaunchedEffect(Unit) {
                delay(1000)
                dialogState.bgWork {
                    delay(5000)
                }
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }
            }
        }

You can find implementation of DialogState here https://github.com/FooIbar/EhViewer/blob/ef16bdeb755ae888c74eaa4a337bd5b708fcc97e/app/src/main/kotlin/com/hippo/ehviewer/ui/tools/Dialog.kt#L92
https://github.com/FooIbar/EhViewer/blob/main/app/src/main/kotlin/com/hippo/ehviewer/util/Progress.kt Launch that Activity, wait 6 seconds and it will crash

ol...@gmail.com <ol...@gmail.com> #5Nov 12, 2023 03:16PM

Let me sort it out

The first crash
Reproduce: navigate to a gallery and navigate back
The reason is we have some code assume the forget order of RememberObserver(DisposableEffect), and 52835066c9044647a65dfb566f03131aab46e793 changed the order. Seems this is a intended behaviour.
I will fix it from my side. My bad

The second crash
Reproduce: #4 comment
StackTrace: https://bin.kv2.dev/~65d5c6175de7ed6bfdbdf1bd
We got a wrong object from SlotTable during recompose

[Deleted User] <[Deleted User]> #6Nov 20, 2023 01:29PM

And interestingly, if we insert delay(1000) between two dialog suspend usage

                dialogState.bgWork {
                    delay(5000)
                }
                delay(1000)
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }

It will not crash

as...@google.com <as...@google.com> #7Nov 20, 2023 02:50PM

Can you use "Build/Analyze APK..." and let me know what module version is reported for the compose related modules?

As for the order of `onForgotten`, it may be you are seeing and issue that I fixed in a subsequent version as this, for the snapshot builds, was broken for a few weeks when using the non-skipping group optimization even indirectly.

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

Also,

https://github.com/FooIbar/EhViewer/blob/main/app/src/main/kotlin/com/hippo/ehviewer/ui/tools/Dialog.kt is quite large and has dependencies to the rist of EhViewer. Is there a way you could produce an independent project that reproduces this?