[Compose compiler 1.5.4] stabilityConfigurationPath is listed as unsupported plugin option [309765121]

Fixed

Bug

Status Update

No update yet.

Description

[Deleted User]

created issue #1

Nov 8, 2023 01:53PM

Jetpack Compose Compiler version: 20.10.01
Jetpack Compose compiler: 1.5.4

Android Studio Build: Hedgehog RC2
Kotlin version: 1.9.20

Steps to Reproduce or Code Sample to Reproduce:

I've added the following to the root gradle.kts file:

    tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach {
        kotlinOptions {
            freeCompilerArgs += listOf(
                "-P",
                "plugin:androidx.compose.compiler.plugins.kotlin:stabilityConfigurationPath=$rootDir/config/compose-stability-config.txt"
            )
        }
    }

This resulted in the following error:

e: Unsupported plugin option: androidx.compose.compiler.plugins.kotlin:stabilityConfigurationPath=/path/to/compose-stability-config.txt

Possible cause:

The new STABLE_CONFIG_PATH_OPTION was not added to the pluginOptions list. See: https://android-review.googlesource.com/c/platform/frameworks/support/+/2668595/21/compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/ComposePlugin.kt#164

Comments

[Deleted User] <[Deleted User]> #2Nov 8, 2023 01:56PM

> The Transition Kotlin extensions target the Framework Transition class which is a bit confusing

All extensions in 'core-ktx' target either 'core' or the framework types. This is working as expected. It sounds like this is a feature request for a transition-ktx with equivalent extensions for the androidx.transition types.

> as most framework classes are being deprecated in favor of their AndroidX counterparts, Fragments for example.

"Most"? This *dramatically* overstates what is actually happening. Fragments (and loaders) were added to the framework in a time where the Android team did not have external libraries for shipping features. Transition was added 5 years later.

as...@google.com <as...@google.com> #3Nov 8, 2023 01:59PM

Reassigned to be...@google.com.

Pardon my misunderstanding, I was under the belief that where possible, new features that could be developed outside the framework, would be under Androidx. Also it's a common refrain to use the Androidx libraries over the framework libraries where possible, as those ship update independently of platform releases. I wasn't attempting to be dramatic.

If the Transition api is unlikely to change, there is no need for a transition-ktx for androidx.transition types. If developers should use Androidx transitions over framework transitions where possible however, then it would be much appreciated.

I am well aware of the limitations that existed when Fragments and Loaders were created, and when the Transition api was introduced.

ap...@google.com <ap...@google.com> #4Nov 9, 2023 10:38AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit ae42e311ecfbac18cedc90e489d1fdde956a4557
Author: Jake Wharton <jakew@google.com>
Date: Fri Nov 22 11:13:30 2019

Introduce transition-ktx for standalone transition library

These extensions are the same as androidx.core.transition for the platform types, just adapted to the standalone library.

Bug: 138870873
Test: gw :transition:transition-ktx:build :transition:transition-ktx:connectedCheck
Change-Id: Ie80022cc60ed1f482b7593db5ef1ac1c5ea33d8d

M buildSrc/src/main/kotlin/androidx/build/PublishDocsRules.kt
M jetifier/jetifier/migration.config
M settings.gradle
A transition/transition-ktx/OWNERS
A transition/transition-ktx/api/1.4.0-alpha01.txt
A transition/transition-ktx/api/current.txt
A transition/transition-ktx/api/public_plus_experimental_1.4.0-alpha01.txt
A transition/transition-ktx/api/public_plus_experimental_current.txt
A transition/transition-ktx/api/res-1.4.0-alpha01.txt
A transition/transition-ktx/api/restricted_1.4.0-alpha01.txt
A transition/transition-ktx/api/restricted_current.txt
A transition/transition-ktx/build.gradle
A transition/transition-ktx/src/androidTest/AndroidManifest.xml
A transition/transition-ktx/src/androidTest/java/androidx/transition/TestActivity.kt
A transition/transition-ktx/src/androidTest/java/androidx/transition/TransitionTest.kt
A transition/transition-ktx/src/androidTest/res/layout/test_activity.xml
A transition/transition-ktx/src/main/AndroidManifest.xml
A transition/transition-ktx/src/main/java/androidx/transition/Transition.kt

https://android-review.googlesource.com/1172715

ol...@gmail.com <ol...@gmail.com> #5Nov 12, 2023 03:16PM

Hey. Will this fix be released as a part of 1.5.5 or maybe 1.5.4.1 quickfix?
Thanks.

[Deleted User] <[Deleted User]> #6Nov 20, 2023 01:29PM

I've retested the feature using the compose-compiler snapshot version and the fix is working perfectly! I was wondering the same. Is there any chance that this can be released soon in a bugfix release?

as...@google.com <as...@google.com> #7Nov 20, 2023 02:50PM

yes, it will be released as part of our biweekly release train this week i believe

pr...@google.com <pr...@google.com> #8Nov 29, 2023 09:39PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.compiler:compiler-hosted:1.5.5