IssueTracker

Project: platform/frameworks/support
Branch: androidx-master-dev

commit e098f49838f5505b77c47d0a88b675430338fc77
Author: Eugene Susla <eugenesusla@google.com>
Date:   Tue Feb 04 16:42:20 2020

    Allow conditional startActivityForResult in ActivityResultContract
   
    This adds an extra superclass for ActivityResultContract, that allows
    customizing the action to start the activity.
   
    This allows the common "short-circuit" behavior.
    Also allows us to get rid of permissions-specific APIs.
   
    Bug: 137198065
    Bug: 151110799
    Test: use the testapp to manually trigger requests,
    rotating phone in the process.
   
    Change-Id: I9d1e6f5be70406194ea30a43980389fc985125f3

M       activity/activity/api/1.2.0-alpha03.txt
M       activity/activity/api/current.txt
M       activity/activity/api/public_plus_experimental_1.2.0-alpha03.txt
M       activity/activity/api/public_plus_experimental_current.txt
M       activity/activity/api/restricted_1.2.0-alpha03.txt
M       activity/activity/api/restricted_current.txt
M       activity/activity/src/main/java/androidx/activity/ComponentActivity.java
M       activity/activity/src/main/java/androidx/activity/result/ActivityResultRegistry.java
M       activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContract.java
M       activity/activity/src/main/java/androidx/activity/result/contract/ActivityResultContracts.java

https://android-review.googlesource.com/1238800

Project: platform/frameworks/support
Branch: androidx-main

commit 7058e53a8187fe9aa219ef6519eaad253a08cb46
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Tue Mar 05 20:07:14 2024

    Commonize InvalidationTracker
   
    Move the bulk of the TRIGGER logic in Room's InvalidationTracker to an internal class in the common source set called TriggerBasedInvalidationTracker. The public APIs of InvalidationTracker will then delegate to the internal implementation allowing functionality to be shared across platforms.
   
    Asynchronous related logic has been migrated to Coroutines using Room's new CoroutineScope and provided CoroutineContext.
   
    Two new APIs are added to the common version of the tracker (and available to Android too), 'subscribe' and 'unsubscribe' suspend functions to add and remove observers from the tracker.
   
    Bug: 299168035
    Bug: 309990302
    Bug: 309996304
    Test: Existing++
    Relnote: "Add suspend APIs for subscribing and unsubscribing InvalidationTracker.Observer with the RoomDatabase tracker."
    Change-Id: If2a1f5b2442c6772b67afcae92996d1a8a9ff2ac

D       room/integration-tests/kotlintestapp/src/androidTest/java/InvalidationTrackerExt.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/FlowQueryTest.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/MultiTypedPagingSourceTest.kt
A       room/integration-tests/multiplatformtestapp/src/androidInstrumentedTest/kotlin/androidx/room/integration/multiplatformtestapp/test/InvalidationTest.kt
A       room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseInvalidationTest.kt
M       room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseSimpleQueryTest.kt
A       room/integration-tests/multiplatformtestapp/src/jvmTest/kotlin/androidx/room/integration/multiplatformtestapp/test/InvalidationTest.kt
A       room/integration-tests/multiplatformtestapp/src/nativeTest/kotlin/androidx/room/integration/multiplatformtestapp/test/InvalidationTest.kt
D       room/integration-tests/testapp/src/androidTest/java/androidx/room/InvalidationTrackerTrojan.java
M       room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/AutoClosingRoomOpenHelperTest.java
M       room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/LiveDataQueryTest.java
M       room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultiInstanceInvalidationTest.java
M       room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/QueryTransactionTest.java
D       room/room-paging/src/androidTest/kotlin/androidx/room/InvalidationTrackerExtRoomPaging.kt
M       room/room-paging/src/androidTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt
M       room/room-runtime/api/restricted_current.txt
M       room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/CoroutineRoomCancellationTest.kt
A       room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/support/AutoClosingDatabaseTest.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/InvalidationTracker.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/MultiInstanceInvalidationClient.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/RoomDatabase.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/util/DBUtil.android.kt
M       room/room-runtime/src/androidUnitTest/kotlin/androidx/room/InvalidationTrackerTest.kt
M       room/room-runtime/src/commonMain/kotlin/androidx/room/InvalidationTracker.kt
M       room/room-runtime/src/commonMain/kotlin/androidx/room/util/DBUtil.kt
M       room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/InvalidationTracker.jvmNative.kt
M       room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/RoomDatabase.jvmNative.kt
M       room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/util/DBUtil.jvmNative.kt

https://android-review.googlesource.com/2989142

Project: platform/frameworks/support
Branch: androidx-main

commit 8e88e3cf7f8c40b3fda166f0beb5a577ba15d32b
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Wed Jul 03 11:04:33 2024

    Migrate MultiInstanceInvalidationClient to Coroutines
   
    This change moves the invalidation client to Coroutines, aligning with the rest of the Coroutine-based Invalidation Tracker refactor for KMP. It also changes when the 'all-tables' observer is registered. The observer will now be registered when the client is created in an start(), which should always be on a background thread during InvalidationTracker.internalInit(). This reduces the likelihood of missing invalidations (b/324260327) it also keeps things simple and avoids the racing nature of onServiceConnected and onServiceDisconnected being used to register / unregister the observer (b/350927013).
   
    This CL also greatly cleans up the MultiInstanceInvalidationTest which has been plague with flaky and inconsistent tests due to its concurrency nature. First, it removes the benchmark relates tests, they need to be properly moved to the benchmark integration project. Second it removes asserting behaviour using LiveData, since there is a lot of thread hopping it is harder to keep it deterministic yet it doesn't provide additional coverage, as long as observers are asserted to be invalidated it is expected then that observers that back LiveData would also be invalidated.
   
    Bug: 309996304
    Bug: 350927013
    Bug: 324260327
    Bug: 324274513
    Bug: 335890993
    Bug: 330519843
    Bug: 186405912
    Test: MultiInstanceInvalidationTest
    Change-Id: I26cbc06c752da7e465dc9ec8831ef5bc5e343606

M       room/integration-tests/testapp/lint-baseline.xml
M       room/integration-tests/testapp/src/androidTest/java/androidx/room/integration/testapp/test/MultiInstanceInvalidationTest.java
M       room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/SampleDatabaseService.java
M       room/integration-tests/testapp/src/main/java/androidx/room/integration/testapp/database/CustomerDao.java
M       room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/MultiInstanceInvalidationTest.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/InvalidationTracker.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/MultiInstanceInvalidationClient.android.kt
M       room/room-runtime/src/commonMain/kotlin/androidx/room/InvalidationTracker.kt

https://android-review.googlesource.com/3159516

Project: platform/frameworks/support
Branch: androidx-main

commit a37ee53f537021055f60bb1e7ce3cfd5a0765047
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Mon Jul 15 14:49:45 2024

    Migrate auto-close to Coroutines
   
    This change moves AutoCloser and relevant classes to Coroutines, aligning with the rest of the Coroutine-based infra refactor for KMP. It also reduces the lock contention by using atomics and avoiding the usage of the lock object along with improving the auto-boxing of binding arguments in the AutoClosingSQLiteStatement.
   
    This CL also adds an internal 'Watch' interface to get the uptime in millis for time tracking, enabling time movement using a fake watch for tests. By using a test watch along with a TestCoroutineDispatcher, this CL fixes the flaky tests that have plague auto-close for a while and removes the usages of Thread.sleep(), thus creating deterministic tests.
   
    Bug: 182343970
    Bug: 189775887
    Bug: 190607416
    Bug: 266993269
    Bug: 271325600
    Bug: 283959848
    Bug: 309996304
   
    Test: ./gradlew room:room-runtime:cAT
    Change-Id: I8e7e243d11d2aed63d84254f94b5626b3de89394

M       room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/MultiInstanceInvalidationTest.kt
M       room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/support/AutoCloserTest.kt
A       room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/support/AutoCloserTestWatch.kt
M       room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/support/AutoClosingRoomOpenHelperFactoryTest.kt
M       room/room-runtime/src/androidInstrumentedTest/kotlin/androidx/room/support/AutoClosingRoomOpenHelperTest.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/RoomDatabase.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/AutoCloser.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/AutoClosingRoomOpenHelper.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/AutoClosingRoomOpenHelperFactory.android.kt

https://android-review.googlesource.com/3174340

Project: platform/frameworks/support
Branch: androidx-main

commit d808c0479afff771af035c6cc822c1b37b4541f5
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Wed Jul 17 17:25:01 2024

    Migrate query interceptor to Coroutines
   
    Bug: 309996304
    Test: QueryInterceptorTest
    Change-Id: I92d044162d672325edacdcefa4e42652e1404525

M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/ListenableFuturePagingSourceTest.kt
M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/QueryInterceptorTest.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/RoomDatabase.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/QueryInterceptorDatabase.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/QueryInterceptorOpenHelper.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/QueryInterceptorOpenHelperFactory.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/QueryInterceptorStatement.android.kt

https://android-review.googlesource.com/3181000

Project: platform/frameworks/support
Branch: androidx-main

commit dd675f1fac8b398237480cb69ecbe92e37aff27f
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Fri Jul 19 11:25:47 2024

    Update query interceptor API to take Coroutine context
   
    Updates the query callback API to use a provided coroutine context if given.
   
    Bug: 309996304
    Bug: 354047950
    Bug: 354051564
    Test: QueryInterceptorTest
    Relnote: "Add an overload of setQueryCallback() that accepts a CoroutineContext."
    Change-Id: Id66ff055ce126085d50cad15f8982ad88c34267e

M       room/integration-tests/kotlintestapp/src/androidTest/java/androidx/room/integration/kotlintestapp/test/QueryInterceptorTest.kt
M       room/room-runtime/api/current.txt
M       room/room-runtime/api/restricted_current.txt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/RoomDatabase.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/QueryInterceptorOpenHelper.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/support/QueryInterceptorOpenHelperFactory.android.kt

https://android-review.googlesource.com/3185079

Project: platform/frameworks/support
Branch: androidx-main

commit be1ba95905b53d8e3d9b51257f02835ff5f96bce
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date:   Thu Aug 01 15:14:37 2024

    Migrate LiveData result binder to driver API
   
    Also refactor RoomTrackingLiveData infra to Coroutine so driver APIs can be used.
   
    Bug: 309996304
    Test: DaoKotlinCodeGenTest
    Change-Id: I75388ed6c7f7a55cea12f17aa1393b54742db7e5

M       room/room-compiler/src/main/kotlin/androidx/room/ext/xpoet_ext.kt
M       room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/LiveDataQueryResultBinder.kt
M       room/room-compiler/src/test/test-data/daoWriter/output/javac/withLambda/ComplexDao.java
M       room/room-compiler/src/test/test-data/daoWriter/output/javac/withoutLambda/ComplexDao.java
M       room/room-compiler/src/test/test-data/daoWriter/output/ksp/ComplexDao.java
M       room/room-compiler/src/test/test-data/kotlinCodeGen/liveDataCallable.kt
M       room/room-runtime/api/restricted_current.txt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/InvalidationLiveDataContainer.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/InvalidationTracker.android.kt
M       room/room-runtime/src/androidMain/kotlin/androidx/room/RoomTrackingLiveData.android.kt

https://android-review.googlesource.com/3205550