Do not run dexing task on subprojects' classes when they are already dex'd through artifact transforms [310252873]

Fixed

Bug

Status Update

No update yet.

Description

hu...@google.com

created issue #1

Nov 10, 2023 09:40PM

(Copied from Internal Issue 309101832.)

Classes should be dex'd by either the dexing task or the dexing transform, not both.

This was always the intent, but we may have changed this behavior by accident during a refactoring (AGP 8.0).

Size of the regression (DexArchiveBuilderTask and TOTAL_BUILD_TIME):

Base100:
- Base100_Java8_buildscriptUpdate: 8.3s -> 15.3s; 199s -> 220s
- Base100_Java8_cleanBuild: 3.1s -> 4.5s; 47s -> 49s
- Base100_Java8_codeImplChange: 19ms -> 226ms; Not noticeable
SantaTracker:
- SantaTracker_cleanBuild: 0.8s -> 1s; Not noticeable
- SantaTracker_codeImplChange: 13ms -> 597ms; ~5.5s -> 6s

Other benchmarks either don't have regressions (probably due to their project structures) or have similar regressions.

Comments

hu...@google.com <hu...@google.com> #2Nov 14, 2023 04:00PM

Marked as fixed.

We have fixed this issue in AGP 8.1.4, 8.2.1, 8.3.0-alpha14: https://android.googlesource.com/platform/tools/base/+/e7dafbb9e0fdf52be03ad7643e113dc482d53509

an...@google.com <an...@google.com> #3Nov 16, 2023 07:00PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Giraffe | 2022.3.1 Patch 4
Android Gradle Plugin 8.1.4

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

[Deleted User] <[Deleted User]> #4Nov 20, 2023 09:26PM

https://android.googlesource.com/platform/tools/base/+/e7dafbb9e0fdf52be03ad7643e113dc482d53509

ce...@gmail.com <ce...@gmail.com> #5Nov 28, 2023 02:34PM

how do i use this to power on my phone

an...@google.com <an...@google.com> #6Jan 3, 2024 06:01PM

The fixes for this issue are now also available in:

Android Studio Hedgehog | 2023.1.1 Patch 1
Android Gradle Plugin 8.2.1

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

la...@gmail.com <la...@gmail.com> #7Jan 22, 2024 12:45AM

https://developer.android.com/

so...@google.com <so...@google.com> #8Jan 27, 2024 11:41PM

Comment added by automation: A postmortem has been automatically requested for this issue. Please author a postmortem on IRM. See go/android-postmortem-guidance for more context and details, including how to handle the case when this issue does not need a postmortem. If you have any questions not answered by go/android-postmortem-guidance, please email android-hygiene-tpm@, instead of reassigning the fixed bug. Thank you.