LocalSoftwareKeyboardController and LocalTextInputService force recomposition when changing configuration [310510985]

Fixed

Bug

Status Update

No update yet.

Description

el...@reaktor.com

created issue #1

Nov 13, 2023 03:55PM


Jetpack Compose version	1.6.0-alpha08 and newer
Jetpack Compose component used	`LocalSoftwareKeyboardController`, `LocalTextInputService`

ProvideCommonCompositionLocals provides LocalSoftwareKeyboardController and LocalTextInputService, which are static composition locals. New classes are instantiated every time, which leads to recomposing the entire tree. (ProvideCommonCompositionLocals gets called when changing language, for example.)

Is this desired behavior for some reason, or could we either

Change LocalSoftwareKeyboardControllerand LocalTextInputService use compositionLocalOf instead?
Change textInputService and softwareKeyboardController to always use the same value if new class instances are not needed?

The instantiation of new classes are somewhat hidden in property getter functions here:

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/androidMain/kotlin/androidx/compose/ui/platform/AndroidComposeView.android.kt;drc=c05053a02ee0244b5c04b349e72acfb6294ae244;l=416

    override val textInputService
        get() = TextInputService(
            platformTextInputServiceInterceptor(
                legacyTextInputServiceAndroid
            )
        )

https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/ui/ui/src/commonMain/kotlin/androidx/compose/ui/node/Owner.kt;drc=a112ea65177ea43887ce9423beb4a20a07b19c14;l=124

    val softwareKeyboardController: SoftwareKeyboardController
        get() = DelegatingSoftwareKeyboardController(textInputService)

Comments

kl...@google.com <kl...@google.com> Nov 13, 2023 05:23PM

Reassigned to kl...@google.com.

kl...@google.com <kl...@google.com> Nov 17, 2023 06:56PM

Accepted by kl...@google.com.

ap...@google.com <ap...@google.com> #2Nov 17, 2023 10:10PM

Marked as fixed.

We have some support in androidx.compose.ui.autofill

Leaving this bug open in case Ralston wants to add more info

na...@google.com <na...@google.com> #3Dec 13, 2023 06:33PM

I found an example here. One problem is that it only works with the Google autofill service. When using any other service like Microsoft Authenticator or OneKey, the following error is shown:

D/Autofill Status: Autofill popup isn't shown because autofill is not available.
    
    Did you set up autofill?
    1. Go to Settings > System > Languages&input > Advanced > Autofill Service
    2. Pick a service
    
    Did you add an account?
    1. Go to Settings > System > Languages&input > Advanced
    2. Click on the settings icon next to the Autofill Service
    3. Add your account

Is this a bug on your side or do the app developers of these password managers need to change their implementation?

Issue 310510985

Description

Issue summary

Comments

kl...@google.com <kl...@google.com> Nov 13, 2023 05:23PM

kl...@google.com <kl...@google.com> Nov 17, 2023 06:56PM

ap...@google.com <ap...@google.com> #2Nov 17, 2023 10:10PM

na...@google.com <na...@google.com> #3Dec 13, 2023 06:33PM

Add comment

Issue metadata