Fixed
Status Update
Comments
kl...@google.com <kl...@google.com>
kl...@google.com <kl...@google.com>
ap...@google.com <ap...@google.com> #2
Hi. Thanks for reporting this. Fixed in alpha-04
na...@google.com <na...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug: b/264018028
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
https://android-review.googlesource.com/2373449
Branch: androidx-main
commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023
fix: tab row crashes when only 1 tab is added
Bug:
Test: Added unit test
Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f
M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt
Description
LocalSoftwareKeyboardController
,LocalTextInputService
ProvideCommonCompositionLocals
providesLocalSoftwareKeyboardController
andLocalTextInputService
, which are static composition locals. New classes are instantiated every time, which leads to recomposing the entire tree. (ProvideCommonCompositionLocals
gets called when changing language, for example.)Is this desired behavior for some reason, or could we either
LocalSoftwareKeyboardController
andLocalTextInputService
usecompositionLocalOf
instead?textInputService
andsoftwareKeyboardController
to always use the same value if new class instances are not needed?The instantiation of new classes are somewhat hidden in property getter functions here: