Fixed
Status Update
Comments
kl...@google.com <kl...@google.com>
kl...@google.com <kl...@google.com>
ap...@google.com <ap...@google.com> #2
A couple of questions:
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
1. Have you saw crash in real device or only in simulators?
2. Do you use dynamic feature for language ID?
na...@google.com <na...@google.com> #3
Tested on Android 12 Emulator with custom executor, but cannot repro this issue.
Description
LocalSoftwareKeyboardController
,LocalTextInputService
ProvideCommonCompositionLocals
providesLocalSoftwareKeyboardController
andLocalTextInputService
, which are static composition locals. New classes are instantiated every time, which leads to recomposing the entire tree. (ProvideCommonCompositionLocals
gets called when changing language, for example.)Is this desired behavior for some reason, or could we either
LocalSoftwareKeyboardController
andLocalTextInputService
usecompositionLocalOf
instead?textInputService
andsoftwareKeyboardController
to always use the same value if new class instances are not needed?The instantiation of new classes are somewhat hidden in property getter functions here: