java.lang.ClassCastException: androidx.metrics.performance.DelegatingFrameMetricsListener cannot be cast to androidx.metrics.performance.PerformanceMetricsState$Holder [311218678]

Fixed

Bug

Status Update

No update yet.

Description

ni...@datadoghq.com

created issue #1

Nov 16, 2023 11:48AM

androidx.metrics module used: metrics-performance

androidx.metrics version used: 1.0.0-alpha04

Devices/Android versions reproduced on: Android 13 (Galaxy S21 FE 5G)

We have a crash in androidx.metrics:metrics-performance:1.0.0-alpha04 reported by our customer here, with the following stacktrace:

Fatal Exception: java.lang.ClassCastException: androidx.metrics.performance.DelegatingFrameMetricsListener cannot be cast to androidx.metrics.performance.PerformanceMetricsState$Holder
       at androidx.metrics.performance.PerformanceMetricsState$Companion.getHolderForHierarchy(PerformanceMetricsState.kt:367)
       at androidx.metrics.performance.DelegatingFrameMetricsListener.onFrameMetricsAvailable(JankStatsApi24Impl.kt:225)
       at android.view.FrameMetricsObserver.onFrameMetricsAvailable(FrameMetricsObserver.java:59)
       at android.graphics.HardwareRendererObserver.lambda$notifyDataAvailable$0$android-graphics-HardwareRendererObserver(HardwareRendererObserver.java:94)
       at android.graphics.HardwareRendererObserver$$ExternalSyntheticLambda0.run(:2)
       at android.os.Handler.handleCallback(Handler.java:942)
       at android.os.Handler.dispatchMessage(Handler.java:99)
       at android.os.Looper.loopOnce(Looper.java:226)
       at android.os.Looper.loop(Looper.java:313)
       at android.os.HandlerThread.run(HandlerThread.java:67)

Comments

ma...@google.com <ma...@google.com> Dec 20, 2023 06:16PM

Reassigned to ch...@google.com.

ch...@google.com <ch...@google.com> #2Jan 8, 2024 04:43PM

Would you like to move it to android.hardware.biometrics? It looks like the problem is deeper than androidx.

ch...@google.com <ch...@google.com> #3Jan 8, 2024 09:25PM

Native Android 10 BiometricPrompt has exactly the same issue. If fixing this in the platform is impractical, maybe AndroidX Biometrics library can implement some workaround?

ch...@google.com <ch...@google.com> #4Jan 10, 2024 05:58PM

exxbrain@ can you attach a bugreport?

ch...@google.com <ch...@google.com> Feb 16, 2024 09:20PM

Reassigned to ma...@google.com.

ma...@slice.com <ma...@slice.com> #5Apr 5, 2024 12:51PM

I've created two sample projects (see attachment): one with android.hardware.biometrics (TestBiometricQ), other with androidx.biometric:biometric:1.0.0 (TestBiometricX).
They both have the same issue with setDeviceCredentialAllowed(true) (see #1).

Bug reports:

https://drive.google.com/file/d/1fx4EyHdfJ1koRIt2KZ1emQeRdSDnNOkG/view?usp=drive_web (biometric_q_report.zip)

https://drive.google.com/file/d/1PASxQhxXvLp62t91mYis28QhGqvHBfD5/view?usp=drive_web (biometric_x_report.zip)

On attached screenshots you can see "onAuthenticationError" toast alongside device pattern UI.

ma...@google.com <ma...@google.com> Jun 12, 2024 09:21PM

Status: New

ni...@datadoghq.com <ni...@datadoghq.com> #6Nov 22, 2024 03:00PM

Some clarifications:
1. The issue applies to any non-biometric unlock method (pattern, PIN, or password), if fingerprint is configured too. Not sure about face recognition.
2. "onAuthenticationSucceeded" is not called after providing correct pattern/PIN/password.

ap...@google.com <ap...@google.com> #7Feb 26, 2025 07:36PM

There is no bug report - just inconsistent behavior. From my point of view Authentication shouldn’t be cancelled in the moment when user chooses “Use pin” in a biometric prompt.

cc...@google.com <cc...@google.com> Feb 26, 2025 09:30PM

Marked as fixed, reassigned to cc...@google.com.

cc...@google.com <cc...@google.com> #8Feb 26, 2025 11:01PM

Status: Assigned (reopened)

Well, I would still call it a bug. Documentation for setDeviceCredentialAllowed() method says that user will be "given the option to authenticate with their device PIN, pattern, or password" - and this does not work: the user can enter PIN/password/pattern, but cannot authenticate, because the app always gets onAuthenticationError callback.

ap...@google.com <ap...@google.com> #9Feb 26, 2025 11:42PM

Marked as fixed.

Absolutely agree.

yo...@flipkart.com <yo...@flipkart.com> #10Feb 27, 2025 03:19AM

Agree.

na...@google.com <na...@google.com> #11Mar 12, 2025 06:13PM

Found another issue when setDeviceCredentialAllowed() is set to true.
I have attached video to show bug with bio-metric prompt.
BP is not removed when user does home button swipe while setDeviceCredentialAllowed() is set true.

yo...@flipkart.com <yo...@flipkart.com> #12Mar 13, 2025 02:48AM

Do you want me to fix this issue?

cc...@google.com <cc...@google.com> #13Mar 13, 2025 09:30PM

It is still assigned to me.

yo...@flipkart.com <yo...@flipkart.com> #14Mar 14, 2025 02:36AM

Please do fix this issue. This is a blocker for using the library in production.