Graph equality seems to be wrong on the newest version of Navigation (2.7.5) [311414915]

Fixed

Bug

Status Update

No update yet.

Description

zi...@gmail.com

created issue #1

Nov 17, 2023 07:59AM

Component used: Navigation
Version used: 2.7.5
Devices/Android versions reproduced on: Emulator Pixel 6a API 33 arm64

Hello! It seems that with the newest update (2.7.5) setGraph no longer works in our specific case. I’m wondering if it is related to the equals change[1]. For our graph if (_graph != graph) inside public open fun setGraph(graph: NavGraph, startDestinationArgs: Bundle?) returns true on 2.7.4 but false on 2.7.5. The line with nodes.valueIterator().asSequence().all { it == nodes.get(it.id) } looks suspicious. Shouldn’t it check nodes from the other graph?

[1] https://android.googlesource.com/platform/frameworks/support/+/d22366d59a46aa16aa79d1d691cd5cb55f56c378%5E%21/#F1

Comments

jb...@google.com <jb...@google.com> #2Nov 17, 2023 08:38PM

Status: New

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 42d5037be3a80f5ff840eee1f0a74bfb8f287d66
Author: Ben Weiss <benweiss@google.com>
Date: Thu Dec 10 16:20:02 2020

Add factory functions for DynamicNavHostFragment

Bug: 175222619
Test: updateApi and cAT
RelNote: Add factory functions for DynamicNavHostFragment
Change-Id: Icd51523a8f3cc3f93fffc1796c6a270bc28eaede

M navigation/navigation-dynamic-features-fragment/api/current.txt
M navigation/navigation-dynamic-features-fragment/api/public_plus_experimental_current.txt
M navigation/navigation-dynamic-features-fragment/api/restricted_current.txt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicFragmentNavigatorDestinationBuilderTest.kt
M navigation/navigation-dynamic-features-fragment/src/androidTest/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragmentTest.kt
M navigation/navigation-dynamic-features-fragment/src/main/java/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt
M navigation/navigation-fragment/src/main/java/androidx/navigation/fragment/NavHostFragment.java

https://android-review.googlesource.com/1523818

zi...@gmail.com <zi...@gmail.com> #3Nov 20, 2023 07:53AM

I couldn't seem to find the create method in my codebase on the latest Navigation release 2.3.5. Has this change been merged into latest release?

https://androidx.tech/artifacts/navigation/navigation-dynamic-features-fragment/2.3.5-source/androidx/navigation/dynamicfeatures/fragment/DynamicNavHostFragment.kt.html

jb...@google.com <jb...@google.com> Nov 28, 2023 08:30PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Nov 29, 2023 05:06PM

This adds new APIs therefore will be available in Navigation 2.4.0-alpha01.

jb...@google.com <jb...@google.com> #5Nov 29, 2023 05:08PM

Marked as fixed.

This has been fixed internally and will be available in the Navigation 2.7.6 release.

zi...@gmail.com <zi...@gmail.com> #6Nov 30, 2023 07:28PM

Thank you!

na...@google.com <na...@google.com> #7Dec 13, 2023 06:33PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.7.6

na...@google.com <na...@google.com> #8Jan 24, 2024 07:52PM