Graph equality seems to be wrong on the newest version of Navigation (2.7.5) [311414915]

Fixed

Bug

Status Update

No update yet.

Description

zi...@gmail.com

created issue #1

Nov 17, 2023 07:59AM

Component used: Navigation
Version used: 2.7.5
Devices/Android versions reproduced on: Emulator Pixel 6a API 33 arm64

Hello! It seems that with the newest update (2.7.5) setGraph no longer works in our specific case. I’m wondering if it is related to the equals change[1]. For our graph if (_graph != graph) inside public open fun setGraph(graph: NavGraph, startDestinationArgs: Bundle?) returns true on 2.7.4 but false on 2.7.5. The line with nodes.valueIterator().asSequence().all { it == nodes.get(it.id) } looks suspicious. Shouldn’t it check nodes from the other graph?

[1] https://android.googlesource.com/platform/frameworks/support/+/d22366d59a46aa16aa79d1d691cd5cb55f56c378%5E%21/#F1

Comments

jb...@google.com <jb...@google.com> #2Nov 17, 2023 08:38PM

Status: New

Hi. Thanks for reporting this. Fixed in this changelist. This should be available in alpha-04

zi...@gmail.com <zi...@gmail.com> #3Nov 20, 2023 07:53AM

Project: platform/frameworks/support
Branch: androidx-main

commit e782987543a9f8ccd485e970ddc74564b24378db
Author: Vighnesh Raut <vighnesh.raut13@gmail.com>
Date: Mon Jan 02 15:27:40 2023

fix: tab row crashes when only 1 tab is added

Bug:

b/264018028

Test: Added unit test

Change-Id: I6381dbac304fc1d69d3708c6655f8b595668e93f

M tv/tv-material/src/androidTest/java/androidx/tv/material/TabRowTest.kt
M tv/tv-material/src/main/java/androidx/tv/material/TabRow.kt

https://android-review.googlesource.com/2373449

jb...@google.com <jb...@google.com> Nov 28, 2023 08:30PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Nov 29, 2023 05:06PM

deleted

jb...@google.com <jb...@google.com> #5Nov 29, 2023 05:08PM

Marked as fixed.

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.tv:tv-material:1.0.0-alpha04

zi...@gmail.com <zi...@gmail.com> #6Nov 30, 2023 07:28PM

Thank you!

na...@google.com <na...@google.com> #7Dec 13, 2023 06:33PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.7.6

na...@google.com <na...@google.com> #8Jan 24, 2024 07:52PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.8.0-alpha01

Issue 311414915

Description

Issue summary

Comments

jb...@google.com <jb...@google.com> #2Nov 17, 2023 08:38PM

zi...@gmail.com <zi...@gmail.com> #3Nov 20, 2023 07:53AM

jb...@google.com <jb...@google.com> Nov 28, 2023 08:30PM

ap...@google.com <ap...@google.com> #4Nov 29, 2023 05:06PM

jb...@google.com <jb...@google.com> #5Nov 29, 2023 05:08PM

zi...@gmail.com <zi...@gmail.com> #6Nov 30, 2023 07:28PM

na...@google.com <na...@google.com> #7Dec 13, 2023 06:33PM

na...@google.com <na...@google.com> #8Jan 24, 2024 07:52PM

Add comment

Issue metadata