Graph equality seems to be wrong on the newest version of Navigation (2.7.5) [311414915]

Fixed

Bug

Status Update

No update yet.

Description

zi...@gmail.com

created issue #1

Nov 17, 2023 07:59AM

Component used: Navigation
Version used: 2.7.5
Devices/Android versions reproduced on: Emulator Pixel 6a API 33 arm64

Hello! It seems that with the newest update (2.7.5) setGraph no longer works in our specific case. I’m wondering if it is related to the equals change[1]. For our graph if (_graph != graph) inside public open fun setGraph(graph: NavGraph, startDestinationArgs: Bundle?) returns true on 2.7.4 but false on 2.7.5. The line with nodes.valueIterator().asSequence().all { it == nodes.get(it.id) } looks suspicious. Shouldn’t it check nodes from the other graph?

[1] https://android.googlesource.com/platform/frameworks/support/+/d22366d59a46aa16aa79d1d691cd5cb55f56c378%5E%21/#F1

Comments

jb...@google.com <jb...@google.com> #2Nov 17, 2023 08:38PM

Status: New

since these are in public API (:/) we need to do this in 1.2

zi...@gmail.com <zi...@gmail.com> #3Nov 20, 2023 07:53AM

since it is already marked as deprecated, we can probably do it by now.

jb...@google.com <jb...@google.com> Nov 28, 2023 08:30PM

Assigned to jb...@google.com.

ap...@google.com <ap...@google.com> #4Nov 29, 2023 05:06PM

Opening diff shortly

jb...@google.com <jb...@google.com> #5Nov 29, 2023 05:08PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit d576cbdc911cba16638a44fd8223391a90a07ef7
Author: Mike Nakhimovich <digitalbuddha@users.noreply.github.com>
Date: Tue Aug 11 09:30:34 2020

[GH] Hide deprecated internal API.

## Proposed Changes

* `RoomDatabase.java` has protected `mCallbacks` field which is leaking in the API docs, we should @Hide it.

## Testing

Test: Ran unit tests locally

## Issues Fixed

Fixes: 76109329

This is an imported pull request from

https://github.com/androidx/androidx/pull/61.

Resolves #61
Github-Pr-Head-Sha: 6440daa3a63752c7f9d5ba2a390248cd85bc634f
GitOrigin-RevId: fe92d8466a59b44b218b6ca3cbd57dcda17992f7

Change-Id: Id599cdf5b02b32bdae0166266fb7da967598fe92

A room/runtime/api/current.ignore
M room/runtime/api/current.txt
M room/runtime/api/public_plus_experimental_current.txt
M room/runtime/api/restricted_current.txt
M room/runtime/src/main/java/androidx/room/RoomDatabase.java

https://android-review.googlesource.com/1396827

zi...@gmail.com <zi...@gmail.com> #6Nov 30, 2023 07:28PM

Thank you!

na...@google.com <na...@google.com> #7Dec 13, 2023 06:33PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.navigation:navigation-common:2.7.6

na...@google.com <na...@google.com> #8Jan 24, 2024 07:52PM