Fixed
Status Update
Comments
ry...@google.com <ry...@google.com>
as...@google.com <as...@google.com> #2
Thanks for your feedback! Initially, the intention was to limit the date range picker to ranges of dates without the option to select the same date for start and end. However, your feedback have triggered a few additional discussions and we will make the change to allow that.
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 3aef71f0bb035d22907c9eb1011803515271822e
Author: Shalom Gibly <sgibly@google.com>
Date: Tue Mar 14 12:29:28 2023
DateRangePicker - allow same day range selection
Updates to the DateRangePicker to allow slecting the same date as a
start and end.
Bug: 272882497
Test: DateRangePickerTest
Relnote: "Updated the DateRangePicker to allow selecting a range with
the same date for its start and end."
Change-Id: I16529402422cca8b5a370483fa14e4f429548e7c
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/DateRangePickerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DatePicker.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateRangePicker.kt
https://android-review.googlesource.com/2487965
Branch: androidx-main
commit 3aef71f0bb035d22907c9eb1011803515271822e
Author: Shalom Gibly <sgibly@google.com>
Date: Tue Mar 14 12:29:28 2023
DateRangePicker - allow same day range selection
Updates to the DateRangePicker to allow slecting the same date as a
start and end.
Bug: 272882497
Test: DateRangePickerTest
Relnote: "Updated the DateRangePicker to allow selecting a range with
the same date for its start and end."
Change-Id: I16529402422cca8b5a370483fa14e4f429548e7c
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/DateRangePickerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DatePicker.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateRangePicker.kt
Description
I have created a code sample which shows the issue.
Steps to Reproduce:
Compile this code and start the TestKeyContent() composable. Observe the log messages.
Result:
The items list contains the elements 1...6 or only 2 (changes every 2 seconds). The element 2 is always part of the items. The composable KeyContent1 should log the message 'KeyContent1 remember 2' only in the composition phase. CORRECT! The composable KeyContent2 should also log the message 'KeyContent2 remember 2' only in the composition phase. BUG! Each recomposition creates a new log message 'KeyContent2 remember 2'.