Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Nov 21, 2023 12:29AM

Jetpack Compose version: 1.6.0-beta01
Jetpack Compose component: Foundation
Kotlin version: 1.9.20
Devices/Android versions reproduced on: Pixel 4a

Reproduction

Create large Text
Put it inside a LazyColumn (same length text in Column does not crash)
Wait ~10s (on Pixel 4a) for your "Can't represent a size of 385045 in Constraints" variant

See attached sample project. I use a larger font size there to speed up the reproduction (rendering 5k times 24sp is a lot faster than 50k times 14sp).

Stack trace

01:25:21.036 AndroidRuntime        E  FATAL EXCEPTION: main
Process: nl.jacobras.longtextcrash, PID: 3621
java.lang.IllegalArgumentException: Can't represent a size of 330071 in Constraints
at androidx.compose.ui.unit.Constraints$Companion.bitsNeedForSize(Constraints.kt:403)
at androidx.compose.ui.unit.Constraints$Companion.createConstraints-Zbe2FdA$ui_unit_release(Constraints.kt:363)
at androidx.compose.ui.unit.Constraints$Companion.fixed-JhjzzOo(Constraints.kt:314)
at androidx.compose.foundation.text.modifiers.TextAnnotatedStringNode.measure-3p2s80s(TextAnnotatedStringNode.kt:408)
at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasureBlock$1.invoke(LayoutNodeLayoutDelegate.kt:252)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasureBlock$1.invoke(LayoutNodeLayoutDelegate.kt:251)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2303)
at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:494)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:256)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:113)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1601)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:617)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:596)
at androidx.compose.foundation.lazy.layout.LazyLayoutMeasureScopeImpl.measure-0kLqBqw(LazyLayoutMeasureScope.kt:127)
at androidx.compose.foundation.lazy.LazyListMeasuredItemProvider.getAndMeasure(LazyListMeasuredItemProvider.kt:48)
at androidx.compose.foundation.lazy.LazyListMeasureKt.measureLazyList-5IMabDg(LazyListMeasure.kt:195)
at androidx.compose.foundation.lazy.LazyListKt$rememberLazyListMeasurePolicy$1$1.invoke-0kLqBqw(LazyList.kt:313)
at androidx.compose.foundation.lazy.LazyListKt$rememberLazyListMeasurePolicy$1$1.invoke(LazyList.kt:178)
at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$2$1.invoke-0kLqBqw(LazyLayout.kt:107)
at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$2$1.invoke(LazyLayout.kt:100)
at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:708)
at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:126)
at androidx.compose.foundation.AndroidOverscroll_androidKt$StretchOverscrollNonClippingLayer$2.invoke-3p2s80s(AndroidOverscroll.android.kt:584)
at androidx.compose.foundation.AndroidOverscroll_androidKt$StretchOverscrollNonClippingLayer$2.invoke(AndroidOverscroll.android.kt:583)
at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:291)
at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.foundation.AndroidOverscroll_androidKt$StretchOverscrollNonClippingLayer$1.invoke-3p2s80s(AndroidOverscroll.android.kt:568)
at androidx.compose.foundation.AndroidOverscroll_androidKt$StretchOverscrollNonClippingLayer$1.invoke(AndroidOverscroll.android.kt:567)
at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:291)
01:25:21.041 AndroidRuntime        E  	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasureBlock$1.invoke(LayoutNodeLayoutDelegate.kt:252)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasureBlock$1.invoke(LayoutNodeLayoutDelegate.kt:251)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2303)
at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:494)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:256)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:113)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1601)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:617)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1144)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release$default(LayoutNode.kt:1135)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:333)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:482)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.onlyRemeasureIfScheduled(MeasureAndLayoutDelegate.kt:566)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtreeInternal(MeasureAndLayoutDelegate.kt:592)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtree(MeasureAndLayoutDelegate.kt:555)
at androidx.compose.ui.platform.AndroidComposeView.forceMeasureTheSubtree(AndroidComposeView.android.kt:994)
at androidx.compose.ui.node.Owner.forceMeasureTheSubtree$default(Owner.kt:241)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:629)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1144)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:331)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureOnly(MeasureAndLayoutDelegate.kt:530)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureOnly(MeasureAndLayoutDelegate.kt:384)
at androidx.compose.ui.platform.AndroidComposeView.onMeasure(AndroidComposeView.android.kt:1059)
at android.view.View.measure(View.java:26496)
at androidx.compose.ui.platform.AbstractComposeView.internalOnMeasure$ui_release(ComposeView.android.kt:302)
at androidx.compose.ui.platform.AbstractComposeView.onMeasure(ComposeView.android.kt:289)
at android.view.View.measure(View.java:26496)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6981)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at android.view.View.measure(View.java:26496)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6981)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1608)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:878)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
at android.view.View.measure(View.java:26496)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6981)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
[..]

ComposeLongTextCrash.zip

847 KB

Download

Comments

gr...@google.com <gr...@google.com> #2Nov 23, 2023 12:16AM

Please upgrade to Preference 1.1.1 which contains the fix for this issue.

gr...@google.com <gr...@google.com> #3Nov 23, 2023 12:23AM

I am using Preference 1.1.1 already, as demonstrated in the sample project. In fact, I also reported 150051716, the one that is marked as duplicate. That issue is indeed fixed but this is a new one. The stacktrace is different too.

Message last modified on Nov 23, 2023 12:26AM

gr...@google.com <gr...@google.com> #4Nov 23, 2023 12:40AM

Yep, you're right. Looks like the root cause of this separate issue was already fixed by aosp/1181309 so upgrading to any Fragment 1.3.0 version would pull in the fix.

That fix is part of a much larger set of changes so I don't think it'll be possible for us to safely cherry pick that fix into a Fragment 1.2.X release, unfortunately.

I'll leave this open while we investigate what that would take.

Message last modified on Nov 23, 2023 12:41AM

gr...@google.com <gr...@google.com> #5Nov 23, 2023 12:49AM

My apologies for not trying the latest alpha release beforehand. Upgrading to version 1.3.0 solves my case. Thank you for pointing that out.

Message last modified on Nov 23, 2023 01:17AM

ja...@gmail.com <ja...@gmail.com> #6Nov 23, 2023 11:50AM

When using fragment-ktx:1.3.0-alpha03, I'm still able to reproduce this issue. The following crash occurs on a configuration change:

java.lang.IllegalStateException: Fragment androidx.fragment.app.Fragment$4@5ff632e does not have a view
    at androidx.fragment.app.Fragment$4.onFindViewById(Fragment.java:2711)
    at androidx.fragment.app.FragmentStateManager.createView(FragmentStateManager.java:464)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1170)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1316)
    at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1394)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1460)
    at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2695)
    at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:2644)
    at androidx.fragment.app.Fragment.performActivityCreated(Fragment.java:2784)
    at androidx.fragment.app.FragmentStateManager.activityCreated(FragmentStateManager.java:507)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1171)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1316)
    at androidx.fragment.app.FragmentManager.moveFragmentToExpectedState(FragmentManager.java:1394)
    at androidx.fragment.app.FragmentManager.moveToState(FragmentManager.java:1460)
    at androidx.fragment.app.FragmentManager.dispatchStateChange(FragmentManager.java:2695)
    at androidx.fragment.app.FragmentManager.dispatchActivityCreated(FragmentManager.java:2644)
    at androidx.fragment.app.FragmentController.dispatchActivityCreated(FragmentController.java:251)
    at androidx.fragment.app.FragmentActivity.onStart(FragmentActivity.java:546)
    at androidx.appcompat.app.AppCompatActivity.onStart(AppCompatActivity.java:201)
    at android.app.Instrumentation.callActivityOnStart(Instrumentation.java:1392)
    at android.app.Activity.performStart(Activity.java:7172)
    at android.app.ActivityThread.handleStartActivity(ActivityThread.java:2967)
    at android.app.servertransaction.TransactionExecutor.performLifecycleSequence(TransactionExecutor.java:180)
    at android.app.servertransaction.TransactionExecutor.cycleToPath(TransactionExecutor.java:165)
    at android.app.servertransaction.TransactionExecutor.executeLifecycleState(TransactionExecutor.java:142)
    at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:70)
    at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1816)
    at android.os.Handler.dispatchMessage(Handler.java:106)
    at android.os.Looper.loop(Looper.java:193)
    at android.app.ActivityThread.main(ActivityThread.java:6854)
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:860)

Message last modified on Nov 23, 2023 11:52AM

gr...@google.com <gr...@google.com> #7Nov 27, 2023 10:01PM

Thanks, this looks like an issue with DialogFragment so fixing that underlying issue should fix PreferenceDialogFragmentCompat as well.

Message last modified on Nov 27, 2023 10:12PM

gr...@google.com <gr...@google.com> #8Nov 27, 2023 10:18PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3c698888435fee8af2d911e54d1b9df9fd46648c
Author: Ian Lake <ilake@google.com>
Date: Tue Apr 21 16:46:50 2020

Fix onFindViewById in DialogFragment

Instead of only considering the Fragment's view,
DialogFragment should also consider the Dialog's
view when calling onFindViewById(). This ensures
that any <fragment> or FragmentContainerView that
is created as part of the Dialog's view structure
will properly be reattached to its view hierarchy
after a configuration change.

Test: updated DialogFragmentInflatedChildTest tests pass
BUG: 154366601
Change-Id: I59ada3193974f00ab4df475d992e237baa03c5bf

M fragment/fragment/src/androidTest/java/androidx/fragment/app/DialogFragmentInflatedChildTest.kt
M fragment/fragment/src/main/java/androidx/fragment/app/DialogFragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/Fragment.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentManager.java
M fragment/fragment/src/main/java/androidx/fragment/app/FragmentStateManager.java

https://android-review.googlesource.com/1292291

Message last modified on Nov 27, 2023 10:18PM

se...@google.com <se...@google.com> #9Nov 27, 2023 10:28PM

Reassigned to se...@google.com.

This has been fixed internally and will be available in Fragment 1.3.0-alpha04.

You can confirm the fix in your project by following the snapshot instructions at androidx.dev, using a buildId of 6419956 and Fragment 1.3.0-SNAPSHOT.

se...@google.com <se...@google.com> #10Dec 4, 2023 06:24PM

That was quick! It works as expected now. Much appreciated

ap...@google.com <ap...@google.com> #11Dec 5, 2023 04:49PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 76a2a7b35ef1398119cc0a5d7d0f553ce37eeef4
Author: Sean McQuillan <seanmcq@google.com>
Date: Mon Dec 04 13:40:44 2023

Text doesn't crash when text is very very tall

Previously: Constraints would run out of bits of text was too large
Now: Inner measures are constrained first by width, then by height

Fixes:

b/312294386

Test: ./gradlew :com:found:found:cAT
Relnote: Fix crash that impacted very large text measured with infinite constraints.
Change-Id: I1a7df0f35e5506b4ca05c4e2091142012a07908f

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/LayoutUtilsKtTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNodeTest.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNodeTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/LayoutUtils.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextAnnotatedStringNode.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/TextStringSimpleNode.kt

https://android-review.googlesource.com/2853602

ap...@google.com <ap...@google.com> #12Dec 8, 2023 10:51PM

Project: platform/frameworks/support
Branch: androidx-main

commit 3a0cbbb01cb74bcbfc72797c5eb5bac5ad9e4cce
Author: Sean McQuillan <seanmcq@google.com>
Date: Tue Dec 05 10:39:42 2023

Add docs and more tests for fixCoercedHeightAndWidthForBits

Bug:

b/312294386

Test: ./gradlew :com:found:found:cAT
Change-Id: I7faf92e19d24550e4ceaf11c64afe6f67bd274cf

M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/text/modifiers/LayoutUtilsKtTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/text/modifiers/LayoutUtils.kt

https://android-review.googlesource.com/2860606

na...@google.com <na...@google.com> #13Dec 13, 2023 06:33PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.6.0-beta03
androidx.compose.foundation:foundation-android:1.6.0-beta03
androidx.compose.foundation:foundation-desktop:1.6.0-beta03

IssueTracker

Text crashes on longer texts, when inside `LazyColumn`

Status Update

Description

Reproduction

Stack trace

Comments

gr...@google.com <gr...@google.com> #2Nov 23, 2023 12:16AM

gr...@google.com <gr...@google.com> #3Nov 23, 2023 12:23AM

gr...@google.com <gr...@google.com> #4Nov 23, 2023 12:40AM

gr...@google.com <gr...@google.com> #5Nov 23, 2023 12:49AM

ja...@gmail.com <ja...@gmail.com> #6Nov 23, 2023 11:50AM

gr...@google.com <gr...@google.com> #7Nov 27, 2023 10:01PM

gr...@google.com <gr...@google.com> #8Nov 27, 2023 10:18PM

se...@google.com <se...@google.com> #9Nov 27, 2023 10:28PM

se...@google.com <se...@google.com> #10Dec 4, 2023 06:24PM

ap...@google.com <ap...@google.com> #11Dec 5, 2023 04:49PM

ap...@google.com <ap...@google.com> #12Dec 8, 2023 10:51PM

na...@google.com <na...@google.com> #13Dec 13, 2023 06:33PM

Issue 312294386

Description

Reproduction

Stack trace

Issue summary

Comments

gr...@google.com <gr...@google.com> #2Nov 23, 2023 12:16AM

gr...@google.com <gr...@google.com> #3Nov 23, 2023 12:23AM

gr...@google.com <gr...@google.com> #4Nov 23, 2023 12:40AM

gr...@google.com <gr...@google.com> #5Nov 23, 2023 12:49AM

ja...@gmail.com <ja...@gmail.com> #6Nov 23, 2023 11:50AM

gr...@google.com <gr...@google.com> #7Nov 27, 2023 10:01PM

gr...@google.com <gr...@google.com> #8Nov 27, 2023 10:18PM

se...@google.com <se...@google.com> #9Nov 27, 2023 10:28PM

se...@google.com <se...@google.com> #10Dec 4, 2023 06:24PM

ap...@google.com <ap...@google.com> #11Dec 5, 2023 04:49PM

ap...@google.com <ap...@google.com> #12Dec 8, 2023 10:51PM

na...@google.com <na...@google.com> #13Dec 13, 2023 06:33PM

Add comment

Issue metadata