Fixed

Bug

Status Update

No update yet.

Description

ja...@gmail.com

created issue #1

Nov 21, 2023 12:29AM

Jetpack Compose version: 1.6.0-beta01
Jetpack Compose component: Foundation
Kotlin version: 1.9.20
Devices/Android versions reproduced on: Pixel 4a

Reproduction

Create large Text
Put it inside a LazyColumn (same length text in Column does not crash)
Wait ~10s (on Pixel 4a) for your "Can't represent a size of 385045 in Constraints" variant

See attached sample project. I use a larger font size there to speed up the reproduction (rendering 5k times 24sp is a lot faster than 50k times 14sp).

Stack trace

01:25:21.036 AndroidRuntime        E  FATAL EXCEPTION: main
Process: nl.jacobras.longtextcrash, PID: 3621
java.lang.IllegalArgumentException: Can't represent a size of 330071 in Constraints
at androidx.compose.ui.unit.Constraints$Companion.bitsNeedForSize(Constraints.kt:403)
at androidx.compose.ui.unit.Constraints$Companion.createConstraints-Zbe2FdA$ui_unit_release(Constraints.kt:363)
at androidx.compose.ui.unit.Constraints$Companion.fixed-JhjzzOo(Constraints.kt:314)
at androidx.compose.foundation.text.modifiers.TextAnnotatedStringNode.measure-3p2s80s(TextAnnotatedStringNode.kt:408)
at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasureBlock$1.invoke(LayoutNodeLayoutDelegate.kt:252)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasureBlock$1.invoke(LayoutNodeLayoutDelegate.kt:251)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2303)
at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:494)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:256)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:113)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1601)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:617)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.measure-BRTryo0(LayoutNodeLayoutDelegate.kt:596)
at androidx.compose.foundation.lazy.layout.LazyLayoutMeasureScopeImpl.measure-0kLqBqw(LazyLayoutMeasureScope.kt:127)
at androidx.compose.foundation.lazy.LazyListMeasuredItemProvider.getAndMeasure(LazyListMeasuredItemProvider.kt:48)
at androidx.compose.foundation.lazy.LazyListMeasureKt.measureLazyList-5IMabDg(LazyListMeasure.kt:195)
at androidx.compose.foundation.lazy.LazyListKt$rememberLazyListMeasurePolicy$1$1.invoke-0kLqBqw(LazyList.kt:313)
at androidx.compose.foundation.lazy.LazyListKt$rememberLazyListMeasurePolicy$1$1.invoke(LazyList.kt:178)
at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$2$1.invoke-0kLqBqw(LazyLayout.kt:107)
at androidx.compose.foundation.lazy.layout.LazyLayoutKt$LazyLayout$3$2$1.invoke(LazyLayout.kt:100)
at androidx.compose.ui.layout.LayoutNodeSubcompositionsState$createMeasurePolicy$1.measure-3p2s80s(SubcomposeLayout.kt:708)
at androidx.compose.ui.node.InnerNodeCoordinator.measure-BRTryo0(InnerNodeCoordinator.kt:126)
at androidx.compose.foundation.AndroidOverscroll_androidKt$StretchOverscrollNonClippingLayer$2.invoke-3p2s80s(AndroidOverscroll.android.kt:584)
at androidx.compose.foundation.AndroidOverscroll_androidKt$StretchOverscrollNonClippingLayer$2.invoke(AndroidOverscroll.android.kt:583)
at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:291)
at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.foundation.AndroidOverscroll_androidKt$StretchOverscrollNonClippingLayer$1.invoke-3p2s80s(AndroidOverscroll.android.kt:568)
at androidx.compose.foundation.AndroidOverscroll_androidKt$StretchOverscrollNonClippingLayer$1.invoke(AndroidOverscroll.android.kt:567)
at androidx.compose.ui.layout.LayoutModifierImpl.measure-3p2s80s(LayoutModifier.kt:291)
01:25:21.041 AndroidRuntime        E  	at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.ui.graphics.SimpleGraphicsLayerModifier.measure-3p2s80s(GraphicsLayerModifier.kt:646)
at androidx.compose.ui.node.LayoutModifierNodeCoordinator.measure-BRTryo0(LayoutModifierNodeCoordinator.kt:116)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasureBlock$1.invoke(LayoutNodeLayoutDelegate.kt:252)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$performMeasureBlock$1.invoke(LayoutNodeLayoutDelegate.kt:251)
at androidx.compose.runtime.snapshots.Snapshot$Companion.observe(Snapshot.kt:2303)
at androidx.compose.runtime.snapshots.SnapshotStateObserver$ObservedScopeMap.observe(SnapshotStateObserver.kt:494)
at androidx.compose.runtime.snapshots.SnapshotStateObserver.observeReads(SnapshotStateObserver.kt:256)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeReads$ui_release(OwnerSnapshotObserver.kt:133)
at androidx.compose.ui.node.OwnerSnapshotObserver.observeMeasureSnapshotReads$ui_release(OwnerSnapshotObserver.kt:113)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate.performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:1601)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate.access$performMeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:36)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:617)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1144)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release$default(LayoutNode.kt:1135)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:333)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureAndRelayoutIfNeeded(MeasureAndLayoutDelegate.kt:482)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.onlyRemeasureIfScheduled(MeasureAndLayoutDelegate.kt:566)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtreeInternal(MeasureAndLayoutDelegate.kt:592)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.forceMeasureTheSubtree(MeasureAndLayoutDelegate.kt:555)
at androidx.compose.ui.platform.AndroidComposeView.forceMeasureTheSubtree(AndroidComposeView.android.kt:994)
at androidx.compose.ui.node.Owner.forceMeasureTheSubtree$default(Owner.kt:241)
at androidx.compose.ui.node.LayoutNodeLayoutDelegate$MeasurePassDelegate.remeasure-BRTryo0(LayoutNodeLayoutDelegate.kt:629)
at androidx.compose.ui.node.LayoutNode.remeasure-_Sx5XlM$ui_release(LayoutNode.kt:1144)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.doRemeasure-sdFAvZA(MeasureAndLayoutDelegate.kt:331)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.remeasureOnly(MeasureAndLayoutDelegate.kt:530)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.measureOnly(MeasureAndLayoutDelegate.kt:384)
at androidx.compose.ui.platform.AndroidComposeView.onMeasure(AndroidComposeView.android.kt:1059)
at android.view.View.measure(View.java:26496)
at androidx.compose.ui.platform.AbstractComposeView.internalOnMeasure$ui_release(ComposeView.android.kt:302)
at androidx.compose.ui.platform.AbstractComposeView.onMeasure(ComposeView.android.kt:289)
at android.view.View.measure(View.java:26496)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6981)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
at android.view.View.measure(View.java:26496)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6981)
at android.widget.LinearLayout.measureChildBeforeLayout(LinearLayout.java:1608)
at android.widget.LinearLayout.measureVertical(LinearLayout.java:878)
at android.widget.LinearLayout.onMeasure(LinearLayout.java:721)
at android.view.View.measure(View.java:26496)
at android.view.ViewGroup.measureChildWithMargins(ViewGroup.java:6981)
at android.widget.FrameLayout.onMeasure(FrameLayout.java:194)
[..]

ComposeLongTextCrash.zip

847 KB

Download

Comments

gr...@google.com <gr...@google.com> #2Nov 23, 2023 12:16AM

Could we get an official response to this feature request? Is there an idea to support SafeArgs in navigation-compose one day? Not asking for any time frames. Maybe there is no plans for statically generated args for navigation-compose at all.

gr...@google.com <gr...@google.com> #3Nov 23, 2023 12:23AM

Please check out my implementation of the same-

Part 1-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-95c84722eec2

Part 2-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-part-2-218a6ae7a027

Github repo-

https://github.com/dilrajsingh1997/safe-compose-args

Message last modified on Nov 23, 2023 12:26AM

gr...@google.com <gr...@google.com> #4Nov 23, 2023 12:40AM

Integration guide-

https://proandroiddev.com/safe-compose-arguments-an-improved-way-to-navigate-in-jetpack-compose-part-3-2e5ab79b9a05

Message last modified on Nov 23, 2023 12:41AM

gr...@google.com <gr...@google.com> #5Nov 23, 2023 12:49AM

Message last modified on Nov 23, 2023 01:17AM

ja...@gmail.com <ja...@gmail.com> #6Nov 23, 2023 11:50AM

https://github.com/raamcosta/compose-destinations

this library make it super easy if can you support this on the native way

Message last modified on Nov 23, 2023 11:52AM

gr...@google.com <gr...@google.com> #7Nov 27, 2023 10:01PM

Here's a library that does just this: https://github.com/kiwicom/navigation-compose-typed. I tested it out and it works as expected

Message last modified on Nov 27, 2023 10:12PM

gr...@google.com <gr...@google.com> #8Nov 27, 2023 10:18PM

+1

something similar to 'compose-destinations' should be officially available to the devs. Its a pain to manage all the parameters manually.
Currently, I am working with a custom NavType implementation with Gson.

Message last modified on Nov 27, 2023 10:18PM

se...@google.com <se...@google.com> #9Nov 27, 2023 10:28PM

Reassigned to se...@google.com.

The current navigation is really difficult to use. It makes me unwilling to use composite in new projects and upgrade in outdated projects

se...@google.com <se...@google.com> #10Dec 4, 2023 06:24PM

Google team are there any news/priorities on this? Are you planning on improve the existing compose-navigation lib or this is going to not feasible😉?

ap...@google.com <ap...@google.com> #11Dec 5, 2023 04:49PM

Marked as fixed.

There's some ongoing work on this here https://android-review.googlesource.com/c/platform/frameworks/support/+/2957296?s=09 as it seems

ap...@google.com <ap...@google.com> #12Dec 8, 2023 10:51PM

Re comment#11 - yes, you'll start to see commits for a Kotlin Serialization based approach to generating destination routes (and their associated navigate calls) from @Serializable classes.

There's a lot of parts to this, so please bear with us. We'll make sure to write a public blog post explaining much of the reasoning and other alternatives we looked into when we're ready to make a public release.

na...@google.com <na...@google.com> #13Dec 13, 2023 06:33PM

Project: platform/frameworks/support
Branch: androidx-main

commit 5dc21cddd069edef368db19f15abc97388a429f2
Author: Clara Fok <clarafok@google.com>
Date: Wed Feb 21 09:59:02 2024

Implement routePattern generator for Serializable type T

Generate routePattern for type T where T is a concrete serializable class or object.

Args with default values are appended as query parameters, while args without are appended as path parameters.

Test: ./gradlew navigation:navigation-common:test
Bug: 188693139
Change-Id: Ie8527e46e31881747b3599a96d17a15019ea8305

M navigation/navigation-common/build.gradle
A navigation/navigation-common/src/main/java/androidx/navigation/serialization/RouteSerializer.kt
A navigation/navigation-common/src/test/java/androidx/navigation/serialization/RoutePatternTest.kt
M navigation/navigation-fragment/build.gradle

https://android-review.googlesource.com/2957296

IssueTracker

Text crashes on longer texts, when inside `LazyColumn`

Status Update

Description

Reproduction

Stack trace

Comments

gr...@google.com <gr...@google.com> #2Nov 23, 2023 12:16AM

gr...@google.com <gr...@google.com> #3Nov 23, 2023 12:23AM

gr...@google.com <gr...@google.com> #4Nov 23, 2023 12:40AM

gr...@google.com <gr...@google.com> #5Nov 23, 2023 12:49AM

ja...@gmail.com <ja...@gmail.com> #6Nov 23, 2023 11:50AM

gr...@google.com <gr...@google.com> #7Nov 27, 2023 10:01PM

gr...@google.com <gr...@google.com> #8Nov 27, 2023 10:18PM

se...@google.com <se...@google.com> #9Nov 27, 2023 10:28PM

se...@google.com <se...@google.com> #10Dec 4, 2023 06:24PM

ap...@google.com <ap...@google.com> #11Dec 5, 2023 04:49PM

ap...@google.com <ap...@google.com> #12Dec 8, 2023 10:51PM

na...@google.com <na...@google.com> #13Dec 13, 2023 06:33PM

Issue 312294386

Description

Reproduction

Stack trace

Issue summary

Comments

gr...@google.com <gr...@google.com> #2Nov 23, 2023 12:16AM

gr...@google.com <gr...@google.com> #3Nov 23, 2023 12:23AM

gr...@google.com <gr...@google.com> #4Nov 23, 2023 12:40AM

gr...@google.com <gr...@google.com> #5Nov 23, 2023 12:49AM

ja...@gmail.com <ja...@gmail.com> #6Nov 23, 2023 11:50AM

gr...@google.com <gr...@google.com> #7Nov 27, 2023 10:01PM

gr...@google.com <gr...@google.com> #8Nov 27, 2023 10:18PM

se...@google.com <se...@google.com> #9Nov 27, 2023 10:28PM

se...@google.com <se...@google.com> #10Dec 4, 2023 06:24PM

ap...@google.com <ap...@google.com> #11Dec 5, 2023 04:49PM

ap...@google.com <ap...@google.com> #12Dec 8, 2023 10:51PM

na...@google.com <na...@google.com> #13Dec 13, 2023 06:33PM

Add comment

Issue metadata