Fixed
Status Update
No update yet.
Comments
co...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit c9cf25062fed6a75c01e6fb7bad692ad6320a6e9
Author: Leticia Santos <leticiars@google.com>
Date: Wed Dec 06 13:33:47 2023
[NavigationSuiteScaffold] Fixed navigation component filling entire screen when root surface has modifier.fillMaxSize
When using Surface with fillMaxSize it tries to fill its entire available space with the first composable it finds, but wrapping that composable in a Box prevents that.
Test: manually tested
Bug: 312664933
Change-Id: Ifd23d070ab09f1750384d42ef43a5dc252fac560
M compose/material3/material3-adaptive-navigation-suite/src/commonMain/kotlin/androidx/compose/material3/adaptive/navigation-suite/NavigationSuiteScaffold.kt
https://android-review.googlesource.com/2861890
Branch: androidx-main
commit c9cf25062fed6a75c01e6fb7bad692ad6320a6e9
Author: Leticia Santos <leticiars@google.com>
Date: Wed Dec 06 13:33:47 2023
[NavigationSuiteScaffold] Fixed navigation component filling entire screen when root surface has modifier.fillMaxSize
When using Surface with fillMaxSize it tries to fill its entire available space with the first composable it finds, but wrapping that composable in a Box prevents that.
Test: manually tested
Bug: 312664933
Change-Id: Ifd23d070ab09f1750384d42ef43a5dc252fac560
M compose/material3/material3-adaptive-navigation-suite/src/commonMain/kotlin/androidx/compose/material3/adaptive/navigation-suite/NavigationSuiteScaffold.kt
le...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3-adaptive-navigation-suite:1.0.0-alpha02androidx.compose.material3:material3-adaptive-navigation-suite-android:1.0.0-alpha02androidx.compose.material3:material3-adaptive-navigation-suite-desktop:1.0.0-alpha02
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit f6f510999615b25e0a1c118f1136a40bdef6f31f
Author: Leticia Santos <leticiars@google.com>
Date: Tue Jan 23 15:23:34 2024
[NavigationSuiteScaffold] Add some tests.
These tests are related to aosp/2861890
Test: self
Bug: 312664933
Change-Id: I63bda11216f0fc36927ce0b694b82490203ead03
A compose/material3/material3-adaptive-navigation-suite/src/androidInstrumentedTest/kotlin/androidx/compose/material3/adaptive-navigation-suite/NavigationSuiteScaffoldTest.kt
https://android-review.googlesource.com/2924390
Branch: androidx-main
commit f6f510999615b25e0a1c118f1136a40bdef6f31f
Author: Leticia Santos <leticiars@google.com>
Date: Tue Jan 23 15:23:34 2024
[NavigationSuiteScaffold] Add some tests.
These tests are related to aosp/2861890
Test: self
Bug: 312664933
Change-Id: I63bda11216f0fc36927ce0b694b82490203ead03
A compose/material3/material3-adaptive-navigation-suite/src/androidInstrumentedTest/kotlin/androidx/compose/material3/adaptive-navigation-suite/NavigationSuiteScaffoldTest.kt
Description
Jetpack Compose component used: material3-adaptive-navigation-suite
Android Studio Build: Android Studio Iguana | 2023.2.1 Canary 14
Kotlin version:
Steps to Reproduce or Code Sample to Reproduce:
1. Open project (or create new Navigation Suite project and add a simple Composable as part of the NavigationSuiteScaffold content)
2. Run the project
Preview shows Navigation Suite working fine, but when run on device, the BottomNavigationBar appears in the middle of the screen (and NavRail as well), and the content Composable is not shown. I could replicate this error on Pixel Fold and Pixel 7 Pro, both running Android 14.
Invalidate and restart or rebuild the app didn't fix the issue, but removing the Size modifiers from the root Surface fixed it.