CCE "IrBlockImpl cannot be cast to IrFunctionReference" on inlining adapted function reference [312738720]

Fixed

Bug

Status Update

No update yet.

Description

al...@jetbrains.com

created issue #1

Nov 23, 2023 09:33PM

Jetpack Compose version: 1.5.5-dev-k2.0.0-Beta1-06b8ae672a4

~~Jetpack Compose component(s) used:~~

~~Android Studio Build:~~

Kotlin version: 2.0.0-Beta1

Steps to Reproduce or Code Sample to Reproduce:

See https://youtrack.jetbrains.com/issue/KT-63722. I believe the issue is in Compose rather than in Kotlin, so reporting it here.

import androidx.compose.runtime.Composable

class ScrollState {
    fun scrollToItem(index: Int, default: Int = 0) = Unit
}

@Composable
fun ScrollState.rememberDraggableScroller(): (Float) -> Unit = rememberDraggableScroller(::scrollToItem)

@Composable
inline fun rememberDraggableScroller(lambda: (index: Int) -> Unit): (Float) -> Unit = {}

Stack trace (if applicable):

org.jetbrains.kotlin.backend.common.BackendException: Backend Internal error: Exception during IR lowering
File being compiled: /Users/Ivan.Kubyshkin/AndroidStudioProjects/MyApplication23/app/src/main/java/com/example/myapplication/MainActivity.kt
The root cause java.lang.ClassCastException was thrown at: org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.transform(InlineCallableReferenceToLambda.kt:73)
	at org.jetbrains.kotlin.backend.common.CodegenUtil.reportBackendException(CodegenUtil.kt:253)
	at org.jetbrains.kotlin.backend.common.CodegenUtil.reportBackendException$default(CodegenUtil.kt:236)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invokeSequential(performByIrFile.kt:65)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invoke(performByIrFile.kt:52)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invoke(performByIrFile.kt:38)
	at org.jetbrains.kotlin.backend.common.phaser.NamedCompilerPhase.phaseBody(CompilerPhase.kt:147)
	at org.jetbrains.kotlin.backend.common.phaser.AbstractNamedCompilerPhase.invoke(CompilerPhase.kt:94)
	at org.jetbrains.kotlin.backend.common.phaser.CompositePhase.invoke(PhaseBuilders.kt:30)
	at org.jetbrains.kotlin.backend.common.phaser.CompositePhase.invoke(PhaseBuilders.kt:17)
	at org.jetbrains.kotlin.backend.common.phaser.NamedCompilerPhase.phaseBody(CompilerPhase.kt:147)
	at org.jetbrains.kotlin.backend.common.phaser.AbstractNamedCompilerPhase.invoke(CompilerPhase.kt:94)
	at org.jetbrains.kotlin.backend.common.phaser.CompilerPhaseKt.invokeToplevel(CompilerPhase.kt:43)
	at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.invokeLowerings(JvmIrCodegenFactory.kt:347)
	at org.jetbrains.kotlin.codegen.CodegenFactory.generateModule(CodegenFactory.kt:44)
	at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.generateModuleInFrontendIRMode(JvmIrCodegenFactory.kt:378)
	at org.jetbrains.kotlin.cli.jvm.compiler.pipeline.CompilerPipelineKt.generateCodeFromIr(compilerPipeline.kt:259)
	at org.jetbrains.kotlin.cli.jvm.compiler.pipeline.CompilerPipelineKt.compileModulesUsingFrontendIrAndLightTree(compilerPipeline.kt:150)
	at org.jetbrains.kotlin.cli.jvm.K2JVMCompiler.doExecute(K2JVMCompiler.kt:156)
	at org.jetbrains.kotlin.cli.jvm.K2JVMCompiler.doExecute(K2JVMCompiler.kt:50)
	at org.jetbrains.kotlin.cli.common.CLICompiler.execImpl(CLICompiler.kt:104)
	at org.jetbrains.kotlin.cli.common.CLICompiler.execImpl(CLICompiler.kt:48)
	at org.jetbrains.kotlin.cli.common.CLITool.exec(CLITool.kt:101)
	at org.jetbrains.kotlin.incremental.IncrementalJvmCompilerRunner.runCompiler(IncrementalJvmCompilerRunner.kt:456)
	at org.jetbrains.kotlin.incremental.IncrementalJvmCompilerRunner.runCompiler(IncrementalJvmCompilerRunner.kt:62)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.doCompile(IncrementalCompilerRunner.kt:477)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.compileImpl(IncrementalCompilerRunner.kt:400)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.compileNonIncrementally(IncrementalCompilerRunner.kt:281)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.compile(IncrementalCompilerRunner.kt:125)
	at org.jetbrains.kotlin.daemon.CompileServiceImplBase.execIncrementalCompiler(CompileServiceImpl.kt:640)
	at org.jetbrains.kotlin.daemon.CompileServiceImplBase.access$execIncrementalCompiler(CompileServiceImpl.kt:105)
	at org.jetbrains.kotlin.daemon.CompileServiceImpl.compile(CompileServiceImpl.kt:1611)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport$1.run(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport$1.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.ClassCastException: class org.jetbrains.kotlin.ir.expressions.impl.IrBlockImpl cannot be cast to class org.jetbrains.kotlin.ir.expressions.IrFunctionReference (org.jetbrains.kotlin.ir.expressions.impl.IrBlockImpl and org.jetbrains.kotlin.ir.expressions.IrFunctionReference are in unnamed module of loader 'app')
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.transform(InlineCallableReferenceToLambda.kt:73)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFunctionAccess(InlineCallableReferenceToLambda.kt:64)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFunctionAccess(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitCall(IrElementVisitor.kt:140)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitCall(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitCall(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.expressions.IrCall.accept(IrCall.kt:26)
	at org.jetbrains.kotlin.ir.declarations.IrVariable.acceptChildren(IrVariable.kt:41)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitDeclaration(IrElementVisitor.kt:23)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitVariable(IrElementVisitor.kt:71)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitVariable(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitVariable(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.declarations.IrVariable.accept(IrVariable.kt:38)
	at org.jetbrains.kotlin.ir.expressions.IrBlockBody.acceptChildren(IrBlockBody.kt:28)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitBody(IrElementVisitor.kt:86)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitBody(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitBody(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitBlockBody(IrElementVisitor.kt:92)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitBlockBody(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitBlockBody(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.expressions.IrBlockBody.accept(IrBlockBody.kt:25)
	at org.jetbrains.kotlin.ir.declarations.IrFunction.acceptChildren(IrFunction.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitDeclaration(IrElementVisitor.kt:23)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitFunction(IrElementVisitor.kt:38)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFunction(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFunction(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitSimpleFunction(IrElementVisitor.kt:65)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitSimpleFunction(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitSimpleFunction(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.declarations.IrSimpleFunction.accept(IrSimpleFunction.kt:37)
	at org.jetbrains.kotlin.ir.declarations.IrClass.acceptChildren(IrClass.kt:88)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitDeclaration(IrElementVisitor.kt:23)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitClass(IrElementVisitor.kt:29)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitClass(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitClass(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.declarations.IrClass.accept(IrClass.kt:84)
	at org.jetbrains.kotlin.ir.declarations.IrFile.acceptChildren(IrFile.kt:37)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitPackageFragment(IrElementVisitor.kt:74)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitPackageFragment(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitPackageFragment(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitFile(IrElementVisitor.kt:80)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFile(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFile(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.declarations.IrFile.accept(IrFile.kt:31)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaPhase.lower(InlineCallableReferenceToLambda.kt:49)
	at org.jetbrains.kotlin.backend.common.phaser.PhaseBuildersKt$makeIrFilePhase$2.invoke(PhaseBuilders.kt:136)
	at org.jetbrains.kotlin.backend.common.phaser.PhaseBuildersKt$makeIrFilePhase$2.invoke(PhaseBuilders.kt:128)
	at org.jetbrains.kotlin.backend.common.phaser.PhaseBuildersKt$createSimpleNamedCompilerPhase$1.phaseBody(PhaseBuilders.kt:72)
	at org.jetbrains.kotlin.backend.common.phaser.SimpleNamedCompilerPhase.phaseBody(CompilerPhase.kt:207)
	at org.jetbrains.kotlin.backend.common.phaser.AbstractNamedCompilerPhase.invoke(CompilerPhase.kt:94)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invokeSequential(performByIrFile.kt:62)
	... 45 more

Comments

al...@jetbrains.com <al...@jetbrains.com> #2Nov 23, 2023 09:34PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

se...@google.com <se...@google.com> Nov 28, 2023 07:02AM

Assigned to je...@google.com.

as...@google.com <as...@google.com> #3Nov 28, 2023 08:45AM

Reassigned to as...@google.com.

It looks like we have two problems here:

The IR shape for adapted function reference doesn't match expectation
We are memoizing lambdas/function references for an inline call

ap...@google.com <ap...@google.com> #4Nov 30, 2023 05:33AM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 2c45d16b1455ab3c5f05ea3914baf37b158807ea
Author: Andrei Shikov <ashikov@google.com>
Date: Tue Nov 28 17:31:46 2023

Fix memoization of adapted function references and inline arguments

Adapted function references (function references with inexact signature match, e.g. w/ default parameters) generate a block around function reference with adapter lambda. The later Kotlin lowerings expect this IR shape to be preserved, so Compose needs to account for it and wrap whole block instead.

This change also fixes memoization of function references for inline function parameters, making sure we correctly inline function references.

Fixes: 312738720
Test: Updated compiler test
Change-Id: If4858efc32854c03393e00d71f8248037aab26d4

M compose/compiler/compiler-hosted/integration-tests/src/androidUnitTest/kotlin/androidx/compose/compiler/plugins/kotlin/ComposerParamSignatureTests.kt
M compose/compiler/compiler-hosted/integration-tests/src/jvmTest/kotlin/androidx/compose/compiler/plugins/kotlin/LambdaMemoizationTransformTests.kt
M compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.ControlFlowTransformTests/testReturnNull[useFir = false].txt
M compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.ControlFlowTransformTests/testReturnNull[useFir = true].txt
A compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.LambdaMemoizationTransformTests/testAdaptedFunctionRef[useFir = false].txt
A compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.LambdaMemoizationTransformTests/testAdaptedFunctionRef[useFir = true].txt
M compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.RememberIntrinsicTransformTests/testRememberAdaptedFunctionReference[useFir = false].txt
M compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.RememberIntrinsicTransformTests/testRememberAdaptedFunctionReference[useFir = true].txt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposerLambdaMemoization.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/IrInlineReferenceLocator.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/IrSourcePrinter.kt

https://android-review.googlesource.com/2850585

si...@gmail.com <si...@gmail.com> #5Dec 6, 2023 09:03PM

Fixed in androidx.compose.compiler:compiler:1.5.6

Issue 312738720