CCE "IrBlockImpl cannot be cast to IrFunctionReference" on inlining adapted function reference [312738720]

Fixed

Bug

Status Update

No update yet.

Description

al...@jetbrains.com

created issue #1

Nov 23, 2023 09:33PM

Jetpack Compose version: 1.5.5-dev-k2.0.0-Beta1-06b8ae672a4

~~Jetpack Compose component(s) used:~~

~~Android Studio Build:~~

Kotlin version: 2.0.0-Beta1

Steps to Reproduce or Code Sample to Reproduce:

See https://youtrack.jetbrains.com/issue/KT-63722. I believe the issue is in Compose rather than in Kotlin, so reporting it here.

import androidx.compose.runtime.Composable

class ScrollState {
    fun scrollToItem(index: Int, default: Int = 0) = Unit
}

@Composable
fun ScrollState.rememberDraggableScroller(): (Float) -> Unit = rememberDraggableScroller(::scrollToItem)

@Composable
inline fun rememberDraggableScroller(lambda: (index: Int) -> Unit): (Float) -> Unit = {}

Stack trace (if applicable):

org.jetbrains.kotlin.backend.common.BackendException: Backend Internal error: Exception during IR lowering
File being compiled: /Users/Ivan.Kubyshkin/AndroidStudioProjects/MyApplication23/app/src/main/java/com/example/myapplication/MainActivity.kt
The root cause java.lang.ClassCastException was thrown at: org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.transform(InlineCallableReferenceToLambda.kt:73)
	at org.jetbrains.kotlin.backend.common.CodegenUtil.reportBackendException(CodegenUtil.kt:253)
	at org.jetbrains.kotlin.backend.common.CodegenUtil.reportBackendException$default(CodegenUtil.kt:236)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invokeSequential(performByIrFile.kt:65)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invoke(performByIrFile.kt:52)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invoke(performByIrFile.kt:38)
	at org.jetbrains.kotlin.backend.common.phaser.NamedCompilerPhase.phaseBody(CompilerPhase.kt:147)
	at org.jetbrains.kotlin.backend.common.phaser.AbstractNamedCompilerPhase.invoke(CompilerPhase.kt:94)
	at org.jetbrains.kotlin.backend.common.phaser.CompositePhase.invoke(PhaseBuilders.kt:30)
	at org.jetbrains.kotlin.backend.common.phaser.CompositePhase.invoke(PhaseBuilders.kt:17)
	at org.jetbrains.kotlin.backend.common.phaser.NamedCompilerPhase.phaseBody(CompilerPhase.kt:147)
	at org.jetbrains.kotlin.backend.common.phaser.AbstractNamedCompilerPhase.invoke(CompilerPhase.kt:94)
	at org.jetbrains.kotlin.backend.common.phaser.CompilerPhaseKt.invokeToplevel(CompilerPhase.kt:43)
	at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.invokeLowerings(JvmIrCodegenFactory.kt:347)
	at org.jetbrains.kotlin.codegen.CodegenFactory.generateModule(CodegenFactory.kt:44)
	at org.jetbrains.kotlin.backend.jvm.JvmIrCodegenFactory.generateModuleInFrontendIRMode(JvmIrCodegenFactory.kt:378)
	at org.jetbrains.kotlin.cli.jvm.compiler.pipeline.CompilerPipelineKt.generateCodeFromIr(compilerPipeline.kt:259)
	at org.jetbrains.kotlin.cli.jvm.compiler.pipeline.CompilerPipelineKt.compileModulesUsingFrontendIrAndLightTree(compilerPipeline.kt:150)
	at org.jetbrains.kotlin.cli.jvm.K2JVMCompiler.doExecute(K2JVMCompiler.kt:156)
	at org.jetbrains.kotlin.cli.jvm.K2JVMCompiler.doExecute(K2JVMCompiler.kt:50)
	at org.jetbrains.kotlin.cli.common.CLICompiler.execImpl(CLICompiler.kt:104)
	at org.jetbrains.kotlin.cli.common.CLICompiler.execImpl(CLICompiler.kt:48)
	at org.jetbrains.kotlin.cli.common.CLITool.exec(CLITool.kt:101)
	at org.jetbrains.kotlin.incremental.IncrementalJvmCompilerRunner.runCompiler(IncrementalJvmCompilerRunner.kt:456)
	at org.jetbrains.kotlin.incremental.IncrementalJvmCompilerRunner.runCompiler(IncrementalJvmCompilerRunner.kt:62)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.doCompile(IncrementalCompilerRunner.kt:477)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.compileImpl(IncrementalCompilerRunner.kt:400)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.compileNonIncrementally(IncrementalCompilerRunner.kt:281)
	at org.jetbrains.kotlin.incremental.IncrementalCompilerRunner.compile(IncrementalCompilerRunner.kt:125)
	at org.jetbrains.kotlin.daemon.CompileServiceImplBase.execIncrementalCompiler(CompileServiceImpl.kt:640)
	at org.jetbrains.kotlin.daemon.CompileServiceImplBase.access$execIncrementalCompiler(CompileServiceImpl.kt:105)
	at org.jetbrains.kotlin.daemon.CompileServiceImpl.compile(CompileServiceImpl.kt:1611)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
	at java.base/java.lang.reflect.Method.invoke(Unknown Source)
	at java.rmi/sun.rmi.server.UnicastServerRef.dispatch(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport$1.run(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport$1.run(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.rmi/sun.rmi.transport.Transport.serviceCall(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport.handleMessages(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run0(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.lambda$run$0(Unknown Source)
	at java.base/java.security.AccessController.doPrivileged(Unknown Source)
	at java.rmi/sun.rmi.transport.tcp.TCPTransport$ConnectionHandler.run(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)
	at java.base/java.lang.Thread.run(Unknown Source)
Caused by: java.lang.ClassCastException: class org.jetbrains.kotlin.ir.expressions.impl.IrBlockImpl cannot be cast to class org.jetbrains.kotlin.ir.expressions.IrFunctionReference (org.jetbrains.kotlin.ir.expressions.impl.IrBlockImpl and org.jetbrains.kotlin.ir.expressions.IrFunctionReference are in unnamed module of loader 'app')
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.transform(InlineCallableReferenceToLambda.kt:73)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFunctionAccess(InlineCallableReferenceToLambda.kt:64)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFunctionAccess(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitCall(IrElementVisitor.kt:140)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitCall(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitCall(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.expressions.IrCall.accept(IrCall.kt:26)
	at org.jetbrains.kotlin.ir.declarations.IrVariable.acceptChildren(IrVariable.kt:41)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitDeclaration(IrElementVisitor.kt:23)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitVariable(IrElementVisitor.kt:71)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitVariable(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitVariable(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.declarations.IrVariable.accept(IrVariable.kt:38)
	at org.jetbrains.kotlin.ir.expressions.IrBlockBody.acceptChildren(IrBlockBody.kt:28)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitBody(IrElementVisitor.kt:86)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitBody(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitBody(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitBlockBody(IrElementVisitor.kt:92)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitBlockBody(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitBlockBody(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.expressions.IrBlockBody.accept(IrBlockBody.kt:25)
	at org.jetbrains.kotlin.ir.declarations.IrFunction.acceptChildren(IrFunction.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitDeclaration(IrElementVisitor.kt:23)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitFunction(IrElementVisitor.kt:38)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFunction(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFunction(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitSimpleFunction(IrElementVisitor.kt:65)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitSimpleFunction(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitSimpleFunction(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.declarations.IrSimpleFunction.accept(IrSimpleFunction.kt:37)
	at org.jetbrains.kotlin.ir.declarations.IrClass.acceptChildren(IrClass.kt:88)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitDeclaration(IrElementVisitor.kt:23)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitDeclaration(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitClass(IrElementVisitor.kt:29)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitClass(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitClass(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.declarations.IrClass.accept(IrClass.kt:84)
	at org.jetbrains.kotlin.ir.declarations.IrFile.acceptChildren(IrFile.kt:37)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:56)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitElement(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitPackageFragment(IrElementVisitor.kt:74)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitPackageFragment(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitPackageFragment(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.visitors.IrElementVisitor$DefaultImpls.visitFile(IrElementVisitor.kt:80)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFile(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaVisitor.visitFile(InlineCallableReferenceToLambda.kt:54)
	at org.jetbrains.kotlin.ir.declarations.IrFile.accept(IrFile.kt:31)
	at org.jetbrains.kotlin.backend.jvm.lower.InlineCallableReferenceToLambdaPhase.lower(InlineCallableReferenceToLambda.kt:49)
	at org.jetbrains.kotlin.backend.common.phaser.PhaseBuildersKt$makeIrFilePhase$2.invoke(PhaseBuilders.kt:136)
	at org.jetbrains.kotlin.backend.common.phaser.PhaseBuildersKt$makeIrFilePhase$2.invoke(PhaseBuilders.kt:128)
	at org.jetbrains.kotlin.backend.common.phaser.PhaseBuildersKt$createSimpleNamedCompilerPhase$1.phaseBody(PhaseBuilders.kt:72)
	at org.jetbrains.kotlin.backend.common.phaser.SimpleNamedCompilerPhase.phaseBody(CompilerPhase.kt:207)
	at org.jetbrains.kotlin.backend.common.phaser.AbstractNamedCompilerPhase.invoke(CompilerPhase.kt:94)
	at org.jetbrains.kotlin.backend.common.phaser.PerformByIrFilePhase.invokeSequential(performByIrFile.kt:62)
	... 45 more

Comments

al...@jetbrains.com <al...@jetbrains.com> #2Nov 23, 2023 09:34PM

I simpler example would be appreciated. I tried to download the pull request and build it but it relies on, for example, `rustc` to be installed which I don't have installed on my compose development machine.

Does the program work without the compiler switch. That is, is `"-P", "plugin:androidx.compose.compiler.plugins.kotlin:experimentalStrongSkipping=true",` required to reproduce or is just changing the runtime enough?

se...@google.com <se...@google.com> Nov 28, 2023 07:02AM

Assigned to je...@google.com.

as...@google.com <as...@google.com> #3Nov 28, 2023 08:45AM

Reassigned to as...@google.com.

Yeah, changing compiler switch(enable/disable StrongSkipping, enable/disable nonSkippingGroup) has no effect, only changing runtime make sense.
Sorry for that, I will try to extract an example when I'm free.

ap...@google.com <ap...@google.com> #4Nov 30, 2023 05:33AM

Marked as fixed.

I have find a sample code to reproduce that

        setContent {
            val dialogState = remember { DialogState() }
            dialogState.Intercept()
            LaunchedEffect(Unit) {
                delay(1000)
                dialogState.bgWork {
                    delay(5000)
                }
                dialogState.showSelectActions {
                    onSelect("a") {

                    }
                    onSelect("b") {

                    }
                }
            }
        }

You can find implementation of DialogState here https://github.com/FooIbar/EhViewer/blob/ef16bdeb755ae888c74eaa4a337bd5b708fcc97e/app/src/main/kotlin/com/hippo/ehviewer/ui/tools/Dialog.kt#L92
https://github.com/FooIbar/EhViewer/blob/main/app/src/main/kotlin/com/hippo/ehviewer/util/Progress.kt Launch that Activity, wait 6 seconds and it will crash

si...@gmail.com <si...@gmail.com> #5Dec 6, 2023 09:03PM

Let me sort it out

The first crash
Reproduce: navigate to a gallery and navigate back
The reason is we have some code assume the forget order of RememberObserver(DisposableEffect), and 52835066c9044647a65dfb566f03131aab46e793 changed the order. Seems this is a intended behaviour.
I will fix it from my side. My bad

The second crash
Reproduce: #4 comment
StackTrace: https://bin.kv2.dev/~65d5c6175de7ed6bfdbdf1bd
We got a wrong object from SlotTable during recompose

Issue 312738720