Restoring Fragment inside compose [312895363]

Fixed

Feature Request

Status Update

No update yet.

Description

ju...@veepee.com

created issue #1

Nov 23, 2023 02:58PM

What is the correct strategy to restoring a fragment commited inside a compose AndroidView? I would expect that something like the example below to be enough to handle the fragment state restoration in an orientation change, but when rotating the screen the fragment is no longer drawn.

                   val containerId = rememberSaveable {
                        ViewCompat.generateViewId()
                    }
                    val fragmentTag = rememberSaveable {
                        "FragmentTag$containerId"
                    }
                    AndroidView(factory = { context ->
                        FragmentContainerView(context).apply {
                            id = containerId
                        }
                    }, update = { containerView ->
                        if (containerView.getFragment<Fragment?>() == null) {
                            supportFragmentManager.commit {
                                replace(containerId, SomeFragment(), fragmentTag)
                            }
                        }
                    })

StackOverflow proposes a solution using reflection, but as that is not a public API I would like to avoid using it and instead having a proper support from androidx team.

It would be nice to have a composable version of FragmentContainerView that could handle Fragment state restoration properly.

FragmentStateRestorationInsideCompose.zip

115 KB

Download

Comments

jb...@google.com <jb...@google.com> #2Nov 27, 2023 04:12PM

Seems to be a DNS problem with systems that have 'obtain DNS server address automatically'. Changed my system to a manual setting and the browser etc now work. SDK 2.2 didn't seem to mind the auto setting though.

ju...@gmail.com <ju...@gmail.com> #3Nov 28, 2023 02:02PM

Could you please describe how/where you changed your system to a manual setting?

ju...@gmail.com <ju...@gmail.com> #4Nov 28, 2023 02:03PM

Based on its date, this issue was originally reported before Android 2.3. Because of the many changes that existed in Android 4.x compared to previous versions, it's very likely that this issue doesn't exist in recent versions of Android like 4.2.2 or newer. Because of the high likelihood that this issue is obsolete, it is getting closed automatically by a script, without a human looking at it in detail. If the issue still exists on a Nexus 4 or Nexus 7 running Android 4.2.2 and is not related to Google applications, please open a new report accordingly.

ap...@google.com <ap...@google.com> #5Mar 27, 2024 11:07PM

java.lang.IllegalArgumentException: Unable to locate adb
at com.android.tools.idea.run.editor.DeployTargetPickerDialog.<init>(DeployTargetPickerDialog.java:144)
at com.android.tools.idea.run.editor.ShowChooserTargetProvider.showPrompt(ShowChooserTargetProvider.java:113)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getDeployTarget(AndroidRunConfigurationBase.java:600)
at com.android.tools.idea.run.AndroidRunConfigurationBase.doGetState(AndroidRunConfigurationBase.java:281)
at com.android.tools.idea.run.AndroidRunConfigurationBase.getState(AndroidRunConfigurationBase.java:241)
at com.intellij.execution.runners.ExecutionEnvironment.getState(ExecutionEnvironment.java:158)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:55)
at com.intellij.execution.runners.BaseProgramRunner.execute(BaseProgramRunner.java:50)
at com.intellij.execution.ProgramRunnerUtil.executeConfigurationAsync(ProgramRunnerUtil.java:92)
at com.intellij.execution.ProgramRunnerUtil.executeConfiguration(ProgramRunnerUtil.java:41)
at com.intellij.execution.impl.ExecutionManagerImpl.restart(ExecutionManagerImpl.java:93)
at com.intellij.execution.impl.ExecutionManagerImpl.access$300(ExecutionManagerImpl.java:44)
at com.intellij.execution.impl.ExecutionManagerImpl$3.run(ExecutionManagerImpl.java:442)
at com.intellij.util.concurrency.QueueProcessor.runSafely(QueueProcessor.java:232)
at com.intellij.util.Alarm$Request.runSafely(Alarm.java:356)
at com.intellij.util.Alarm$Request.run(Alarm.java:343)
at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at com.intellij.util.concurrency.SchedulingWrapper$MyScheduledFutureTask.run(SchedulingWrapper.java:228)
at com.intellij.openapi.application.TransactionGuardImpl$2.run(TransactionGuardImpl.java:315)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.doRun(LaterInvocator.java:435)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.runNextEvent(LaterInvocator.java:419)
at com.intellij.openapi.application.impl.LaterInvocator$FlushQueue.run(LaterInvocator.java:403)
at java.awt.event.InvocationEvent.dispatch(InvocationEvent.java:311)
at java.awt.EventQueue.dispatchEventImpl(EventQueue.java:762)
at java.awt.EventQueue.access$500(EventQueue.java:98)
at java.awt.EventQueue$3.run(EventQueue.java:715)
at java.awt.EventQueue$3.run(EventQueue.java:709)
at java.security.AccessController.doPrivileged(Native Method)
at java.security.ProtectionDomain$JavaSecurityAccessImpl.doIntersectionPrivilege(ProtectionDomain.java:80)
at java.awt.EventQueue.dispatchEvent(EventQueue.java:732)
at com.intellij.ide.IdeEventQueue.defaultDispatchEvent(IdeEventQueue.java:755)
at com.intellij.ide.IdeEventQueue._dispatchEvent(IdeEventQueue.java:704)
at com.intellij.ide.IdeEventQueue.dispatchEvent(IdeEventQueue.java:391)
at java.awt.EventDispatchThread.pumpOneEventForFilters(EventDispatchThread.java:201)
at java.awt.EventDispatchThread.pumpEventsForFilter(EventDispatchThread.java:116)
at java.awt.EventDispatchThread.pumpEventsForHierarchy(EventDispatchThread.java:105)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:101)
at java.awt.EventDispatchThread.pumpEvents(EventDispatchThread.java:93)
at java.awt.EventDispatchThread.run(EventDispatchThread.java:82)

ju...@veepee.com <ju...@veepee.com> #6Mar 28, 2024 10:02AM

voilà ce qu'on m'affiche lorsque j’exécute mon programme

il...@google.com <il...@google.com> #7Mar 28, 2024 04:59PM

je ne vois pas comment résoudre ce problème. svp aidez moi

il...@google.com <il...@google.com> #8Mar 28, 2024 05:01PM

I'll note that FragmentFactory does allow you to request an AbstractBaseFragment and redirect it to a specific subclass of that class without exposing that subclass itself if you do need that level of indirection.

ju...@veepee.com <ju...@veepee.com> #9Mar 29, 2024 07:18AM

We were always allowed to create a new Fragment and to commit a Fragment instance in FragmentManager, could you align with that as well? My abstraction returns a Fragment instance because this allows us to avoid directly depending on the gradle module that provides the Fragment and this strategy improves compilation time by making the gradle dependency graph flatter.

Message last modified on Mar 29, 2024 07:43AM

il...@google.com <il...@google.com> #10Mar 29, 2024 05:01PM

You'll want your abstraction to be implemented in terms of a FragmentFactory.

ju...@veepee.com <ju...@veepee.com> #11Apr 2, 2024 08:20AM

My abstraction does not use fragmentFactory, and don't need to. How is that related to this issue? Devs have always been able to instantiate a fragment using default fragment constructor, I am not exposing which Fragment subclass is being instantiated in the calling site or using the className as key to find which fragment to instantiate, to add a fragment to FragmentManager we just need the base class Fragment.

ba...@gmail.com <ba...@gmail.com> #12Apr 4, 2024 09:10AM

Hi. Would it be possible to update an existing fragment when the args given to it change? I've a PageFragment in my app that load an url received as argument. When I navigate using my bottom bar, a PageFragment is loaded with different url for each. Right now it won't work with AndroidFragment as the clazz is the same and it won't recompose based on arguments alone.

il...@google.com <il...@google.com> #13Apr 8, 2024 05:55PM

Re comment#12 - you can surround the AndroidFragment with key(url) to reset that subtree whenever url changes.

ba...@gmail.com <ba...@gmail.com> #14Apr 8, 2024 07:52PM

Thanks, using key(url) works like a charm. I thought this function was only available for LazyList|Column...

ba...@gmail.com <ba...@gmail.com> #15Apr 25, 2024 12:23PM

For your information we have the following crash using AndroidView:

Exception java.lang.IllegalStateException: Can not perform this action after onSaveInstanceState at androidx.fragment.app.FragmentManager.checkStateLoss (FragmentManager.java:1) at androidx.fragment.app.FragmentManager.ensureExecReady (FragmentManager.java:1) at androidx.fragment.app.FragmentManager.execSingleAction (FragmentManager.java:1) at androidx.fragment.app.BackStackRecord.commitNow (BackStackRecord.java:1) at androidx.fragment.compose.AndroidFragmentKt$AndroidFragment$4.invoke (AndroidFragment.kt:110) at androidx.fragment.compose.AndroidFragmentKt$AndroidFragment$4.invoke (AndroidFragment.kt:3) at androidx.compose.runtime.DisposableEffectImpl.onRemembered (Effects.kt:7) at androidx.compose.runtime.CompositionImpl$RememberEventDispatcher.dispatchRememberObservers (Composition.kt:144) at androidx.compose.runtime.CompositionImpl.applyChangesInLocked (Composition.kt:1) at androidx.compose.runtime.CompositionImpl.applyChanges (Composition.kt:6) at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke (Recomposer.kt:1) at androidx.compose.runtime.Recomposer$runRecomposeAndApplyChanges$2$1.invoke (Recomposer.kt:7) at androidx.compose.ui.platform.AndroidUiFrameClock$withFrameNanos$2$callback$1.doFrame (AndroidUiFrameClock.android.kt:11) at androidx.compose.ui.platform.AndroidUiDispatcher.performFrameDispatch (AndroidUiDispatcher.android.kt:34) at androidx.compose.ui.platform.AndroidUiDispatcher.access$performFrameDispatch (AndroidUiDispatcher.android.kt:1) at androidx.compose.ui.platform.AndroidUiDispatcher$dispatchCallback$1.doFrame (AndroidUiDispatcher.android.kt:17) at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1229) at android.view.Choreographer$CallbackRecord.run (Choreographer.java:1239) at android.view.Choreographer.doCallbacks (Choreographer.java:899) at android.view.Choreographer.doFrame (Choreographer.java:827) at android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1214) at android.os.Handler.handleCallback (Handler.java:942) at android.os.Handler.dispatchMessage (Handler.java:99) at android.os.Looper.loopOnce (Looper.java:201) at android.os.Looper.loop (Looper.java:288) at android.app.ActivityThread.main (ActivityThread.java:7918) at java.lang.reflect.Method.invoke at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main (ZygoteInit.java:936)

lo...@gmail.com <lo...@gmail.com> #16Apr 25, 2024 03:18PM

Will there also be an overload in which we can directly pass in an already created fragment instance? Like:

fun <T : Fragment> AndroidFragment(
    fragment: T,
    modifier: Modifier = Modifier,
    fragmentState: FragmentState = rememberFragmentState(),
    arguments: Bundle = Bundle.EMPTY,
    onUpdate: (T) -> Unit = { },
) { ... }

il...@google.com <il...@google.com> #17Apr 25, 2024 07:59PM

Re comment#15 - please file a separate issue so we can track that crash.

il...@google.com <il...@google.com> #18Apr 25, 2024 08:00PM

Marked as fixed, reassigned to jb...@google.com.

Re comment#16 - no, as explained in comment#7.