Status Update
Comments
ja...@gmail.com <ja...@gmail.com> #2
This is a particularly hard device to come by - do you happen to have access to the device? If so could you provide us with the output of: adb shell dumpsys media.camera > info.txt
Thanks!
ja...@gmail.com <ja...@gmail.com> #3
Stacktrace:
Caused by: java.lang.IllegalArgumentException: Can not get supported output size under supported maximum for the format: 34
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes(SupportedSurfaceCombination.java:355)
at androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions(SupportedSurfaceCombination.java:197)
at androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions(Camera2DeviceSurfaceManager.java:198)
at androidx.camera.core.CameraX.calculateSuggestedResolutions(CameraX.java:943)
at androidx.camera.core.CameraX.bindToLifecycle(CameraX.java:293)
at androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle(ProcessCameraProvider.java:227)
Below are some findings based on our debugging
When Dex is connected
previewConfig.getMaxResolution() is returning "731x411" as maxSize.
Inside Preview.Builder.build() -> Default_MAX_resolution is set to "CameraX.getSurfaceManager().getPreviewSize()" which is 731x411
this is being picked as maxSize.
While rendering maxSize is 731x411 and minSize is 640x480 and below are available outputSizes
0 = {Size@11860} "4032x3024"
1 = {Size@11861} "3984x2988"
2 = {Size@11862} "4032x2268"
3 = {Size@11863} "3024x3024"
4 = {Size@11864} "2976x2976"
5 = {Size@11865} "3840x2160"
6 = {Size@11866} "3264x2448"
7 = {Size@11867} "4032x1960"
8 = {Size@11868} "2880x2160"
9 = {Size@11869} "3264x1836"
10 = {Size@11870} "2160x2160"
11 = {Size@11871} "2560x1440"
12 = {Size@11872} "2224x1080"
13 = {Size@11873} "2048x1152"
14 = {Size@11874} "1920x1080"
15 = {Size@11875} "1440x1080"
16 = {Size@11876} "1088x1088"
17 = {Size@11877} "1280x720"
18 = {Size@11878} "1024x768"
19 = {Size@11879} "1056x704"
20 = {Size@11880} "960x720"
21 = {Size@11881} "960x540"
22 = {Size@11882} "720x720"
23 = {Size@11883} "800x450"
24 = {Size@11884} "720x480"
25 = {Size@11885} "640x480"
26 = {Size@11886} "352x288"
27 = {Size@11887} "320x240"
28 = {Size@11888} "256x144"
29 = {Size@11889} "176x144"
and couldn't find any size in this range.
When Dex not connected
minsize = 640x480
maxsize = 1920x1080
0 = {Size@11836} "4032x3024"
1 = {Size@11837} "3984x2988"
2 = {Size@11838} "4032x2268"
3 = {Size@11839} "3024x3024"
4 = {Size@11840} "2976x2976"
5 = {Size@11841} "3840x2160"
6 = {Size@11842} "3264x2448"
7 = {Size@11843} "4032x1960"
8 = {Size@11844} "2880x2160"
9 = {Size@11845} "3264x1836"
10 = {Size@11846} "2160x2160"
11 = {Size@11847} "2560x1440"
12 = {Size@11848} "2224x1080"
13 = {Size@11849} "2048x1152"
14 = {Size@11850} "1920x1080"
15 = {Size@11851} "1440x1080"
16 = {Size@11852} "1088x1088"
17 = {Size@11853} "1280x720"
18 = {Size@11854} "1024x768"
19 = {Size@11855} "1056x704"
20 = {Size@11856} "960x720"
21 = {Size@11857} "960x540"
22 = {Size@11858} "720x720"
23 = {Size@11859} "800x450"
24 = {Size@11860} "720x480"
25 = {Size@11861} "640x480"
26 = {Size@11862} "352x288"
27 = {Size@11863} "320x240"
28 = {Size@11864} "256x144"
29 = {Size@11865} "176x144"
and we have 12 available sizes in this range
Camera2DeviceSurfaceManager.java:: getPreviewSize()
mCameraSupportedSurfaceCombinationMap.get(cameraId).getSurfaceDefinition().getPreviewSize() = "1920x1080"
cameraId=0
ju...@google.com <ju...@google.com> #4
The issue root cause is that CameraX will default filter out sizes smaller than 640x480. For Preview, the max size will be limited to under display size. I checked the HW spec info for the issue related devices. Display size of FUJITSU F-04J/F-05J is 360x640. That will result int that no size exists in the conditions that is larger or equal to 640x480 and smaller or equal to 360x640.
A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
For device FUJITSU arrowsM04, I checked its HW spec info and its display size I found is 1280x720. It seems that the problem should not exist in the device.
Could you confirm that the problem exist on arrowsM04 device? What will be the returned value when using Display#getRealSize to obtain the display size?
ap...@google.com <ap...@google.com> #5
> A temporary workaround for this situation is to use Preview.Builder#setTargetResolution() to set a size smaller than 640x480 to bypass the problem.
OK. I will try it.
> Could you confirm that the problem exist on arrowsM04 device?
We receive the crash report (Crashlytics) that this crash has occurred on arrowsM04.
We don't have this device so we can't confirm that the problem really exist on arrowsM04.
> What will be the returned value when using Display#getRealSize to obtain the display size?
We can't investigate it for the same reason.
Thank you.
ju...@google.com <ju...@google.com>
ma...@marcardar.com <ma...@marcardar.com> #6
This issue happened on devices that the display size is smaller than 640x480. In original auto-resolution mechanism, supported sizes smaller than 640x480 will be default filter out.
The auto-resolution mechanism encodes the guaranteed configurations tables in CameraDevice#createCaptureSession(SessionConfiguration). It defines that the PREVIEW size is the small one of the device display size and 1080p. The PREVIEW size will be the maximal size limitation for Preview use case. The reason it limits the size to display size and 1080p is the stream output in display size or 1080p has been able to provide good enough preview quality. Therefore, auto-resolution mechanism will limit the selected size to be smaller than the small one of the device display size and 1080p.
With above two conditions, in this issue, all sizes smaller than 640x480 have been filter out, therefore, there is no size smaller than the display size 320x240 can be selected to use. And cause the exception.
Solution:
When the display size is smaller than 640x480, auto-resolution mechanism won't filter out those small sizes smaller than 640x480. This makes those small size be left and can be selected for the Preview use case on small display devices.
The solution has been merged and will be included in next CameraX release.
ju...@google.com <ju...@google.com> #7
Hello.
This crash still occurs.
- CAMERAX VERSION: 1.0.0-beta4
- ANDROID OS BUILD NUMBER: Android 7.1.1
- DEVICE NAME: FUJITSU F-02H
We receive following crash report from FUJITSU F-02H. So far We have received this crash report only from F-02H.
java.lang.IllegalArgumentException
Can not get supported output size under supported maximum for the format: 34
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSupportedOutputSizes (SupportedSurfaceCombination.java:349)
androidx.camera.camera2.internal.SupportedSurfaceCombination.getSuggestedResolutions (SupportedSurfaceCombination.java:197)
androidx.camera.camera2.internal.Camera2DeviceSurfaceManager.getSuggestedResolutions (Camera2DeviceSurfaceManager.java:198)
androidx.camera.core.CameraX.calculateSuggestedResolutions (CameraX.java:949)
androidx.camera.core.CameraX.bindToLifecycle (CameraX.java:351)
androidx.camera.lifecycle.ProcessCameraProvider.bindToLifecycle (ProcessCameraProvider.java:230)
(our application's package name).CameraFragment.bindCameraUseCases (CameraFragment.java:174)
ga...@gmail.com <ga...@gmail.com> #8
Could you help to provide the following information to clarify the issue?
1. Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
2. Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
ma...@marcardar.com <ma...@marcardar.com> #9
- Is the full name of the device Fujitsu Arrows NX F-02H that has a 1440x2560 display?
Yes
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
Since we don't have this device, we'll try to collect this information in the next version of our app. The next version will be released later this month.
lv...@hubspot.com <lv...@hubspot.com> #10
Hello.
- Please help to provide the supported output sizes of ImageFormat.PRIVATE that is obtained by StreamConfigurationMap#getOutputSizes(int).
We have collected the output of the device where the crash occurs.
Device1
- Model : arrows Be F-05J
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Device2
- Model : Fujitsu arrows M04
- Android Version : 7.1.1
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0: 480x480
CameraId 1: 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
Additional Information
CameraX version : 1.0.0-beta04
We collect the supported output sizes by following code.
val errorString = buildString {
append("The supported output sizes of ImageFormat.PRIVATE: ")
(requireContext().getSystemService(Context.CAMERA_SERVICE) as CameraManager).apply {
cameraIdList.forEachIndexed { index, cameraId ->
val msg = if (VERSION.SDK_INT >= VERSION_CODES.M) {
val configurationMap =
getCameraCharacteristics(cameraId).get(CameraCharacteristics.SCALER_STREAM_CONFIGURATION_MAP)
val sizes = configurationMap?.getOutputSizes(ImageFormat.PRIVATE)
"CameraId $index: ${sizes?.joinToString(" ,")}"
} else {
"CameraId $index: This device version is under M."
}
append(msg)
}
}
}
ap...@google.com <ap...@google.com> #11
ju...@google.com <ju...@google.com> #12
I tried to find the device specs and both 720x1280
size display. For the camera id 0 device, it is a different case that the display size is larger than 640x480
but the device only supports a 480x480
size. The case also caused the same IllegalArgumentException and was also fixed by 1.0.0-beta04
release. Before 480x480
size would be filtered out and then caused the IllegalArgumentException. After it was merged, the 640x480
size threshold was removed and then the 480x480
size would be kept and selected to use.
It looks like 1.0.0-beta04
release had been used to collect the supported sizes information. But the issue should have been fixed by 1.0.0-beta04
release. Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
CameraX's 1.0.0-beta04
version. Maybe you can also consider to upgrade to the latest 1.0.0-rc01
version for your application. Thanks.
na...@google.com <na...@google.com> #13
Did you only check the device model name to collect the supported sizes information or collect the information when the IllegalArgumentException issue happens again?
We collect informations only from the device on which IllegalArgumentException happened.
Our latest app uses CameraX version 1.0.0-beta10
and this issue still occurres.
However we don't receive crash report from Fujitsu arrows Be F-05J
or Fujitsu arrows M04
so far. (This doesn't mean this issue is fixed on these devices because our app is heavily rely on camera so these device's user wouldn't use our app anymore.)
Instead, we receive crash report from
- Model : Fujitsu F-03K
- Android Version : 7.1.2
- Supported output sizes of ImageFormat.PRIVATE
CameraId 0 : 480x480
CameraId 1 : 2048x1536 ,1920x1080 ,1280x720 ,960x720 ,640x480 ,320x240 ,176x144
se...@branch.co <se...@branch.co> #14
I missed some settings when I simulated the issue by robolectric test so that I was not able to reproduce it. Now, I can reproduce the issue if the device only supports one 480x480 resolution. I'm working on the solution and target to make it included in next release.
ju...@google.com <ju...@google.com> #15
Branch: androidx-main
commit 69d15dff7bb857ee33a0f643ff42a0f8bc475ab2
Author: charcoalchen <charcoalchen@google.com>
Date: Fri Jan 08 18:30:03 2021
Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Do not filter out sizes smaller than 640x480 when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480.
Relnote:"Fixed IllegalArgumentException issue happened when all preview supported sizes are smaller than 640x480 and display size is larger than 640x480."
Bug: 150506192
Test: SupportedSurfaceCombinationTest
Change-Id: I2a63ce8e2ad42a9cc060c8635ac3603bf440b1ec
M camera/camera-camera2/src/main/java/androidx/camera/camera2/internal/SupportedSurfaceCombination.java
M camera/camera-camera2/src/test/java/androidx/camera/camera2/internal/SupportedSurfaceCombinationTest.java
se...@branch.co <se...@branch.co> #16
ja...@gmail.com <ja...@gmail.com> #17
We do not know how to reproduce this issue, unfortunately. Which also seems the case of the original commenter.
That's me, and yep: no reproduction path still. I'm in the process of releasing an update with Compose 2024.04.01 and will post an update on how the crashes develop.
There is one interesting thing though, this is only happening on Android 14 but does not seem to be happening on Pixel devices.
Also 100% Android 14 here, according to Crashlytics for the ~500 crashes every month for this issue. I do see Google in the list. Just at 2% of the crashes but it's there.
qu...@gmail.com <qu...@gmail.com> #18
lu...@gmail.com <lu...@gmail.com> #19
ju...@google.com <ju...@google.com> #20
We're still investigating this issue. If anyone has information on reproducing the crash, please share here.
ma...@gmail.com <ma...@gmail.com> #21
it...@gmail.com <it...@gmail.com> #22
Any updates? I am having the same crash with latest compose bom
jetpackComposeBom = "2024.05.00"
androidx.compose.ui.text.input.CursorAnchorInfoController.updateCursorAnchorInfo (CursorAnchorInfoController.android.kt:150)
androidx.compose.ui.text.input.CursorAnchorInfoController.updateTextLayoutResult (CursorAnchorInfoController.java:119)
androidx.compose.ui.text.input.TextInputServiceAndroid.updateTextLayoutResult (TextInputServiceAndroid.android.kt:434)
androidx.compose.ui.text.input.TextInputSession.updateTextLayoutResult (TextInputSession.java:215)
androidx.compose.foundation.text.TextFieldDelegate$Companion.updateTextLayoutResult$foundation_release (TextFieldDelegate.java:202)
androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1.invoke (CoreTextField.kt:438)
androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1.invoke (CoreTextField.kt:415)
androidx.compose.ui.layout.OnGloballyPositionedNode.onGloballyPositioned (OnGloballyPositionedModifier.kt:78)
androidx.compose.ui.node.LayoutNode.dispatchOnPositionedCallbacks$ui_release (LayoutNode.java:1100)
androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:72)
androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:76)
androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:76)
androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy (OnPositionedDispatcher.kt:76)
androidx.compose.ui.node.MeasureAndLayoutDelegate.<init> (MeasureAndLayoutDelegate.kt:63)
androidx.compose.ui.node.OnPositionedDispatcher.dispatch (OnPositionedDispatcher.java:63)
androidx.compose.ui.node.MeasureAndLayoutDelegate.dispatchOnPositionedCallbacks (MeasureAndLayoutDelegate.kt:653)
androidx.compose.ui.platform.AndroidComposeView.updatePositionCacheAndDispatch (AndroidComposeView.android.kt:1121)
androidx.compose.ui.platform.AndroidComposeView.onLayout (AndroidComposeView.android.kt:1095)
android.view.View.layout (View.java:25754)
android.view.ViewGroup.layout (ViewGroup.java:6831)
androidx.compose.ui.platform.AbstractComposeView.internalOnLayout$ui_release (ComposeView.android.kt:322)
androidx.compose.ui.platform.AbstractComposeView.onLayout (ComposeView.android.kt:313)
android.view.View.layout (View.java:25754)
android.view.ViewGroup.layout (ViewGroup.java:6831)
android.widget.FrameLayout.layoutChildren (FrameLayout.java:332)
android.widget.FrameLayout.onLayout (FrameLayout.java:270)
android.view.View.layout (View.java:25754)
android.view.ViewGroup.layout (ViewGroup.java:6831)
android.widget.LinearLayout.setChildFrame (LinearLayout.java:1891)
android.widget.LinearLayout.layoutVertical (LinearLayout.java:1729)
android.widget.LinearLayout.onLayout (LinearLayout.java:1638)
android.view.View.layout (View.java:25754)
android.view.ViewGroup.layout (ViewGroup.java:6831)
android.widget.FrameLayout.layoutChildren (FrameLayout.java:332)
android.widget.FrameLayout.onLayout (FrameLayout.java:270)
android.view.View.layout (View.java:25754)
android.view.ViewGroup.layout (ViewGroup.java:6831)
android.widget.LinearLayout.setChildFrame (LinearLayout.java:1891)
android.widget.LinearLayout.layoutVertical (LinearLayout.java:1729)
android.widget.LinearLayout.onLayout (LinearLayout.java:1638)
android.view.View.layout (View.java:25754)
android.view.ViewGroup.layout (ViewGroup.java:6831)
android.widget.FrameLayout.layoutChildren (FrameLayout.java:332)
android.widget.FrameLayout.onLayout (FrameLayout.java:270)
com.android.internal.policy.DecorView.onLayout (DecorView.java:1090)
android.view.View.layout (View.java:25754)
android.view.ViewGroup.layout (ViewGroup.java:6831)
android.view.ViewRootImpl.performLayout (ViewRootImpl.java:5236)
android.view.ViewRootImpl.performTraversals (ViewRootImpl.java:4502)
android.view.ViewRootImpl.doTraversal (ViewRootImpl.java:3275)
android.view.ViewRootImpl$TraversalRunnable.run (ViewRootImpl.java:11256)
android.view.Choreographer$CallbackRecord.run (Choreographer.java:1650)
android.view.Choreographer$CallbackRecord.run (Choreographer.java:1659)
android.view.Choreographer.doCallbacks (Choreographer.java:1129)
android.view.Choreographer.doFrame (Choreographer.java:1055)
android.view.Choreographer$FrameDisplayEventReceiver.run (Choreographer.java:1622)
android.os.Handler.handleCallback (Handler.java:958)
android.os.Handler.dispatchMessage (Handler.java:99)
android.os.Looper.loopOnce (Looper.java:230)
android.os.Looper.loop (Looper.java:319)
android.app.ActivityThread.main (ActivityThread.java:8913)
java.lang.reflect.Method.invoke (Method.java)
com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run (RuntimeInit.java:608)
com.android.internal.os.ZygoteInit.main (ZygoteInit.java:1103)
it...@gmail.com <it...@gmail.com> #23
I found a workaround fix. For me the bug was happening in this order:
- Open a activity with Input Field, user would enter something
- Then user would click to select image from gallery and once new activity was started app crashed.
What helped me is calling focusManager.clearFocus()
before navigating to image cropper.
pe...@meta.com <pe...@meta.com> #24
lo...@gmail.com <lo...@gmail.com> #25
ja...@gmail.com <ja...@gmail.com> #26
This is my app's biggest crash nowadays. 181x over 64 users in the last week, currently on Compose 2024.06.00.
No reproduction path yet, but one thing I noticed is that it happens as follows:
- User is on screen A
- User navigates to screen B (started with
startActivityForResult()
) or C (started from anActivityResultLauncher
) - User returns to screen A: crash
A is a fully Compose activity. B in my case is my own LoginActivity
(with XML layout). In this case, this screen automatically launches immediately upon going back to the app's stack with screen A open. Depending on how quick autofocus happens, the user might have focus in a text field.
C is a third-party CropImageActivity
(from CanHub, also XML layout). In this case, the user will have been on this screen for some time already (with focus on text, as that's the only way to start the cropper screen). Interestingly enough,
I've seen it happen myself a few times, but I couldn't reproduce it or pinpoint a reason. Since it gets triggered from if (state.hasFocus)
.. seems like it's a timing issue between cursorAnchorInfoController.invalidate()
(from updateState()
) and CoreTextField
's onGloballyPositioned
modifier calling TextFieldDelegate.updateTextLayoutResult
.
se...@google.com <se...@google.com> #27
Thank you for the debugging info!
se...@google.com <se...@google.com> #28
Also if anyone else reading this has more debugging info they can share, we're really scratching our heads on this one and any insights would be greatly appreciated!
se...@branch.co <se...@branch.co> #29
We do have an image cropping functionality that could be involved in the crash. Unfortunately we are stuck at BoM 2023.10.01 as newer versions of the BoM just cause a lot of the mentioned crashes. Because of that, and our crash logs retention period, I cannot confirm confirm if the image cropping functionality is indeed involved in the crash or not.
al...@gmail.com <al...@gmail.com> #30
I could reproduce the issue too. First of all I wrote a simplest app
class MainActivity : ComponentActivity() {
override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
setContent {
MyApplicationTheme {
Surface(modifier = Modifier.fillMaxSize()) {
Greeting(
name = "Android",
modifier = Modifier
)
}
}
}
}
}
@Composable
fun Greeting(name: String, modifier: Modifier = Modifier) {
val text = remember { mutableStateOf("") }
Column(modifier = modifier.fillMaxSize(), verticalArrangement = Arrangement.Center, horizontalAlignment = Alignment.CenterHorizontally) {
OutlinedTextField(value = text.value, onValueChange = { text.value = it })
Text(
text = "Hello $name!",
modifier = modifier
)
}
}
To reproduce the issue I do the following steps. I click on TextField, enter a couple of symbols and then I block the phone(with Power button) and unblock it again(with fingerprint). I repeat blocking and unblocking and earlier or later the NPE occurs. I tried to do that on two phones. Huawei P20 Pro and Xiaomi 13T Pro. The NPE occurs only on Xiaomi phone. On Huwei everything works well.
Maybe is there any workaround ?
se...@google.com <se...@google.com> #31
Thanks for the repro note!
ju...@google.com <ju...@google.com> #32
Alex, I have a few follow up questions about your reproduction steps.
- Could you let us know which keyboard and language you were using on the Xiaomi phone?
- Does the issue reproduce with a debug version of your test app (i.e. no
isMinifyEnabled
)? - The reproduction steps seem almost identical for this issue, and
. Is the only difference that the text field is non-empty to reproduce this stack trace, and empty to reproduce the stack trace inissue 343638941 ?issue 343638941
Thanks for your relp!
al...@gmail.com <al...@gmail.com> #33
I tested with debug build. isMinifyEnabled is false
I got the stack trace from this issue. Regardless of whether the text field is empty or non-empty
se...@branch.co <se...@branch.co> #34
Can someone confirm if this issue is still occurring in Compose BoM 2024.09.00+ (that provides Compose UI 1.7.0+)?
al...@airbnb.com <al...@airbnb.com> #35
With Compose UI 1.7.0 we're encountering this stack trace that was closed as a duplicate of this bug:
This is only happening on Android 14 devices.
java.lang.NullPointerException: Attempt to read from field 'float a3.d.ı' on a null object reference in method 'void y1.z.ı()'
at androidx.compose.foundation.text.input.internal.LegacyCursorAnchorInfoController.updateCursorAnchorInfo(LegacyCursorAnchorInfoController:141)
at androidx.compose.foundation.text.input.internal.LegacyCursorAnchorInfoController.updateTextLayoutResult(LegacyCursorAnchorInfoController:115)
at androidx.compose.foundation.text.input.internal.LegacyTextInputMethodRequest.updateTextLayoutResult(LegacyTextInputMethodRequest:403)
at androidx.compose.foundation.text.input.internal.AndroidLegacyPlatformTextInputServiceAdapter.updateTextLayoutResult(AndroidLegacyPlatformTextInputServiceAdapter:180)
at androidx.compose.ui.text.input.TextInputSession.updateTextLayoutResult(TextInputSession:224)
at androidx.compose.foundation.text.TextFieldDelegate$Companion.updateTextLayoutResult$foundation_release(TextFieldDelegate:252)
at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1$1.invoke(CoreTextFieldKt:449)
at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1$1.invoke(CoreTextFieldKt:426)
at androidx.compose.ui.layout.OnGloballyPositionedNode.onGloballyPositioned(OnGloballyPositionedNode:78)
at androidx.compose.ui.node.LayoutNode.dispatchOnPositionedCallbacks$ui_release(LayoutNode:1176)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:76)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher:80)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatch(OnPositionedDispatcher:67)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.dispatchOnPositionedCallbacks(MeasureAndLayoutDelegate:715)
at androidx.compose.ui.platform.AndroidComposeView.updatePositionCacheAndDispatch(AndroidComposeView:1432)
at androidx.compose.ui.platform.AndroidComposeView.onLayout(AndroidComposeView:1406)
at android.view.View.layout(View.java:25310)
at android.view.ViewGroup.layout(ViewGroup.java:6515)
at androidx.compose.ui.platform.AbstractComposeView.internalOnLayout$ui_release(AbstractComposeView:329)
at androidx.compose.ui.platform.AbstractComposeView.internalOnLayout$ui_release(AbstractComposeView:27)
at androidx.compose.ui.platform.AbstractComposeView.onLayout(AbstractComposeView:320)
at android.view.View.layout(View.java:25310)
at android.view.ViewGroup.layout(ViewGroup.java:6515)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
at android.view.View.layout(View.java:25310)
at android.view.ViewGroup.layout(ViewGroup.java:6515)
at android.widget.LinearLayout.setChildFrame(LinearLayout.java:1891)
at android.widget.LinearLayout.layoutVertical(LinearLayout.java:1729)
at android.widget.LinearLayout.onLayout(LinearLayout.java:1638)
at android.view.View.layout(View.java:25310)
at android.view.ViewGroup.layout(ViewGroup.java:6515)
at android.widget.FrameLayout.layoutChildren(FrameLayout.java:332)
at android.widget.FrameLayout.onLayout(FrameLayout.java:270)
at com.android.internal.policy.DecorView.onLayout(DecorView.java:876)
at android.view.View.layout(View.java:25310)
at android.view.ViewGroup.layout(ViewGroup.java:6515)
at android.view.ViewRootImpl.performLayout(ViewRootImpl.java:4867)
at android.view.ViewRootImpl.performTraversals(ViewRootImpl.java:4176)
at android.view.ViewRootImpl.doTraversal(ViewRootImpl.java:2995)
at android.view.ViewRootImpl$TraversalRunnable.run(ViewRootImpl.java:10331)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1594)
at android.view.Choreographer$CallbackRecord.run(Choreographer.java:1603)
at android.view.Choreographer.doCallbacks(Choreographer.java:1125)
at android.view.Choreographer.doFrame(Choreographer.java:1030)
at android.view.Choreographer$FrameDisplayEventReceiver.run(Choreographer.java:1567)
at android.os.Handler.handleCallback(Handler.java:958)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loopOnce(Looper.java:224)
at android.os.Looper.loop(Looper.java:318)
at android.app.ActivityThread.main(ActivityThread.java:8763)
at java.lang.reflect.Method.invoke(Method.java:-2)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:561)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1013)
ja...@gmail.com <ja...@gmail.com> #36
Can someone confirm if this issue is still occurring in Compose BoM 2024.09.00+ (that provides Compose UI 1.7.0+)?
Can confirm this issue still occurs on Compose BoM 2024.09.02 (with Compose Foundation 1.7.2).
java.lang.NullPointerException
at androidx.compose.foundation.text.input.internal.LegacyCursorAnchorInfoController.updateCursorAnchorInfo(LegacyCursorAnchorInfoController.android.kt:141)
at androidx.compose.foundation.text.input.internal.LegacyCursorAnchorInfoController.updateTextLayoutResult(LegacyCursorAnchorInfoController.android.kt:115)
at androidx.compose.foundation.text.input.internal.LegacyTextInputMethodRequest.updateTextLayoutResult(LegacyPlatformTextInputServiceAdapter.android.kt:403)
at androidx.compose.foundation.text.input.internal.AndroidLegacyPlatformTextInputServiceAdapter.updateTextLayoutResult(LegacyPlatformTextInputServiceAdapter.android.kt:180)
at androidx.compose.ui.text.input.TextInputSession.updateTextLayoutResult(TextInputService.kt:224)
at androidx.compose.foundation.text.TextFieldDelegate$Companion.updateTextLayoutResult$foundation_release(TextFieldDelegate.kt:252)
at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1$1.invoke(CoreTextField.kt:449)
at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1$1.invoke(CoreTextField.kt:426)
at androidx.compose.ui.layout.OnGloballyPositionedNode.onGloballyPositioned(OnGloballyPositionedModifier.kt:78)
at androidx.compose.ui.node.LayoutNode.dispatchOnPositionedCallbacks$ui_release(LayoutNode.kt:1177)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher.kt:76)
so...@google.com <so...@google.com> #37
Triage: Hey Justin, looks like you've got a response to your latest comment, could you have another look please? Is P1 is still a valid priority?
ap...@google.com <ap...@google.com> #38
Project: platform/frameworks/support
Branch: androidx-main
Author: Justin Ghan <
Link:
Prevent NPE in LegacyCursorAnchorInfoController
Expand for full commit details
Prevent NPE in LegacyCursorAnchorInfoController
I haven't been able to reproduce the NPE or figure out how it might
happen, but this change should prevent the NPE and the only impact would
be potential missed CursorAnchorInfo updates to the IME (instead of
crashing).
Bug: 313010266
Test: None
Change-Id: I475c69d27d3a15ba36c13b47695086a4ec5841f2
Files:
- M
compose/foundation/foundation/src/androidMain/kotlin/androidx/compose/foundation/text/input/internal/LegacyCursorAnchorInfoController.android.kt
Hash: 0ab8f699522c4f60b091b6416ffd28b51aba6aa9
Date: Mon Sep 30 17:11:13 2024
ro...@reddit.com <ro...@reddit.com> #39
ju...@google.com <ju...@google.com> #40
We were unable to reproduce the crash or figure out how it occurs, but we have implemented a preventative fix which will be in the upcoming 1.7.4 release.
na...@google.com <na...@google.com> #41
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.foundation:foundation:1.7.4
androidx.compose.foundation:foundation-android:1.7.4
androidx.compose.foundation:foundation-jvmstubs:1.7.4
androidx.compose.foundation:foundation-linuxx64stubs:1.7.4
androidx.compose.foundation:foundation:1.8.0-alpha04
androidx.compose.foundation:foundation-android:1.8.0-alpha04
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha04
ib...@gmail.com <ib...@gmail.com> #42
ju...@google.com <ju...@google.com> #43
Could you double check the compose version? The line numbers should have changed after the fix, so I wouldn't expect the NullPointerException to still occur on line 141 of LegacyCursorAnchorInfoController.android.kt.
ma...@gmail.com <ma...@gmail.com> #44
ma...@thebrowser.company <ma...@thebrowser.company> #45
The current trace now in 1.8.0-alpha02
:
Exception java.lang.NullPointerException:
at androidx.compose.foundation.text.input.internal.LegacyCursorAnchorInfoController.updateCursorAnchorInfo (LegacyCursorAnchorInfoController.android.kt:144)
at androidx.compose.foundation.text.input.internal.LegacyCursorAnchorInfoController.updateTextLayoutResult (LegacyCursorAnchorInfoController.java:117)
at androidx.compose.foundation.text.input.internal.LegacyTextInputMethodRequest.updateTextLayoutResult (LegacyTextInputMethodRequest.java:411)
at androidx.compose.foundation.text.input.internal.AndroidLegacyPlatformTextInputServiceAdapter.updateTextLayoutResult (LegacyPlatformTextInputServiceAdapter.android.kt:184)
ib...@gmail.com <ib...@gmail.com> #46
I've updated Compose to 1.8.0-alpha07
, and I can see a null return in the updateCursorAnchorInfo
. However, the crashes are still being reported.
Based on the events, I can tell this happens during a hot start about 98% of the time. The last recorded event is firebase_screen_class: AdActivity.
- Android 14 = 100%
- Samsung = 90-95%
Fatal Exception: java.lang.NullPointerException:
at androidx.compose.foundation.text.input.internal.LegacyCursorAnchorInfoController.updateCursorAnchorInfo(LegacyCursorAnchorInfoController.android.kt:141)
at androidx.compose.foundation.text.input.internal.LegacyCursorAnchorInfoController.updateTextLayoutResult(LegacyCursorAnchorInfoController.java:115)
at androidx.compose.foundation.text.input.internal.LegacyTextInputMethodRequest.updateTextLayoutResult(LegacyTextInputMethodRequest.java:403)
at androidx.compose.foundation.text.input.internal.AndroidLegacyPlatformTextInputServiceAdapter.updateTextLayoutResult(LegacyPlatformTextInputServiceAdapter.android.kt:180)
at androidx.compose.ui.text.input.TextInputSession.updateTextLayoutResult(TextInputSession.java:220)
at androidx.compose.foundation.text.TextFieldDelegate$Companion.updateTextLayoutResult$foundation_release(TextFieldDelegate.java:252)
at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1$1.invoke(CoreTextField.kt:449)
at androidx.compose.foundation.text.CoreTextFieldKt$CoreTextField$onPositionedModifier$1$1.invoke(CoreTextField.kt:426)
at androidx.compose.ui.layout.OnGloballyPositionedNode.onGloballyPositioned(OnGloballyPositionedModifier.kt:75)
at androidx.compose.ui.node.LayoutNode.dispatchOnPositionedCallbacks$ui_release(LayoutNode.java:1102)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher.kt:76)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher.kt:79)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatchHierarchy(OnPositionedDispatcher.kt:79)
at androidx.compose.ui.node.OnPositionedDispatcher.dispatch(OnPositionedDispatcher.kt:67)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.dispatchOnPositionedCallbacks(MeasureAndLayoutDelegate.kt:723)
at androidx.compose.ui.node.MeasureAndLayoutDelegate.dispatchOnPositionedCallbacks$default(MeasureAndLayoutDelegate.kt:719)
at androidx.compose.ui.platform.AndroidComposeView.measureAndLayout(AndroidComposeView.android.kt:1352)
at androidx.compose.ui.node.Owner.measureAndLayout$default(Owner.java:236)
at androidx.compose.ui.platform.AndroidComposeView.dispatchDraw(AndroidComposeView.android.kt:1680)
at android.view.View.draw(View.java:25180)
...
ib...@gmail.com <ib...@gmail.com>
ju...@google.com <ju...@google.com> #47
The line numbers in the stack traces in 1.8.0-alpha04
or later.
Description
Reported in Crashlytics, 9 crashes from 8 users (install base 80k for this version). Only Android 14, so far, but I was not able to reproduce it.
Stack trace