Fixed
Status Update
No update yet.
Comments
cc...@google.com
The alignment issue would make this clearer, tracked here:
Leaving this separate as the suggestion to be locale independent is a good one
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit cda7b86714d8bd3a3dca6277538ae118c79690fe
Author: Chris Craik <ccraik@google.com>
Date: Fri Mar 15 16:26:44 2024
Standardize to comma thousands separators
Fixes: 313496656
Test: Manual (ran benchmark with German as system language)
Relnote: "Force ',' thousands separators for consistency in Studio
output, ignoring device locale"
Change-Id: I3e92172b3b507068eac6154bd1f8fa02d3236197
M benchmark/benchmark-common/src/main/java/androidx/benchmark/InstrumentationResults.kt
https://android-review.googlesource.com/3006043
Branch: androidx-main
commit cda7b86714d8bd3a3dca6277538ae118c79690fe
Author: Chris Craik <ccraik@google.com>
Date: Fri Mar 15 16:26:44 2024
Standardize to comma thousands separators
Fixes: 313496656
Test: Manual (ran benchmark with German as system language)
Relnote: "Force ',' thousands separators for consistency in Studio
output, ignoring device locale"
Change-Id: I3e92172b3b507068eac6154bd1f8fa02d3236197
M benchmark/benchmark-common/src/main/java/androidx/benchmark/InstrumentationResults.kt
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.benchmark:benchmark-common:1.3.0-alpha03
Description
Component used: androidx.benchmark
Version used: 1.2.1
Devices/Android versions reproduced on: Pixel 4 / Android 13
I ran the same benchmark code on my Pixel 4 in Spanish and emulator in English, from Android Studio in English.
Got the benchmark result shown up in Android Studio, and found the thousands separator of the numbers in the result from Pixel 4 is dot (as in Spanish, instead of comma in English, see screenshots attached).
It confused me very much as I couldn't tell the exact number. Can we make the result text locale independent of the benchmark device being used?