BaselineProfileProducerPlugin.kt gives a misleading error about inability to determine the test task [313803289]

Fixed

Bug

Status Update

No update yet.

Description

ma...@textnow.com

created issue #1

Nov 29, 2023 05:38PM

DESCRIBE THE ISSUE IN DETAIL:

STEPS TO REPRODUCE:
1. Use the IDE to auto-generate a baseline profile module
2. Change _ONE_ of the two device references from pixel6 to pixel8, but not both (ie: we would expect an error message, but not this error message)
3. run `./gradlew tasks` and notice that it says it can not determine the test task. This leads devs down a rabbit hole trying to solve the wrong thing. Ideally, it would tell them there is a device mismatch.

Issue is coming from: BaselineProfileProducerPlugin.kt#createTasksForVariant

(I was not able to place this ticket in the correct component)

```
* What went wrong:
A problem occurred configuring project ':baselineprofile'.
> com.android.build.gradle.internal.crash.ExternalApiUsageException: org.gradle.api.GradleException: It wasn't possible to determine the test task for managed device `pixel8Api34`.
Please check the managed devices specified in the baseline profile
configuration.
```

Studio Build: Iguana 2023.2.1 Canary 15
Version of Gradle Plugin: 8.2.0-rc03
Version of Gradle: 8.3-rc-2-all
Version of Java: 17
OS: Ubuntu 22.04.3 LTS x86_64

Comments

ja...@google.com <ja...@google.com> #2Nov 30, 2023 05:51AM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ma...@textnow.com <ma...@textnow.com> #3Nov 30, 2023 02:59PM

Thank you for the reply. I do not think the component is correct, but I did not have permission to put it anywhere else.

This was reproducible under Android Studio, local CLI, and GHA.

The stack trace above is what is output from all 3 scenarios.
The issue is when the `baselineProfile|managedDevices` does not align with `android|testOptions|managedDevices|devices`, then it tells you it can't find the test. The actual issue is that it can't find the device specification.
In BaselineProfileProducerPlugin.kt, the error handling treats all exceptions with the same test error message.

Hope that helps.

rk...@google.com <rk...@google.com> Dec 7, 2023 07:30PM

Assigned to an...@google.com.

je...@google.com <je...@google.com> Dec 12, 2023 05:24AM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> #4Dec 12, 2023 10:31PM

As you mention in comment#3, baselineProfile.managedDevices needs to specify which GMD to use. GMDs are created in android.testOptions.managedDevices.devices.

When selecting a managedDevices that does not exist in baselineProfile.managedDevices, the error thrown is about the task not found.

I'll improve the error message there but there are some reason for which we cannot change this behavior. Thanks for reporting this.

Message last modified on Dec 12, 2023 11:01PM

ap...@google.com <ap...@google.com> #5Jan 5, 2024 09:17PM

Project: platform/frameworks/support
Branch: androidx-main

commit aeb2a56a1262140c803f87865cbb84551128a462
Author: Marcello Albano <maralb@google.com>
Date: Thu Dec 21 12:40:35 2023

Improved error message when specified managed device does not exist

Bug: 313803289
Test: n/a
Change-Id: Idea2b6d830807f215a576192bbbf844659a97c58
Relnote: Improved error message in baseline profile gradle plugin when specified managed device does not exist

M benchmark/baseline-profile-gradle-plugin/src/main/kotlin/androidx/baselineprofile/gradle/producer/BaselineProfileProducerPlugin.kt
M benchmark/baseline-profile-gradle-plugin/src/test/kotlin/androidx/baselineprofile/gradle/producer/BaselineProfileProducerPluginTest.kt

https://android-review.googlesource.com/2889227

ma...@google.com <ma...@google.com> Jan 5, 2024 11:28PM

Marked as fixed.

pr...@google.com <pr...@google.com> #6Feb 21, 2024 07:32PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.benchmark:benchmark-baseline-profile-gradle-plugin:1.3.0-alpha01