Fixed
Status Update
No update yet.
Comments
al...@google.com
al...@google.com
al...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 8d1b84a6aabbb17cfd026e9626c612bf64a49709
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Mar 25 15:41:47 2022
Call Processor.startWork() in `DelayMetCommandHandler` from serial executor
After this CL `Processor.startWork()` is always called from serial executor,
so there is now a guarantee for other work in the serial executor, that now new
work will be started in parallel. This is important for work updating feature because
we want to guarantee that if update was successful, then next worker execution will have
updated spec.
bug: 219446409
Test: ./gradlew :work:work-runtime:cC
Change-Id: Ic9ff9e0fdcc6524b12b3761b9976f328e834e95a
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
https://android-review.googlesource.com/2042710
Branch: androidx-main
commit 8d1b84a6aabbb17cfd026e9626c612bf64a49709
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Mar 25 15:41:47 2022
Call Processor.startWork() in `DelayMetCommandHandler` from serial executor
After this CL `Processor.startWork()` is always called from serial executor,
so there is now a guarantee for other work in the serial executor, that now new
work will be started in parallel. This is important for work updating feature because
we want to guarantee that if update was successful, then next worker execution will have
updated spec.
bug: 219446409
Test: ./gradlew :work:work-runtime:cC
Change-Id: Ic9ff9e0fdcc6524b12b3761b9976f328e834e95a
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
al...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 327311c283773ad6c7e3d0fdff05136df925f8ad
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 23:45:01 2022
Migrate enums to Kotlin
bug: 219446409
Test: NA
Change-Id: I6331453c65b372309ab2c7af17efa649c8feeb54
M work/work-runtime/src/main/java/androidx/work/ExistingWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/OutOfQuotaPolicy.kt
M work/work-runtime/src/main/java/androidx/work/NetworkType.kt
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/BackoffPolicy.kt
https://android-review.googlesource.com/2052912
Branch: androidx-main
commit 327311c283773ad6c7e3d0fdff05136df925f8ad
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 23:45:01 2022
Migrate enums to Kotlin
bug: 219446409
Test: NA
Change-Id: I6331453c65b372309ab2c7af17efa649c8feeb54
M work/work-runtime/src/main/java/androidx/work/ExistingWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/OutOfQuotaPolicy.kt
M work/work-runtime/src/main/java/androidx/work/NetworkType.kt
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/BackoffPolicy.kt
al...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 12a144ae86997cb6a69545b1dd8f1cc559220772
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 23:38:59 2022
Move enum file from *.java -> *.kt
bug: 219446409
Test: NA
Change-Id: I0ce0df156dbc1c2820b62215fbfb0c0b07add20a
M work/work-runtime/src/main/java/androidx/work/ExistingWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/OutOfQuotaPolicy.kt
M work/work-runtime/src/main/java/androidx/work/NetworkType.kt
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/BackoffPolicy.kt
https://android-review.googlesource.com/2052911
Branch: androidx-main
commit 12a144ae86997cb6a69545b1dd8f1cc559220772
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 23:38:59 2022
Move enum file from *.java -> *.kt
bug: 219446409
Test: NA
Change-Id: I0ce0df156dbc1c2820b62215fbfb0c0b07add20a
M work/work-runtime/src/main/java/androidx/work/ExistingWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/OutOfQuotaPolicy.kt
M work/work-runtime/src/main/java/androidx/work/NetworkType.kt
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/BackoffPolicy.kt
al...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 9d5b985fd5b1e65c2e0f2593d10eb956f1c80580
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 17:43:51 2022
Restrict schedulers to cancel only their own work.
Previously schedulers were able to cancel a work that
they haven't started. E.g. `CommandHandler` on cancel
signal were calling "stopWork(workId)" unconditionally,
no matter if it actually started that work or not
bug: 219446409
Test: refactoring
Change-Id: Ia48e3239c3302d7b6ff1114c3baa52a62a40ee32
M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
A work/work-runtime/src/main/java/androidx/work/impl/WorkRunId.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/StartWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
https://android-review.googlesource.com/2052907
Branch: androidx-main
commit 9d5b985fd5b1e65c2e0f2593d10eb956f1c80580
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Apr 01 17:43:51 2022
Restrict schedulers to cancel only their own work.
Previously schedulers were able to cancel a work that
they haven't started. E.g. `CommandHandler` on cancel
signal were calling "stopWork(workId)" unconditionally,
no matter if it actually started that work or not
bug: 219446409
Test: refactoring
Change-Id: Ia48e3239c3302d7b6ff1114c3baa52a62a40ee32
M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
A work/work-runtime/src/main/java/androidx/work/impl/WorkRunId.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/StartWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
se...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit c8f83d8b1fe59a51ab60124c1604b7f9b83bac78
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Apr 07 19:13:33 2022
Improve implementation note on WorkRunId
bug: 219446409
Test: NA
Change-Id: If923e68aefba620c97a1e9373351e67d813df765
M work/work-runtime/src/main/java/androidx/work/impl/WorkRunId.kt
https://android-review.googlesource.com/2057643
Branch: androidx-main
commit c8f83d8b1fe59a51ab60124c1604b7f9b83bac78
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Apr 07 19:13:33 2022
Improve implementation note on WorkRunId
bug: 219446409
Test: NA
Change-Id: If923e68aefba620c97a1e9373351e67d813df765
M work/work-runtime/src/main/java/androidx/work/impl/WorkRunId.kt
as...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b1e1b4714f013edda06df4b0c92d18c28e5b958d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed May 25 11:51:51 2022
Use WorkSpec in ConstraintsTracker
Going forward generation will be added to WorkSpec,
so it is important to know constraints for which
workspec exactly were met.
bug: 219446409
Test: Refactoring
Change-Id: I9beb5bc1a0345380daaf4fa2c1974eab213c9577
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.kt
https://android-review.googlesource.com/2115798
Branch: androidx-main
commit b1e1b4714f013edda06df4b0c92d18c28e5b958d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed May 25 11:51:51 2022
Use WorkSpec in ConstraintsTracker
Going forward generation will be added to WorkSpec,
so it is important to know constraints for which
workspec exactly were met.
bug: 219446409
Test: Refactoring
Change-Id: I9beb5bc1a0345380daaf4fa2c1974eab213c9577
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/controllers/ConstraintControllerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsCallback.kt
M work/work-runtime/src/main/java/androidx/work/impl/constraints/controllers/ConstraintController.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/constraints/WorkConstraintsTracker.kt
M work/work-runtime/src/main/java/androidx/work/impl/workers/ConstraintTrackingWorker.kt
al...@google.com
bu...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit a7d319b96a0622fcc9219ad4b156e4fafa215fa5
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 13 17:02:04 2022
Rename `WorkRunId` to `StartStopToken`
bug: 219446409
Test: refacting
Change-Id: I312ad14013d9931ec485fbccee27048ad697479c
M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/StartStopToken.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/StartWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
https://android-review.googlesource.com/2123382
Branch: androidx-main
commit a7d319b96a0622fcc9219ad4b156e4fafa215fa5
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 13 17:02:04 2022
Rename `WorkRunId` to `StartStopToken`
bug: 219446409
Test: refacting
Change-Id: I312ad14013d9931ec485fbccee27048ad697479c
M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/StartStopToken.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/StartWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
bu...@google.com
al...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 1430b5a035fb33c4464e24396c547cf1efa9bbb3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 13 15:03:55 2022
Read WorkSpec in advance in Processor
It is important for updates of periodic workers,
because in case of periodic workers workspec could be
updated during the run of the worker. So Worker should
have all required information at the moment of the start
in order to stay consistent.
bug: 219446409
Test: refactoring
Change-Id: I6a29381b20919cda88461c2960b74dd0b7107a26
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt
https://android-review.googlesource.com/2123378
Branch: androidx-main
commit 1430b5a035fb33c4464e24396c547cf1efa9bbb3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 13 15:03:55 2022
Read WorkSpec in advance in Processor
It is important for updates of periodic workers,
because in case of periodic workers workspec could be
updated during the run of the worker. So Worker should
have all required information at the moment of the start
in order to stay consistent.
bug: 219446409
Test: refactoring
Change-Id: I6a29381b20919cda88461c2960b74dd0b7107a26
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt
bu...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 66fe06e58187191981ba3f17c8ac8e015a2aae26
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 06 14:37:30 2022
Introduce generation in WorkSpec
This was done in a preparation for updates of
WorkSpecs. It is important for a Worker to know
for which generation it was started:
otherwise it can lead to inconsistent runs,
e.g. old constraints were met and started a new
Worker.
bug: 219446409
Test: ProcessorTests
Change-Id: I2bf26fd7b0d368943a5d119a4183bbaf7a27ae64
M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
A work/work-runtime/src/schemas/androidx.work.impl.WorkDatabase/16.json
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/ForceStopRunnableTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemjob/SystemJobServiceTest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/WorkTimer.java
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-gcm/src/androidTest/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/ExecutionListener.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/WorkForegroundUpdater.java
M work/work-runtime/src/main/java/androidx/work/impl/StartStopToken.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobInfoConverter.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/GcmTaskConverter.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/workers/DiagnosticsWorker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/AlarmsTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/Alarms.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/WorkTimerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplLargeExecutorTest.java
https://android-review.googlesource.com/2115799
Branch: androidx-main
commit 66fe06e58187191981ba3f17c8ac8e015a2aae26
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 06 14:37:30 2022
Introduce generation in WorkSpec
This was done in a preparation for updates of
WorkSpecs. It is important for a Worker to know
for which generation it was started:
otherwise it can lead to inconsistent runs,
e.g. old constraints were met and started a new
Worker.
bug: 219446409
Test: ProcessorTests
Change-Id: I2bf26fd7b0d368943a5d119a4183bbaf7a27ae64
M work/work-runtime/src/main/java/androidx/work/impl/utils/StopWorkRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcher.java
A work/work-runtime/src/schemas/androidx.work.impl.WorkDatabase/16.json
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobScheduler.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkDatabase.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfoDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/ConstraintsCommandHandler.java
M work/work-testing/src/main/java/androidx/work/testing/TestScheduler.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/utils/ForceStopRunnableTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/SystemAlarmDispatcherTest.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemjob/SystemJobServiceTest.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/WorkTimer.java
M work/work-runtime/src/main/java/androidx/work/impl/model/SystemIdInfo.kt
M work/work-gcm/src/androidTest/java/androidx/work/impl/background/gcm/WorkManagerGcmDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/background/greedy/GreedyScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTests.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/DelayMetCommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/ExecutionListener.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobService.java
M work/work-runtime/src/main/java/androidx/work/impl/utils/WorkForegroundUpdater.java
M work/work-runtime/src/main/java/androidx/work/impl/StartStopToken.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/CommandHandler.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemjob/SystemJobInfoConverter.java
M work/work-gcm/src/main/java/androidx/work/impl/background/gcm/GcmTaskConverter.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/greedy/GreedySchedulerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/workers/DiagnosticsWorker.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/ProcessorTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/AlarmsTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/Alarms.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/background/systemalarm/WorkTimerTest.java
M work/work-runtime/src/main/java/androidx/work/impl/background/systemalarm/SystemAlarmScheduler.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplLargeExecutorTest.java
bu...@google.com
al...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit e5de8cabaccc7a7ee8aaee8e6cb3e85da3be3212
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Mar 31 16:52:26 2022
Initial commit for update work feature
Current implementation only updates `OneTimeWorkRequest`-s
Relnote: "`WorkManager.updateWork` was added to update work
preserving its original enqueue time and chaining.
Currently it supports only OneTimeWorkRequests."
bug: 219446409
Test: WorkUpdateTest
Change-Id: I9a2489e50d217cf70377d348b183ceb2d777506d
A work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkManager.java
M work/work-runtime/api/current.txt
A work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/api/restricted_current.ignore
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/api/current.ignore
A work/work-runtime/src/androidTest/java/androidx/work/impl/testutils/TestConstraints.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.kt
https://android-review.googlesource.com/2051581
Branch: androidx-main
commit e5de8cabaccc7a7ee8aaee8e6cb3e85da3be3212
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Mar 31 16:52:26 2022
Initial commit for update work feature
Current implementation only updates `OneTimeWorkRequest`-s
Relnote: "`WorkManager.updateWork` was added to update work
preserving its original enqueue time and chaining.
Currently it supports only OneTimeWorkRequests."
bug: 219446409
Test: WorkUpdateTest
Change-Id: I9a2489e50d217cf70377d348b183ceb2d777506d
A work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkManager.java
M work/work-runtime/api/current.txt
A work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/constraints/WorkConstraintsTrackerTest.kt
M work/work-runtime/api/restricted_current.ignore
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/api/current.ignore
A work/work-runtime/src/androidTest/java/androidx/work/impl/testutils/TestConstraints.kt
M work/work-runtime/src/main/java/androidx/work/WorkRequest.kt
bu...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 75331425fcf02b5fb681a796a369a11325a86154
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 27 23:56:01 2022
Use correct WorkSpec in SystemForegroundDispatcher
Database can potentially have newer version of worker,
so we should rely on the spec of running worker instead.
Test: SystemForegroundDispatcherTest
bug: 219446409
Change-Id: I6144f1e604996407d51a92c1fb7e9a6c64577a92
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
https://android-review.googlesource.com/2137872
Branch: androidx-main
commit 75331425fcf02b5fb681a796a369a11325a86154
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jun 27 23:56:01 2022
Use correct WorkSpec in SystemForegroundDispatcher
Database can potentially have newer version of worker,
so we should rely on the spec of running worker instead.
Test: SystemForegroundDispatcherTest
bug: 219446409
Change-Id: I6144f1e604996407d51a92c1fb7e9a6c64577a92
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/SystemForegroundDispatcherTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/foreground/SystemForegroundDispatcher.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
bu...@google.com
al...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit bc2bc2a8efff9d46a2a070c4b11067b46a24279b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Jun 29 12:11:20 2022
Read tags along with WorkSpec in Processor
Otherwise due to the race, tags can be inconsistent
with the rest of properties of worker.
Test: WorkUpdateTest
bug: 219446409
Change-Id: Ieca7c5e1650a5ca16c643ca0b800a7ad2c984951
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt
https://android-review.googlesource.com/2139532
Branch: androidx-main
commit bc2bc2a8efff9d46a2a070c4b11067b46a24279b
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Wed Jun 29 12:11:20 2022
Read tags along with WorkSpec in Processor
Otherwise due to the race, tags can be inconsistent
with the rest of properties of worker.
Test: WorkUpdateTest
bug: 219446409
Change-Id: Ieca7c5e1650a5ca16c643ca0b800a7ad2c984951
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkContinuationImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/ControlledWorkerWrapperTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/foreground/WorkerWrapperForegroundTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime/src/main/java/androidx/work/impl/Processor.java
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteCoroutineWorkerTest.kt
al...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit b75f2a988f93a687bd95c87ebdb6ec1d486c4f3c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Jul 07 16:39:25 2022
Preserve lastEnqueueTime during the update
Test: WorkUpdateTest
bug: 219446409
Change-Id: Ifdc6a4c105ee2c53b2538265f933fd02634e85c5
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
https://android-review.googlesource.com/2148159
Branch: androidx-main
commit b75f2a988f93a687bd95c87ebdb6ec1d486c4f3c
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Jul 07 16:39:25 2022
Preserve lastEnqueueTime during the update
Test: WorkUpdateTest
bug: 219446409
Change-Id: Ifdc6a4c105ee2c53b2538265f933fd02634e85c5
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3258084eefb45350a75e43d86798f2e757ba49a3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jul 11 17:26:07 2022
Use ConstraintTrackingWorker in WorkManager.update
Test: WorkUpdateTest
bug: 219446409
Change-Id: Icbb073c77b5f529cb599d11ad74f4f8899eddbb4
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
A work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueUtils.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
https://android-review.googlesource.com/2149993
Branch: androidx-main
commit 3258084eefb45350a75e43d86798f2e757ba49a3
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Jul 11 17:26:07 2022
Use ConstraintTrackingWorker in WorkManager.update
Test: WorkUpdateTest
bug: 219446409
Change-Id: Icbb073c77b5f529cb599d11ad74f4f8899eddbb4
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
A work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueUtils.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 4110a2f8612edcd105a72640d43b9c9ae00e727d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Jul 08 15:52:39 2022
Introduce ExistingPeriodicWorkPolicy.Update
It is very similar to previously existing
ExistingPeriodicWorkPolicy.REPLACE.
Test: WorkManagerImplTest + integration test-app
Relnote: "`ExistingPeriodicWorkPolicy.UPDATE` was
added. This policy allows to update a periodic work
by the name. It is similar existing `REPLACE`, but
is less intrusive: it doesn't cancel a worker if it
is currently running, it preserves enqueue time, so
initial delay and period are calculated from original
enqueue time, rather than update time. `REPLACE` was
deprecated to decrease a confusion between very similarly
named `REPLACE`and `UPDATE`. If you still want to keep
previous semantics of `REPLACE`,
newly added `CANCEL_AND_REENQUEUE` identical to `REPLACE`
can be used."
bug: 219446409
Change-Id: I985edc2cf7ac7c316932185f3fd0a3ca6660f2dc
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerImpl.java
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerClient.java
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/aidl/androidx/work/multiprocess/IWorkManagerImpl.aidl
M work/work-runtime/api/current.txt
M work/integration-tests/testapp/src/main/res/layout/activity_main.xml
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/api/restricted_current.txt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RemoteService.kt
M work/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml
https://android-review.googlesource.com/2149093
Branch: androidx-main
commit 4110a2f8612edcd105a72640d43b9c9ae00e727d
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Fri Jul 08 15:52:39 2022
Introduce ExistingPeriodicWorkPolicy.Update
It is very similar to previously existing
ExistingPeriodicWorkPolicy.REPLACE.
Test: WorkManagerImplTest + integration test-app
Relnote: "`ExistingPeriodicWorkPolicy.UPDATE` was
added. This policy allows to update a periodic work
by the name. It is similar existing `REPLACE`, but
is less intrusive: it doesn't cancel a worker if it
is currently running, it preserves enqueue time, so
initial delay and period are calculated from original
enqueue time, rather than update time. `REPLACE` was
deprecated to decrease a confusion between very similarly
named `REPLACE`and `UPDATE`. If you still want to keep
previous semantics of `REPLACE`,
newly added `CANCEL_AND_REENQUEUE` identical to `REPLACE`
can be used."
bug: 219446409
Change-Id: I985edc2cf7ac7c316932185f3fd0a3ca6660f2dc
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerImpl.java
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/RemoteWorkManagerClient.java
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/aidl/androidx/work/multiprocess/IWorkManagerImpl.aidl
M work/work-runtime/api/current.txt
M work/integration-tests/testapp/src/main/res/layout/activity_main.xml
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkTagDao.kt
M work/work-runtime/api/restricted_current.txt
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/MainActivity.java
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/main/java/androidx/work/impl/WorkManagerImpl.java
M work/work-runtime/src/main/java/androidx/work/ExistingPeriodicWorkPolicy.kt
M work/work-runtime/src/main/java/androidx/work/impl/utils/EnqueueRunnable.java
M work/integration-tests/testapp/src/main/java/androidx/work/integration/testapp/RemoteService.kt
M work/integration-tests/testapp/src/main/res/values/donottranslate-strings.xml
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 8e22db3e7a62008ab0c4c07ac3f682e0c1cc4dbf
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Aug 08 15:39:16 2022
Add WorkerParameters.getGeneration
Relnote: """
`WorkerParameters.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
This worker can possibly be of an older generation rather than latest known,
if an update has happened while this worker is running."""
bug: 219446409
Test: WorkUpdateTest#updateWorkerParameterGeneration
Change-Id: I128a9838067f3a1722a9460f52ef58fb0f98136c
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkerParameters.java
M work/work-rxjava2/src/test/java/androidx/work/RxWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxForegroundInfoTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxWorkerTest.kt
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/SetCompletableProgressTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime-ktx/src/androidTest/java/androidx/work/CoroutineWorkerTest.kt
M work/work-testing/src/main/java/androidx/work/testing/TestListenableWorkerBuilder.java
M work/work-runtime/api/current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-rxjava2/src/test/java/androidx/work/RxForegroundInfoTest.kt
M work/work-runtime/api/restricted_current.txt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/DefaultWorkerFactoryTest.java
M work/work-runtime/src/androidTest/java/androidx/work/DelegatingWorkerFactoryTest.kt
M work/work-rxjava2/src/test/java/androidx/work/SetCompletableProgressTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkForegroundRunnableTest.kt
M work/work-runtime/src/main/java/androidx/work/WorkerParameters.java
https://android-review.googlesource.com/2177783
Branch: androidx-main
commit 8e22db3e7a62008ab0c4c07ac3f682e0c1cc4dbf
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Mon Aug 08 15:39:16 2022
Add WorkerParameters.getGeneration
Relnote: """
`WorkerParameters.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
This worker can possibly be of an older generation rather than latest known,
if an update has happened while this worker is running."""
bug: 219446409
Test: WorkUpdateTest#updateWorkerParameterGeneration
Change-Id: I128a9838067f3a1722a9460f52ef58fb0f98136c
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkerParameters.java
M work/work-rxjava2/src/test/java/androidx/work/RxWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/workers/ConstraintTrackingWorkerTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxForegroundInfoTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkerWrapperTest.java
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/RxWorkerTest.kt
M work/work-rxjava3/src/test/java/androidx/work/rxjava3/SetCompletableProgressTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerWrapper.java
M work/work-runtime-ktx/src/androidTest/java/androidx/work/CoroutineWorkerTest.kt
M work/work-testing/src/main/java/androidx/work/testing/TestListenableWorkerBuilder.java
M work/work-runtime/api/current.txt
M work/work-runtime/src/main/java/androidx/work/impl/WorkerUpdater.kt
M work/work-rxjava2/src/test/java/androidx/work/RxForegroundInfoTest.kt
M work/work-runtime/api/restricted_current.txt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/RemoteListenableWorkerTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/DefaultWorkerFactoryTest.java
M work/work-runtime/src/androidTest/java/androidx/work/DelegatingWorkerFactoryTest.kt
M work/work-rxjava2/src/test/java/androidx/work/SetCompletableProgressTest.kt
M work/work-runtime/src/androidTest/java/androidx/work/WorkForegroundRunnableTest.kt
M work/work-runtime/src/main/java/androidx/work/WorkerParameters.java
al...@google.com
I like the ability introduced in 2.8.0-alpha03 to update an existing work request, particularly a periodic work request.
I see that there is a new ExistingPeriodicWorkPolicy.UPDATE type as well as a new WorkManager.updateWork() method.
Can I ask: what is the difference between setting up a new work request and calling enqueueUniquePeriodicWork()ExistingPeriodicWorkPolicy.UPDATE as the work policy), versus calling updateWork()
ub...@gmail.com
Project: platform/frameworks/support
Branch: androidx-main
commit cb25671d1f6f60aa0baf13e39a66496b28540915
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Aug 11 15:21:26 2022
Add generation to WorkerInfo
Relnote: """
`WorkerInfo.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
If the worker is currently running, it can possibly be of an older generation rather than
returned by this methof if an update has happened during an execution of this worker."""
bug: 219446409
Test: WorkUpdateTest
Change-Id: I665c5d480700dd682d1268ee88be124783fca70f
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkInfo.java
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkInfoTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkInfo.java
M work/work-runtime/api/current.txt
https://android-review.googlesource.com/2183459
Branch: androidx-main
commit cb25671d1f6f60aa0baf13e39a66496b28540915
Author: Sergey Vasilinets <sergeyv@google.com>
Date: Thu Aug 11 15:21:26 2022
Add generation to WorkerInfo
Relnote: """
`WorkerInfo.getGeneration()` was added that returns
a generation of a worker. A worker has multiple generations, if it was updated via
`WorkManager.updateWork` or `WorkManager.enqueueUniquePeriodicWork` using
`ExistingPeriodicWorkPolicy.UPDATE`.
If the worker is currently running, it can possibly be of an older generation rather than
returned by this methof if an update has happened during an execution of this worker."""
bug: 219446409
Test: WorkUpdateTest
Change-Id: I665c5d480700dd682d1268ee88be124783fca70f
M work/work-multiprocess/src/main/java/androidx/work/multiprocess/parcelable/ParcelableWorkInfo.java
M work/work-runtime/api/restricted_current.txt
M work/work-runtime/src/androidTest/java/androidx/work/impl/WorkManagerImplTest.java
M work/work-runtime/src/androidTest/java/androidx/work/WorkUpdateTest.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpec.kt
M work/work-runtime/src/main/java/androidx/work/impl/model/WorkSpecDao.kt
M work/work-multiprocess/src/androidTest/java/androidx/work/multiprocess/ParcelableWorkInfoTest.kt
M work/work-runtime/api/public_plus_experimental_current.txt
M work/work-runtime/src/main/java/androidx/work/WorkInfo.java
M work/work-runtime/api/current.txt
au...@google.com
al...@google.com
This bug was linked in a change in the following release(s):
androidx.work:work-multiprocess:2.8.0-alpha04androidx.work:work-rxjava2:2.8.0-alpha04androidx.work:work-rxjava3:2.8.0-alpha04
al...@google.com
ub...@gmail.com
Thanks for the fix! I just noticed another one:
ParcelCompat.writeBoolean was deprecated with instructions to use Parcel.writeInt directly with a value of 0 or 1. This does not make sense. The point of ParcelCompat.writeBoolean was to complement Parcel.writeBoolean, which was introduced in API 29. Doesn't make sense to take it away now.
al...@google.com
ub...@gmail.com
Just a general thought: it might make sense to review these deprecations systematically. I'm guessing there are quite a few more problems lurking, as I only use a small slice of the affected APIs.
al...@google.com
Likely, but I don't think we would have caught either of these during manual review. They were technically correct since the implementations were single-line and inlineable, so applying the replacement would still have the same runtime behavior (and bytecode if running an optimizer).
We'd need to go back through and audit methods that were originally written without a proper SDK_INT check.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 2d316160b6048996e91929c28ec33d91603900bb
Author: Alan Viverette <alanv@google.com>
Date: Thu Jun 13 14:10:24 2024
Undeprecate ParcelCompat.writeBoolean, fix delegation on API 29+
Relnote: """Reverts deprecation of ParcelCompat.writeBoolean and delegates
to the platform API on API level 29 and above."""
Bug: 313834577
Test: ParcelCompatTest
Change-Id: I9d2436d90f3cbe3bf22e2a3c97171f39b53cf040
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/os/ParcelCompat.java
https://android-review.googlesource.com/3132533
Branch: androidx-main
commit 2d316160b6048996e91929c28ec33d91603900bb
Author: Alan Viverette <alanv@google.com>
Date: Thu Jun 13 14:10:24 2024
Undeprecate ParcelCompat.writeBoolean, fix delegation on API 29+
Relnote: """Reverts deprecation of ParcelCompat.writeBoolean and delegates
to the platform API on API level 29 and above."""
Bug: 313834577
Test: ParcelCompatTest
Change-Id: I9d2436d90f3cbe3bf22e2a3c97171f39b53cf040
M core/core/api/current.txt
M core/core/api/restricted_current.txt
M core/core/src/main/java/androidx/core/os/ParcelCompat.java
al...@google.com
Closing this out. There may still be one-offs, but let's use new bug reports for those.
Description
```
public static int getWindowSystemUiVisibility(@NonNull View view) {
return view.getWindowSystemUiVisibility();
}
```
These methods should be deprecated.