Compose Compiler uses full file path to generate keys in rememberExpression, breaking build reproducibility [313937484]

Fixed

Bug

Status Update

No update yet.

Description

ig...@jetbrains.com

created issue #1

Nov 30, 2023 03:07PM

Jetpack Compose compiler version: 1.5.4 Android Studio Build: #AI-223.8836.35.2231.11090377, built on November 13, 2023 Kotlin version: 1.9.20

The change introduced by commit 22421ef1f3aab2bb317e164845bf1630606a099c uses currentFile.fileEntry.name field to generate keys to be passed to startReplaceableGroup call. I discovered that this field contains the absolute file path, not just the part relative to the project root.

In practice that results in binary different artifacts being produced for binary equivalent sources stored under different paths. E.g. builds under /tmp/ci-build-42/ will always produce binary equal artifacts for a given source code revision, but these artifacts will be different from the ones produced from the same revision under /tmp/ci-build-43/.

Steps to Reproduce or Code Sample to Reproduce:

Create a new project with "Empty Activity" template
Set the Compose compiler version to 1.5.4 and Kotlin plugin to 1.9.20
Build the application using ./gradlew clean build --no-daemon, store ./app/build/intermediates/compile_app_classes_jar/release/classes.jar
Copy the project root somewhere else
Rebuild the application again with the same command under the new root, store the same file
Compare files from two builds from different directories

ReproducerComposableKt.class will be the only file different between the resulting jars. By applying javap -c and comparing the output for these classes, you'll see the only difference there is a value for a constant used in startReplaceableGroup call.

For your convenience I also provide projects for compiler versions 1.5.4 and 1.5.3 I used to verify my findings (see reproducer.tgz). Also, the fileName value I extracted with a debugger from 1.5.4 project looks like this:

_Users_My_Name_AndroidStudioProjects_ComposeReproIssueReproducer_1_5_4_app_src_main_java_com_example_composereproissuereproducer_ReproducerComposableKt

reproducer.tgz

200 KB

Download

ReproducerComposable.kt

1.6 KB

Download

MainActivity.kt

1.1 KB

Download

Comments

as...@google.com <as...@google.com> Nov 30, 2023 06:15PM

Reassigned to as...@google.com.

ap...@google.com <ap...@google.com> #2Dec 5, 2023 11:16PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 0154910724cdc44253af1d2f8cede76264783226
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Idfd1faa3a826bb91ee14722f7437bdcf99cf0018

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3151736

am...@gmail.com <am...@gmail.com> #3Dec 14, 2023 05:33AM

Project: platform/frameworks/support
Branch: androidx-main

commit 39cd1e9f7579513bde139c17f9c51f9012d56152
Author: Aurimas Liutikas <aurimas@google.com>
Date: Thu Jun 27 15:25:02 2024

Expand native target support for annotation and collection libraries

Reland

r.android.com/3151736 now with workaround for

https://youtrack.jetbrains.com/issue/KT-62653

- Enable watchos and tvos download in importMaven
- Add support for watchos and tvos targets in AndroidXMultiplatformExtension
- Enable watchos and tvos in :annotation:annotation
- Enable linuxArm64, watchos, and tvos in :collection:collection

This work is required as we work towards setting up native stubs for
compose projects.

Test: ./gradlew collection:collection:publish
Bug: 349894318
Change-Id: Ic795af8486db48b31633799e06665717d08398db

M annotation/annotation/build.gradle
M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M collection/collection/build.gradle
M development/build_log_simplifier/messages.ignore
M development/importMaven/src/main/kotlin/androidx/build/importMaven/KmpConfig.kt

https://android-review.googlesource.com/3156121

as...@google.com <as...@google.com> #4Dec 14, 2023 01:53PM

Comment has been deleted.

Message last modified on Dec 14, 2023 01:54PM

as...@google.com <as...@google.com> #5Dec 14, 2023 01:56PM

Project: platform/frameworks/support
Branch: androidx-main

commit c56a2faf24c82bf961cb10440156745bf3cf30bd
Author: Aurimas Liutikas <aurimas@google.com>
Date: Wed Jul 03 11:10:40 2024

Add linuxX64Stubs for compose runtime libraries

- Add support for linuxX64Stubs
- Add these linuxX64Stubs to compose runtime projects
- Move OperationsTest from commonTest to jvmTest as it has
jvm-reflection usages

Bug: 349894318
Test: ./gradlew -p compose/runtime build
Change-Id: Ia600fafb174b585cf5a0d7a7f3c3726d10b4cc92

M buildSrc/private/src/main/kotlin/androidx/build/AndroidXMultiplatformExtension.kt
M buildSrc/public/src/main/kotlin/androidx/build/KmpPlatforms.kt
M compose/runtime/runtime-saveable/build.gradle
M compose/runtime/runtime-test-utils/build.gradle
A compose/runtime/runtime-test-utils/src/commonMain/kotlin/androidx/compose/runtime/mock/SynchronizedObject.kt
M compose/runtime/runtime-test-utils/src/commonMain/kotlin/androidx/compose/runtime/mock/TestMonotonicFrameClock.kt
A compose/runtime/runtime-test-utils/src/jvmMain/kotlin/androidx/compose/runtime/mock/SynchronizedObject.jvm.kt
A compose/runtime/runtime-test-utils/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/mock/SynchronizedObject.linuxx64Stubs.kt
M compose/runtime/runtime/build.gradle
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/Stack.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/collection/ScopeMap.kt
M compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/snapshots/SnapshotStateSet.kt
M compose/runtime/runtime/src/commonTest/kotlin/androidx/compose/runtime/CompositionTestExtensions.kt
M compose/runtime/runtime/src/jvmTest/kotlin/androidx/compose/runtime/changelist/OperationsTest.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/MonotonicFrameClock.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/NotImplemented.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/SynchronizedObject.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/TestOnly.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/Atomic.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/ComposableLambda.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/JvmDefaultWithCompatibility.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/Thread.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/Utils.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/internal/WeakReference.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsMain/kotlin/androidx/compose/runtime/snapshots/SnapshotContextElement.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsTest/kotlin/kotlinx/test/IgnoreAndroidUnitTestTarget.linuxx64Stubs.kt
A compose/runtime/runtime/src/linuxx64StubsTest/kotlin/kotlinx/test/IgnoreJsTarget.linuxx64Stubs.kt

https://android-review.googlesource.com/3159861

Issue 313937484

Description

Issue summary

Comments

as...@google.com <as...@google.com> Nov 30, 2023 06:15PM

ap...@google.com <ap...@google.com> #2Dec 5, 2023 11:16PM

am...@gmail.com <am...@gmail.com> #3Dec 14, 2023 05:33AM

as...@google.com <as...@google.com> #4Dec 14, 2023 01:53PM

as...@google.com <as...@google.com> #5Dec 14, 2023 01:56PM

Add comment

Issue metadata