Fixed
Status Update
No update yet.
Comments
da...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
ap...@google.com
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ccba800146addcce3b8bd6977413e34e26c71d9c
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Fri Jun 07 15:11:16 2024
[KSP2] Update test for Java error types
KSP2 keeps the nullability for error types. This should be a good change as more information is kept. For example the nullability of `SomeErrorType?` is nullable. When the origin is Java the nullability becomes Platform and since XProcessing now treats most Platform types as nullable we're updating our tests to reflect that.
Test: XTypeTest
Bug: 314151707
Change-Id: Ib05f467be78421859d9e3f45724d84f4af1fc1b4
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
https://android-review.googlesource.com/3119913
Branch: androidx-main
commit ccba800146addcce3b8bd6977413e34e26c71d9c
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Fri Jun 07 15:11:16 2024
[KSP2] Update test for Java error types
KSP2 keeps the nullability for error types. This should be a good change as more information is kept. For example the nullability of `SomeErrorType?` is nullable. When the origin is Java the nullability becomes Platform and since XProcessing now treats most Platform types as nullable we're updating our tests to reflect that.
Test: XTypeTest
Bug: 314151707
Change-Id: Ib05f467be78421859d9e3f45724d84f4af1fc1b4
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 6029b373e0606c6a124cc61ab1fa01622a134ddc
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Wed Apr 17 13:14:09 2024
[KSP2] Fix star projections
`KSTypeArgument.type` of star projections are no longer resolved to upper bound and have a `null` value in KSP2 and this leads to NPE in XProcessing. In this CL we try to accommodate that by introducing a new type `KspStarTypeArgumentType` to represent star projections.
Unlike in KSP where `KSTypeArgument` is not a `KSType`, in XProcessing `KspTypeArgumentType` is a `KspType` so we still need a `KSType` in `KspStarTypeArgumentType`. Here we follow `KspVoidType` and use `Unit` as a placeholder.
The type names we generate will still be `?` in Java and `*` in Kotlin. This is the same for both KSP1 and KSP2.
Bug: 314151707
Test: XTypeTest.kt, TypeAssignmentTest.kt
Change-Id: Idb6fc262f342a73a2f524230ae3999102c2889a0
M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspProcessingEnv.kt
A room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspStarTypeArgumentType.kt
M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspTypeArgumentType.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
https://android-review.googlesource.com/3045215
Branch: androidx-main
commit 6029b373e0606c6a124cc61ab1fa01622a134ddc
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Wed Apr 17 13:14:09 2024
[KSP2] Fix star projections
`KSTypeArgument.type` of star projections are no longer resolved to upper bound and have a `null` value in KSP2 and this leads to NPE in XProcessing. In this CL we try to accommodate that by introducing a new type `KspStarTypeArgumentType` to represent star projections.
Unlike in KSP where `KSTypeArgument` is not a `KSType`, in XProcessing `KspTypeArgumentType` is a `KspType` so we still need a `KSType` in `KspStarTypeArgumentType`. Here we follow `KspVoidType` and use `Unit` as a placeholder.
The type names we generate will still be `?` in Java and `*` in Kotlin. This is the same for both KSP1 and KSP2.
Bug: 314151707
Test: XTypeTest.kt, TypeAssignmentTest.kt
Change-Id: Idb6fc262f342a73a2f524230ae3999102c2889a0
M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspProcessingEnv.kt
A room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspStarTypeArgumentType.kt
M room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspTypeArgumentType.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 0cac90e7eab64493e887a66b066691dffc682fa3
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Fri May 17 13:02:40 2024
[KSP2] Fix vararg test
Java arrays have covariant bounds in KSP2 and since XProcessing still
considers varargs as arrays we are updating our test to reflect that.
Bug: 314151707
Test: XExecutableElementTest
Change-Id: Ia416dfe5edf7c7e2024524722ca803f52f0c063f
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt
https://android-review.googlesource.com/3092482
Branch: androidx-main
commit 0cac90e7eab64493e887a66b066691dffc682fa3
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Fri May 17 13:02:40 2024
[KSP2] Fix vararg test
Java arrays have covariant bounds in KSP2 and since XProcessing still
considers varargs as arrays we are updating our test to reflect that.
Bug: 314151707
Test: XExecutableElementTest
Change-Id: Ia416dfe5edf7c7e2024524722ca803f52f0c063f
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 1c674f110bcd43f39a1f2e7b9dd5527288d60ac4
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Mon Jul 01 17:27:13 2024
[KSP2] Fix param name test
KSP2 is returning more consistent parameter names now so we're updating
our test to reflect that.
Bug: 314151707
Test: XExecutableElementTest.parameterNames
Change-Id: I95c62262698bf91829ab3abcf19383fac5c4a94d
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt
https://android-review.googlesource.com/3155137
Branch: androidx-main
commit 1c674f110bcd43f39a1f2e7b9dd5527288d60ac4
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Mon Jul 01 17:27:13 2024
[KSP2] Fix param name test
KSP2 is returning more consistent parameter names now so we're updating
our test to reflect that.
Bug: 314151707
Test: XExecutableElementTest.parameterNames
Change-Id: I95c62262698bf91829ab3abcf19383fac5c4a94d
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 7a6aa8e3cdc2419f176c23d5b55898dc7ddc6570
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Tue Jul 30 21:52:21 2024
Use KSP1 for all tests in room-compiler and privacysandbox
Bug: 314151707
Test: existing tests still pass
Change-Id: Ic097eee603f5bfcc3dff25e2a22e624c33e6cd49
M privacysandbox/tools/tools-apicompiler/src/test/java/androidx/privacysandbox/tools/apicompiler/util/KspTestRunner.kt
M privacysandbox/tools/tools-testing/src/main/java/androidx/privacysandbox/tools/testing/CompilationTestHelper.kt
M room/room-compiler/build.gradle
A room/room-compiler/src/test/kotlin/androidx/room/ProcessorTestWrapper.kt
M room/room-compiler/src/test/kotlin/androidx/room/ext/ElementExtTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/parser/SQLTypeAffinityTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/AutoMigrationProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/BaseDaoTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/BaseEntityParserTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/BaseFtsEntityParserTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/CustomConverterProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseConstructorProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseViewProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DeleteOrUpdateShortcutMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/FieldProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/Fts4TableEntityProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/GeneratedCustomConverterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/InsertOrUpsertShortcutMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTargetMethodTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/ProjectionExpanderTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/RawQueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/RemoveUnusedColumnsTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/TableEntityProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/TransactionMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/BuiltInConverterFlagsTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/CustomTypeConverterResolutionTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/NullabilityAwareTypeConverterStoreTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAssignmentTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeConverterStoreTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/query/QueryWriterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/InProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/AutoMigrationWriterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/BaseDaoKotlinCodeGenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseKotlinCodeGenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseObjectConstructorWriterKotlinCodeGenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseWriterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DefaultsInDaoTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/OpenDelegateWriterTest.kt
https://android-review.googlesource.com/3200630
Branch: androidx-main
commit 7a6aa8e3cdc2419f176c23d5b55898dc7ddc6570
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Tue Jul 30 21:52:21 2024
Use KSP1 for all tests in room-compiler and privacysandbox
Bug: 314151707
Test: existing tests still pass
Change-Id: Ic097eee603f5bfcc3dff25e2a22e624c33e6cd49
M privacysandbox/tools/tools-apicompiler/src/test/java/androidx/privacysandbox/tools/apicompiler/util/KspTestRunner.kt
M privacysandbox/tools/tools-testing/src/main/java/androidx/privacysandbox/tools/testing/CompilationTestHelper.kt
M room/room-compiler/build.gradle
A room/room-compiler/src/test/kotlin/androidx/room/ProcessorTestWrapper.kt
M room/room-compiler/src/test/kotlin/androidx/room/ext/ElementExtTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/parser/SQLTypeAffinityTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/AutoMigrationProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/BaseDaoTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/BaseEntityParserTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/BaseFtsEntityParserTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/CustomConverterProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseConstructorProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseViewProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/DeleteOrUpdateShortcutMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/FieldProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/Fts4TableEntityProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/GeneratedCustomConverterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/InsertOrUpsertShortcutMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTargetMethodTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/PojoProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/ProjectionExpanderTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/RawQueryMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/RemoveUnusedColumnsTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/TableEntityProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/TransactionMethodProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/BuiltInConverterFlagsTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/CustomTypeConverterResolutionTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/NullabilityAwareTypeConverterStoreTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAssignmentTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/TypeConverterStoreTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/solver/query/QueryWriterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/testing/InProcessorTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/AutoMigrationWriterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/BaseDaoKotlinCodeGenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseKotlinCodeGenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseObjectConstructorWriterKotlinCodeGenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseWriterTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/DefaultsInDaoTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/writer/OpenDelegateWriterTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 3785ab168be6f768afc3a4f75d1e46ab2f01e8aa
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Jul 25 15:46:16 2024
Update KSP to 2.0.20-Beta2-1.0.23 in room-compiler-processing-testing
Also enlarge heap to 8g so that we can run all tests in room-compiler-processing in one go.
Bug: 314151707
Test: 48 Xprocessing tests fail in this commit
Change-Id: Iae3eb4961d65c4cc1f7aef29c1dc271f8914d571
M room/room-compiler-processing-testing/build.gradle
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/CompilationResultSubject.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KaptCompilationStep.kt
M room/room-compiler-processing/build.gradle
https://android-review.googlesource.com/3194615
Branch: androidx-main
commit 3785ab168be6f768afc3a4f75d1e46ab2f01e8aa
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Jul 25 15:46:16 2024
Update KSP to 2.0.20-Beta2-1.0.23 in room-compiler-processing-testing
Also enlarge heap to 8g so that we can run all tests in room-compiler-processing in one go.
Bug: 314151707
Test: 48 Xprocessing tests fail in this commit
Change-Id: Iae3eb4961d65c4cc1f7aef29c1dc271f8914d571
M room/room-compiler-processing-testing/build.gradle
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/CompilationResultSubject.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KaptCompilationStep.kt
M room/room-compiler-processing/build.gradle
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 759dac2953163fde4b307f3dc748807f55f63fb7
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Jul 25 19:28:26 2024
Run failing tests in room-compiler-processing* with KSP1
We enabled KSP2 for all XProcessing tests in the previous commit. Here we restore the old testing infra that uses the Kotlin CLI for KSP1 and pass compiler args "-language-version=1.9" and "-api-version=1.9" to failing tests to force them to run with the old infra. We hope to remove the args and migrate these tests to KSP2 gradually in the future.
Bug: 314151707
Test: existing tests still pass
Change-Id: I60ad9465fadc33cd84f2be720c75dbcd19e6ba8c
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/ProcessorTestExt.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/KotlinCliRunner.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/Ksp1Compilation.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/Ksp2Compilation.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestDefaultOptions.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKspRegistrar.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KspCompilationStep.kt
M room/room-compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/TestRunnerTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/FallbackLocationInformationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/InternalModifierTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/MethodSpecHelperTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationBoxTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationValueTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XMessagerTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/compat/XConvertersTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/javac/kotlin/KotlinMetadataElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspJvmDescriptorUtilsTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeNamesGoldenTest.kt
https://android-review.googlesource.com/3196851
Branch: androidx-main
commit 759dac2953163fde4b307f3dc748807f55f63fb7
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Jul 25 19:28:26 2024
Run failing tests in room-compiler-processing* with KSP1
We enabled KSP2 for all XProcessing tests in the previous commit. Here we restore the old testing infra that uses the Kotlin CLI for KSP1 and pass compiler args "-language-version=1.9" and "-api-version=1.9" to failing tests to force them to run with the old infra. We hope to remove the args and migrate these tests to KSP2 gradually in the future.
Bug: 314151707
Test: existing tests still pass
Change-Id: I60ad9465fadc33cd84f2be720c75dbcd19e6ba8c
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/ProcessorTestExt.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/KotlinCliRunner.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/Ksp1Compilation.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/Ksp2Compilation.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestDefaultOptions.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKspRegistrar.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KspCompilationStep.kt
M room/room-compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/TestRunnerTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/FallbackLocationInformationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/InternalModifierTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/MethodSpecHelperTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationBoxTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationValueTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XMessagerTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/compat/XConvertersTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/javac/kotlin/KotlinMetadataElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspJvmDescriptorUtilsTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeNamesGoldenTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 436d9343ec00c8525eff33c3196c5f61f6fbd6ce
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Jan 30 17:15:06 2024
Update xprocessing-testing for K2
Since ComponentRegistrar is deprecated in K2 this changes updates the infra in xprocessing-testing to instead use CLI-like APIs for invoking both KAPT and KSP.
The KAPT step still invokes Kotlin CLI but instead of using a registrar it populates the compiler arguments with all the necessary plugins so it is loaded and run the same way KaptCli.main() does. The reason KaptCli.main() is not used directly is because it strictly checks for on the non-embeddable jar to be available in the classpath but xprocessing-testing uses the 'kotlin-annotation-processing-embeddable' which is equivalent for compile testing usage.
The KSP step no longer invokes Kotlin CLI and instead uses KSP 2.0's CLI API, also avoiding the use of a registrar APIs. Various shared options are synced between the Kotlin CLI runner and the KSP step by moving them to a central object, TestDefaultOptions and TestClasspath.
For completeness DelegatingTestRegistrar was still updated to support newer CompilerPluginRegistrar in the case custom test plugins need to be created.
Bug: 314151707
Test: ./gradlew \
:room:room-compiler-processing-testing:test \
:room:room-compiler-processing:test
Change-Id: Ie59d978110003b1c4eebabaf387bd91f552ec6eb
M gradle/libs.versions.toml
M room/room-compiler-processing-testing/build.gradle
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/CompilationResultSubject.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/DelegatingTestRegistrar.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/KotlinCliRunner.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/SourceSet.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestClasspath.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestDefaultOptions.kt
D room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKapt3Registrar.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKotlinCompiler.kt
D room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKspRegistrar.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/JavaSourceCompilationStep.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KaptCompilationStep.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KotlinCompilationStep.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KotlinSourceCompilationStep.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KspCompilationStep.kt
A room/room-compiler-processing-testing/src/main/resources/META-INF/services/org.jetbrains.kotlin.compiler.plugin.CompilerPluginRegistrar
M room/room-compiler-processing-testing/src/main/resources/META-INF/services/org.jetbrains.kotlin.compiler.plugin.ComponentRegistrar
M room/room-compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/TestRunnerTest.kt
M room/room-compiler-processing/build.gradle
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/compat/XConvertersTest.kt
https://android-review.googlesource.com/2938423
Branch: androidx-main
commit 436d9343ec00c8525eff33c3196c5f61f6fbd6ce
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Tue Jan 30 17:15:06 2024
Update xprocessing-testing for K2
Since ComponentRegistrar is deprecated in K2 this changes updates the infra in xprocessing-testing to instead use CLI-like APIs for invoking both KAPT and KSP.
The KAPT step still invokes Kotlin CLI but instead of using a registrar it populates the compiler arguments with all the necessary plugins so it is loaded and run the same way KaptCli.main() does. The reason KaptCli.main() is not used directly is because it strictly checks for on the non-embeddable jar to be available in the classpath but xprocessing-testing uses the 'kotlin-annotation-processing-embeddable' which is equivalent for compile testing usage.
The KSP step no longer invokes Kotlin CLI and instead uses KSP 2.0's CLI API, also avoiding the use of a registrar APIs. Various shared options are synced between the Kotlin CLI runner and the KSP step by moving them to a central object, TestDefaultOptions and TestClasspath.
For completeness DelegatingTestRegistrar was still updated to support newer CompilerPluginRegistrar in the case custom test plugins need to be created.
Bug: 314151707
Test: ./gradlew \
:room:room-compiler-processing-testing:test \
:room:room-compiler-processing:test
Change-Id: Ie59d978110003b1c4eebabaf387bd91f552ec6eb
M gradle/libs.versions.toml
M room/room-compiler-processing-testing/build.gradle
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/CompilationResultSubject.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/DelegatingTestRegistrar.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/KotlinCliRunner.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/SourceSet.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestClasspath.kt
A room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestDefaultOptions.kt
D room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKapt3Registrar.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKotlinCompiler.kt
D room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKspRegistrar.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/JavaSourceCompilationStep.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KaptCompilationStep.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KotlinCompilationStep.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KotlinSourceCompilationStep.kt
M room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/steps/KspCompilationStep.kt
A room/room-compiler-processing-testing/src/main/resources/META-INF/services/org.jetbrains.kotlin.compiler.plugin.CompilerPluginRegistrar
M room/room-compiler-processing-testing/src/main/resources/META-INF/services/org.jetbrains.kotlin.compiler.plugin.ComponentRegistrar
M room/room-compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/TestRunnerTest.kt
M room/room-compiler-processing/build.gradle
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/compat/XConvertersTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 2d0084caa4bbdd6f02067bc629e0f5e5ffccc5c1
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Aug 08 11:56:39 2024
Use AndroidX Kotlin and KSP artifacts in room-compiler-processing-testing
Bug: 314151707
Test: existing tests still pass
Change-Id: I14bfa3017d2f8d578a812b5decef835ce956d1ae
M room/room-compiler-processing-testing/build.gradle
https://android-review.googlesource.com/3213481
Branch: androidx-main
commit 2d0084caa4bbdd6f02067bc629e0f5e5ffccc5c1
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Aug 08 11:56:39 2024
Use AndroidX Kotlin and KSP artifacts in room-compiler-processing-testing
Bug: 314151707
Test: existing tests still pass
Change-Id: I14bfa3017d2f8d578a812b5decef835ce956d1ae
M room/room-compiler-processing-testing/build.gradle
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 6edd878457349e6b7b7b8d8045ef4299d1481723
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Wed Aug 14 17:56:58 2024
Update tests that use room-compiler-processing-testing
- Remove KOTLINC_LANGUAGE_1_9_ARGS from tests that now pass without it.
- Replace manually specified args with KOTLINC_LANGUAGE_1_9_ARGS.
- Add comments/Github issue links to all KOTLINC_LANGUAGE_1_9_ARGS usages in room-compiler-processing.
- Two new tests fail with KSP2 under current setup (InternalModifierTest and KspTypeNamesGoldenTest). Need to investigate.
Test: existing tests still pass
Bug: 314151707
Change-Id: Ic1617bd88ae0d08d92fa1ca3df990c1116b0e5d0
M room/room-compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/TestRunnerTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/FallbackLocationInformationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/InternalModifierTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/MethodSpecHelperTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationBoxTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationValueTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XMessagerTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/compat/XConvertersTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/javac/kotlin/KotlinMetadataElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspJvmDescriptorUtilsTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeNamesGoldenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/ProcessorTestWrapper.kt
https://android-review.googlesource.com/3216084
Branch: androidx-main
commit 6edd878457349e6b7b7b8d8045ef4299d1481723
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Wed Aug 14 17:56:58 2024
Update tests that use room-compiler-processing-testing
- Remove KOTLINC_LANGUAGE_1_9_ARGS from tests that now pass without it.
- Replace manually specified args with KOTLINC_LANGUAGE_1_9_ARGS.
- Add comments/Github issue links to all KOTLINC_LANGUAGE_1_9_ARGS usages in room-compiler-processing.
- Two new tests fail with KSP2 under current setup (InternalModifierTest and KspTypeNamesGoldenTest). Need to investigate.
Test: existing tests still pass
Bug: 314151707
Change-Id: Ic1617bd88ae0d08d92fa1ca3df990c1116b0e5d0
M room/room-compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/TestRunnerTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/FallbackLocationInformationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/InternalModifierTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/MethodSpecHelperTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationBoxTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationValueTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XMessagerTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/compat/XConvertersTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/javac/kotlin/KotlinMetadataElementTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspJvmDescriptorUtilsTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeNamesGoldenTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/ProcessorTestWrapper.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit 5edbaa2d9bed50bfb3080a0d454ab1c4cfbc36cd
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Aug 15 17:15:41 2024
Add KSP issue links for InternalModifierTest and KspTypeNamesGoldenTest
Bug: 314151707
Test: existing tests still pass
Change-Id: Id8620469172bf5d6eb109d33a149f112a5afa7af
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/InternalModifierTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeNamesGoldenTest.kt
https://android-review.googlesource.com/3220557
Branch: androidx-main
commit 5edbaa2d9bed50bfb3080a0d454ab1c4cfbc36cd
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Thu Aug 15 17:15:41 2024
Add KSP issue links for InternalModifierTest and KspTypeNamesGoldenTest
Bug: 314151707
Test: existing tests still pass
Change-Id: Id8620469172bf5d6eb109d33a149f112a5afa7af
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/InternalModifierTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/ksp/KspTypeNamesGoldenTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
commit ff918f6c5cf6c7fc01496ec9818b7882ec46a7d7
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Fri Aug 16 18:43:52 2024
Update KSP issue links in room-compiler-processing and room-compiler
Adding and removing KSP issue links as some KSP issues are resolved and some are added.
This CL also changes XTypeElementTest.allMethods_withJvmNames() as the behaviors changed a bit in KSP2 and the test is only to document the behaviors.
Bug: 314151707
Test: existing tests still pass
Change-Id: I9362f91d6a5fb1e2868e06595c36dd2b77085289
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationBoxTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeElementTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/BaseDaoTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt
https://android-review.googlesource.com/3225442
Branch: androidx-main
commit ff918f6c5cf6c7fc01496ec9818b7882ec46a7d7
Author: Kuan-Ying Chou <kuanyingchou@google.com>
Date: Fri Aug 16 18:43:52 2024
Update KSP issue links in room-compiler-processing and room-compiler
Adding and removing KSP issue links as some KSP issues are resolved and some are added.
This CL also changes XTypeElementTest.allMethods_withJvmNames() as the behaviors changed a bit in KSP2 and the test is only to document the behaviors.
Bug: 314151707
Test: existing tests still pass
Change-Id: I9362f91d6a5fb1e2868e06595c36dd2b77085289
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationBoxTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt
M room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeElementTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/BaseDaoTest.kt
M room/room-compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Kuan-Ying Chou <
Link:
Update Kotlin and KSP to 2.1.0-Beta1 in room-compiler-processing-testing
Expand for full commit details
Update Kotlin and KSP to 2.1.0-Beta1 in room-compiler-processing-testing
Update Kotlin Compiler Embeddable and KSP used by XProcessing testing to 2.1.0-Beta1 and 2.1.0-Beta1-1.0.25. This only affects users of XProcessing testing and not users of Room or Dagger. Some other changes include:
- Pass JVM module name to KSP2 as its processing is separated from Kotlin compilation and its default module name is an empty string instead of "main".
- Explicitly disable K2 KAPT for XProcessing testing. This can be enabled by XProcesing testing users by passing `-Xuse-k2-kapt` to kotlinc arguments.
- Add `isKSP2` to XTestInvocation.
- Add a test for K2 related flags.
- Update FieldProcessorTest for covariant Java array in KSP2.
- Remove the 1.9 language-version flag from some tests as the related issues have been fixed in KSP2.
Bug: 314151707
Test: existing tests still pass
Change-Id: If80933c113f9b31dabe49acf4a32c3e4381467f5
Files:
- M
room/room-compiler-processing-testing/build.gradle - M
room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/CompilationResultSubject.kt - M
room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/XTestInvocation.kt - M
room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/KotlinCliRunner.kt - M
room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/Ksp2Compilation.kt - M
room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestDefaultOptions.kt - M
room/room-compiler-processing-testing/src/test/java/androidx/room/compiler/processing/util/TestRunnerTest.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/synthetic/KspSyntheticPropertyMethodElement.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/FallbackLocationInformationTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/KotlinMetadataTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationBoxTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationValueTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XElementTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XExecutableElementTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XMessagerTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeElementTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeTest.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/compat/XConvertersTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/FieldProcessorTest.kt
Hash: c42f580c795db5d708b4f6fcfff1bc58b93d067f
Date: Thu Sep 19 20:47:26 2024
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Kuan-Ying Chou <
Link:
Remove ordering check in XTypeElementTest.declaredAndInstancemethods
Expand for full commit details
Remove ordering check in XTypeElementTest.declaredAndInstancemethods
Removing the ordering check in KSP2 as it can't restore the declaration order in companion objects for now.
Bug: 314151707
Test: XTypeElementTest.declaredAndInstancemethods
Change-Id: I1e28575f9fcc6595fac10ed1266dff917a8fd873
Files:
- M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XTypeElementTest.kt
Hash: 6710458dc0acbe3a7bc90a68fde6dcf6c2665640
Date: Tue Oct 15 14:58:02 2024
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Kuan-Ying Chou <
Link:
Fix kotlin.Unit in KSP2
Expand for full commit details
Fix `kotlin.Unit` in KSP2
We convert kotlin.* types to Java equivalents in KSDeclaration.asJTypeName() by calling KSP's `Resolver.mapToJvmSignature()`. However, this function now (with 2.0.21-1.0.26-SNAPSHOT) maps `kotlin.Unit` to "V"(void) instead of "Lkotlin/Unit;" and this change breaks our code. This CL fixes that by not calling this function as we shouldn't convert `kotlin.Unit` for most cases in the first place.
There are only few cases we need `void` when getting Java typename:
1. `void` as the return type of a method in Java.
2. `kotlin.Unit` as the return type of a function in Kotlin directly (not a type variable).
3. `kotlin.Unit` as the return type of a Kotlin property setter.
And we use KspVoidType to cover these. From now on KspVoidType is only used when its Java typename should be 'void'. This also fixes an issue that sometimes we return 'void' when a parameter type is `kotlin.Unit`.
Test: XTypeNameTest.kt
Bug: 314151707
Change-Id: I08b4799ee9901b1e50cd61c84d4f8a6913af81e3
Files:
- M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KSFunctionExt.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KSTypeJavaPoetExt.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/ksp/KspProcessingEnv.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/codegen/XTypeNameTest.kt
Hash: fc64dffe4a1ae6e4ef5721201bf44fc00eba41d5
Date: Mon Oct 21 15:03:46 2024
ap...@google.com
Project: platform/prebuilts/androidx/external
Branch: androidx-main
Author: Kuan-Ying Chou <
Link:
Add KSP 2.0.21-1.0.28 artifacts
Expand for full commit details
Add KSP 2.0.21-1.0.28 artifacts
Bug: 314151707
Test: existing tests still pass
Change-Id: I518dbb6fdac219163cf6f806f8f4386964a2dff1
Files:
- A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/LICENSE - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28-sources.jar - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28-sources.jar.asc - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28-sources.jar.asc.md5 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28-sources.jar.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28-sources.jar.md5 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28-sources.jar.sha1 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.jar - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.jar.asc - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.jar.asc.md5 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.jar.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.jar.md5 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.jar.sha1 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.pom - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.pom.asc - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.pom.asc.md5 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.pom.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.pom.md5 - A
com/google/devtools/ksp/symbol-processing-aa-embeddable/2.0.21-1.0.28/symbol-processing-aa-embeddable-2.0.21-1.0.28.pom.sha1 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/LICENSE - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28-sources.jar - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28-sources.jar.asc - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28-sources.jar.asc.md5 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28-sources.jar.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28-sources.jar.md5 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28-sources.jar.sha1 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.jar - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.jar.asc - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.jar.asc.md5 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.jar.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.jar.md5 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.jar.sha1 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.module - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.module.asc - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.module.asc.md5 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.module.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.module.md5 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.module.sha1 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.pom - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.pom.asc - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.pom.asc.md5 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.pom.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.pom.md5 - A
com/google/devtools/ksp/symbol-processing-api/2.0.21-1.0.28/symbol-processing-api-2.0.21-1.0.28.pom.sha1 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/LICENSE - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28-sources.jar - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28-sources.jar.asc - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28-sources.jar.asc.md5 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28-sources.jar.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28-sources.jar.md5 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28-sources.jar.sha1 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.jar - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.jar.asc - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.jar.asc.md5 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.jar.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.jar.md5 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.jar.sha1 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.module - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.module.asc - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.module.asc.md5 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.module.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.module.md5 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.module.sha1 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.pom - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.pom.asc - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.pom.asc.md5 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.pom.asc.sha1 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.pom.md5 - A
com/google/devtools/ksp/symbol-processing-common-deps/2.0.21-1.0.28/symbol-processing-common-deps-2.0.21-1.0.28.pom.sha1 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/LICENSE - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28-sources.jar - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28-sources.jar.asc - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28-sources.jar.asc.md5 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28-sources.jar.asc.sha1 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28-sources.jar.md5 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28-sources.jar.sha1 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.jar - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.jar.asc - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.jar.asc.md5 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.jar.asc.sha1 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.jar.md5 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.jar.sha1 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.pom - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.pom.asc - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.pom.asc.md5 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.pom.asc.sha1 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.pom.md5 - A
com/google/devtools/ksp/symbol-processing/2.0.21-1.0.28/symbol-processing-2.0.21-1.0.28.pom.sha1
Hash: 3c140afec1b7103d6f6b879cc6d7edfa96b5f501
Date: Tue Nov 19 15:07:57 2024
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Kuan-Ying Chou <
Link:
Update KSP to 2.0.21-1.0.28
Expand for full commit details
Update KSP to 2.0.21-1.0.28
Bug: 314151707
Test: existing tests still pass
Change-Id: I7ebc4535b4cf407f9edd04f2694e023c9c28bcae
Files:
- M
room/room-compiler-processing-testing/build.gradle - M
room/room-compiler-processing-testing/src/main/java/androidx/room/compiler/processing/util/compiler/TestKspRegistrar.kt
Hash: 853f95402b61632b9fe28d7ac76e6304439174ab
Date: Tue Nov 19 15:04:54 2024
da...@google.com
Marking this as fixed - The main changes for XProcessing processors to support KSP2 (such as Room and Dagger) is done and XProcessing-Testing also supports running tests with KSP2. All XProcessing tests are passing with KSP2 and 98% of Room tests are in KSP2, the remaining pending KSP fixes. Remaining issues presents when running KSP2 vs KSP1 are regular KSP or XProcessing issues and we'll work towards fixing them, I think the stability is in a decent place to mark this as fixed and continue with regular maintenance and stability improvements.
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Move remaining Room compilation tests to KSP2
Expand for full commit details
Move remaining Room compilation tests to KSP2
Some intended tests changes where done:
* InsertOrUpsertShortcutFunctionProcessorTest and DeleteOrUpdateShortcutFunctionProcessorTest - Array types in KSP2 are covariant. This aligns with Java's array types behaviour and was one of the noted changes from KSP1 to KSP2
* DataClassProcessorTest - Accessor (getter or setter) JVM name is slightly different in KSP2. This doesn't really affect code generation or Room as the names used are those provided by the AST so the test was adjusted for KSP2.
* TableEntityProcessorTest - Order of synthetic accessors (getter or setter) in KSP2 are consistent, getters followed by setters. This also doesn't affect Room and only affected the error message in the test when displaying multiple getter / setter for a property column. The test source was simply adjusted to match KSP2 and Java.
Bug: 314151707
Test: ./gradlew :room:room-compiler:test
Change-Id: If0cdf6cf01661d747e8c131865effbdfdaef610a
Files:
- D
room/room-compiler/src/test/kotlin/androidx/room/ProcessorTestWrapper.kt - M
room/room-compiler/src/test/kotlin/androidx/room/ext/ElementExtTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/parser/SQLTypeAffinityTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/AutoMigrationProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/BaseDaoTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/BaseEntityParserTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/BaseFtsEntityParserTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/CustomConverterProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/DaoProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/DataClassProcessorTargetFunctionTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/DataClassProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseConstructorProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/DatabaseViewProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/DeleteOrUpdateShortcutFunctionProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/FieldProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/Fts4TableEntityProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/GeneratedCustomConverterTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/InsertOrUpsertShortcutFunctionProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/ProjectionExpanderTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/QueryFunctionProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/RawQueryFunctionProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/RemoveUnusedColumnsTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/TableEntityProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/TransactionFunctionProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/processor/autovalue/AutoValuePojoProcessorDelegateTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/solver/BuiltInConverterFlagsTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/solver/CustomTypeConverterResolutionTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/solver/NullabilityAwareTypeConverterStoreTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAdapterStoreTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/solver/TypeAssignmentTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/solver/TypeConverterStoreTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/solver/query/QueryWriterTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/testing/InProcessorTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/AutoMigrationWriterTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/BaseDaoKotlinCodeGenTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DaoWriterTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseObjectConstructorWriterKotlinCodeGenTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/OpenDelegateWriterTest.kt
Hash: 097a642be66db27285ce0988559650a1078e3925
Date: Fri Jan 24 11:37:13 2025
pr...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-compiler:2.7.0-beta01
Description
Currently we use KAPT3 infra which does not work with K2 and FIR (front-end intermediate representation) light mode hence xprocessing-testing Kotlin compilation is forced to Kotlin language version 1.9.
Moreover go over the KSP 2 differences and make workarounds for xprocessing. See