PullToRefresh Indicator not behind PrimaryTabRow [314496282]

Fixed

Bug

Status Update

No update yet.

Description

At...@web.de

created issue #1

Dec 3, 2023 12:59AM

Jetpack Compose version: 1.2.0-alpha12

Jetpack Compose component used: PullToRefreshContainer

Android Studio Build:

Android Studio Iguana | 2023.2.1 Canary 16
Build #AI-232.10227.8.2321.11161997, built on November 30, 2023
Runtime version: 17.0.9+0--11084592 amd64
VM: OpenJDK 64-Bit Server VM by JetBrains s.r.o.
Windows 11.0
GC: G1 Young Generation, G1 Old Generation
Memory: 4090M
Cores: 16
Registry:
    ide.experimental.ui=true

Non-Bundled Plugins:
    idea.plugin.protoeditor (232.9559.10)
    com.github.bufbuild.intellij (0.2.1)
    kotest-plugin-intellij (1.3.73-IC-2023.2)

Steps to Reproduce or Code Sample to Reproduce:

Scaffold() {
...
Column(
	modifier = Modifier
		.fillMaxSize()
		.padding(contentPadding),
) {
	var selectedTabIndex by remember { mutableIntStateOf(0) }

	PrimaryTabRow(
		selectedTabIndex = selectedTabIndex,
		containerColor = Color.Transparent,
	) {
		sections.forEachIndexed { i, section ->
			Tab(
				selected = selectedTabIndex == i,
				onClick = { selectedTabIndex = i },
				text = { Text(stringResource(section.stringRes)) },
			)
		}
	}

	CompositionLocalProvider(
		LocalTextStyle provides MaterialTheme.typography.bodySmall,
	) {
		TabContent(scannerState, communicationUiState, selectedTabIndex, onAction)
	}
}
}


@Composable
private fun NearbyDevicesList(
    items: List<DiscoveredDevice>,
    isOperationOngoing: Boolean,
    onAction: (action: ScannerAction) -> Unit = {},
) {
    val state = rememberPullToRefreshState()
    if (state.isRefreshing) {
        LaunchedEffect(Unit) {
            onAction(ScannerAction.RefreshDevices)
            state.endRefresh()
        }
    }
    Box(Modifier.nestedScroll(state.nestedScrollConnection)) {
        LazyColumn(
            modifier = Modifier.fillMaxSize(),
            contentPadding = PaddingValues(bottom = bottomContentPadding),
        ) {
            if (!state.isRefreshing) {
                items(items) { item ->
                    DiscoveredDevicesListItem(item, isOperationOngoing, onAction)
                    HorizontalDivider()
                }
            }
        }
        PullToRefreshContainer(
            modifier = Modifier.align(Alignment.TopCenter),
            state = state,
            indicator = { pullRefreshState ->
                PullToRefreshDefaults.Indicator(state = pullRefreshState)
            }
        )
    }
}

The indicator is visible on top of the TabRow, see screenshot. I have tried to set the zIndex of the Indicator to -1f and the zIndex of TabRow to 1f but didn't work. What am I missing?

Sun Dec 03 2023 01:59:35 GMT+0100 (Mitteleuropäische Normalzeit).png

44 KB

View

Download

Comments

ma...@google.com <ma...@google.com> Dec 11, 2023 08:14PM

Reassigned to ma...@google.com.

at...@gmail.com <at...@gmail.com> #2Mar 26, 2024 11:19AM

Related to b/308633400, but keeping it separate as it deals specifically with the input mode.

ma...@google.com <ma...@google.com> Apr 4, 2024 10:38PM

Reassigned to ma...@google.com.

ma...@google.com <ma...@google.com> Apr 11, 2024 06:34PM

Accepted by ma...@google.com.

ap...@google.com <ap...@google.com> #3Apr 18, 2024 06:28PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main
Author: Shalom Gibly <sgibly@google.com>
Link: https://android-review.googlesource.com/3288175

Date pickers Locale support

Expand for full commit details

Date pickers Locale support

This change improves how the DatePicker and DateRangePicker handle
locales when a Locale that was set by the date picker's state wasn't
consistently applied to all its parts, leading to potential
inconsistencies in things like date formatting, weekday names, the
first day of the week, etc.

The DatePickerState and the DateRangePickerState were modified to
include and expose a Locale value that can be used by the various parts
of the UI.

There are two ways to create the state:
- Using remember functions: This will default to your device's locale
  and is the recommended way.
- Using DatePickerState or DateRangePickerState directly: This allows
  you to specify a custom Locale that will be applied most of the date
  picker parts, but not all. Note that the title and the headline's
  default text will need to be adjusted to support a specific Locale in
  case a specific one is set.

Fixes: 326490763
Fixes: 321657276
Test: additional date picker and input tests
Relnote: "Updates to the date pickers to ensure consistent Locale
usage throughout the DatePicker and DateRangePicker when setting a
Locale directly through a DatePickerState or a DateRangePickerState.
Note that when setting Locales directly to the state, it's up to you to
ensure that the title and headline texts are localized accordingly, as
their default text will still be applied according to the default
platform Locale."

Change-Id: I370735477b6adae8628fb967b6aa6c6138216883

Files:

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/DatePickerSamples.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/DateInputTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/DatePickerScreenshotTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/DatePickerTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/DateRangeInputTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/DateRangePickerScreenshotTest.kt
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/DateRangePickerTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateInput.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DatePicker.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateRangeInput.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/DateRangePicker.kt

Hash: 2579989ac2b9c281d530ffbf1d1bd9d89fb91270
Date: Mon Sep 30 10:51:27 2024

Issue 314496282