java.lang.IllegalArgumentException: At least one result is necessary. [314931695]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Dec 5, 2023 12:33PM

Component used: Macrobenchmark 1.2.0-SNAPSHOT

Sometimes I get an exception probably that some metrics didn't provide the same results.

java.lang.IllegalArgumentException: At least one result is necessary.
at androidx.benchmark.MetricResult.<init>(MetricResult.kt:50)
at androidx.benchmark.MetricResult.<init>(MetricResult.kt:29)
at androidx.benchmark.macro.MetricResultExtensionsKt.mergeToSingleMetricResults(MetricResultExtensions.kt:138)
at androidx.benchmark.macro.MetricResultExtensionsKt.mergeMultiIterResults(MetricResultExtensions.kt:107)
at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:339)
at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:241)
at androidx.benchmark.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:105)
at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:241)
at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:422)
at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:107)
at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated$default(MacrobenchmarkRule.kt:97)

I think the minimal thing to improve is at least add information about the metric so you can investigate more why this happenned?

- require(size >= 1) { "At least one result is necessary." }
+ require(size >= 1) { "At least one result for $name is necessary." }

Comments

ro...@gmail.com <ro...@gmail.com> #2Jan 31, 2024 07:05PM

Comment has been deleted.

Message last modified on Jan 31, 2024 07:05PM

cc...@google.com <cc...@google.com> Apr 26, 2024 08:41PM

Accepted by cc...@google.com.

ap...@google.com <ap...@google.com> #3Apr 26, 2024 09:23PM

Marked as fixed.

This is expected to be fixed with the change above, which made it into 1.3.0-alpha01.

Please let us know if you still see this issue after updating to that version

pr...@google.com <pr...@google.com> #4May 14, 2024 05:22PM

Hey I'm still seeing this issue with 1.3.0-alpha01, this is the stack:

java.lang.IllegalStateException: Failed to stop [ProcessPid(processName=perfetto, pid=2784)]
at androidx.benchmark.Shell.terminateProcessesAndWait(Shell.kt:596)
at androidx.benchmark.perfetto.PerfettoHelper.stopPerfetto(PerfettoHelper.kt:258)
at androidx.benchmark.perfetto.PerfettoHelper.stopCollecting(PerfettoHelper.kt:236)
at androidx.benchmark.perfetto.PerfettoCapture.stop(PerfettoCapture.kt:87)
at androidx.benchmark.perfetto.PerfettoCaptureWrapper$stop$1.invoke(PerfettoCaptureWrapper.kt:91)
at androidx.benchmark.perfetto.PerfettoCaptureWrapper$stop$1.invoke(PerfettoCaptureWrapper.kt:88)
at androidx.benchmark.Outputs.writeFile(Outputs.kt:136)
at androidx.benchmark.Outputs.writeFile$default(Outputs.kt:125)
at androidx.benchmark.perfetto.PerfettoCaptureWrapper.stop(PerfettoCaptureWrapper.kt:88)
at androidx.benchmark.perfetto.PerfettoCaptureWrapper.record(PerfettoCaptureWrapper.kt:145)
at androidx.benchmark.perfetto.PerfettoCaptureWrapper.record$default(PerfettoCaptureWrapper.kt:101)
at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:271)
at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:255)
at androidx.benchmark.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:108)
at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:255)
at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:438)
at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:107)
at com.meta.compose.macrobenchmark.scroll.HomeFeedScrollBenchmark.scroll(HomeFeedScrollBenchmark.kt:43)
at com.meta.compose.macrobenchmark.scroll.HomeFeedScrollBenchmark.noCompilation(HomeFeedScrollBenchmark.kt:35)

Issue 314931695

Description

Issue summary

Comments

ro...@gmail.com <ro...@gmail.com> #2Jan 31, 2024 07:05PM

cc...@google.com <cc...@google.com> Apr 26, 2024 08:41PM

ap...@google.com <ap...@google.com> #3Apr 26, 2024 09:23PM

pr...@google.com <pr...@google.com> #4May 14, 2024 05:22PM

Add comment

Issue metadata