java.lang.IllegalArgumentException: At least one result is necessary. [314931695]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Dec 5, 2023 12:33PM

Component used: Macrobenchmark 1.2.0-SNAPSHOT

Sometimes I get an exception probably that some metrics didn't provide the same results.

java.lang.IllegalArgumentException: At least one result is necessary.
at androidx.benchmark.MetricResult.<init>(MetricResult.kt:50)
at androidx.benchmark.MetricResult.<init>(MetricResult.kt:29)
at androidx.benchmark.macro.MetricResultExtensionsKt.mergeToSingleMetricResults(MetricResultExtensions.kt:138)
at androidx.benchmark.macro.MetricResultExtensionsKt.mergeMultiIterResults(MetricResultExtensions.kt:107)
at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:339)
at androidx.benchmark.macro.MacrobenchmarkKt$macrobenchmark$measurements$1.invoke(Macrobenchmark.kt:241)
at androidx.benchmark.perfetto.PerfettoTraceProcessor$Companion.runServer(PerfettoTraceProcessor.kt:105)
at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmark(Macrobenchmark.kt:241)
at androidx.benchmark.macro.MacrobenchmarkKt.macrobenchmarkWithStartupMode(Macrobenchmark.kt:422)
at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated(MacrobenchmarkRule.kt:107)
at androidx.benchmark.macro.junit4.MacrobenchmarkRule.measureRepeated$default(MacrobenchmarkRule.kt:97)

I think the minimal thing to improve is at least add information about the metric so you can investigate more why this happenned?

- require(size >= 1) { "At least one result is necessary." }
+ require(size >= 1) { "At least one result for $name is necessary." }

Comments

ro...@gmail.com <ro...@gmail.com> #2Jan 31, 2024 07:05PM

Comment has been deleted.

Message last modified on Jan 31, 2024 07:05PM

cc...@google.com <cc...@google.com> Apr 26, 2024 08:41PM

Accepted by cc...@google.com.

ap...@google.com <ap...@google.com> #3Apr 26, 2024 09:23PM

Marked as fixed.

androidx.customview would be a good candidate. This is used by all of the widget libraries.

pr...@google.com <pr...@google.com> #4May 14, 2024 05:22PM

Project: platform/frameworks/support
Branch: androidx-master-dev

commit 3ed3fb003fa6c1244f923202859a616225b5b2fa
Author: Ian Lake <ilake@google.com>
Date: Fri Feb 14 11:17:46 2020

Create an interface for layouts that can be opened

Create a common interface that represents layouts
that have two states: open and closed. This allows
higher level libraries to rely on the interface,
rather than concrete implementations such as
DrawerLayout, making them more resilient to
changes in the current recommended implementation.

Fixes: 129979320
Test: ./gradlew checkApi
Change-Id: I0f2a1414977825aa053c6555261f2b7d4417bd19

M customview/customview/api/1.1.0-alpha02.txt
M customview/customview/api/current.txt
M customview/customview/api/public_plus_experimental_1.1.0-alpha02.txt
M customview/customview/api/public_plus_experimental_current.txt
M customview/customview/api/restricted_1.1.0-alpha02.txt
M customview/customview/api/restricted_current.txt
A customview/customview/src/main/java/androidx/customview/widget/Openable.java
M drawerlayout/drawerlayout/api/1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/current.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/public_plus_experimental_current.txt
M drawerlayout/drawerlayout/api/restricted_1.1.0-alpha03.txt
M drawerlayout/drawerlayout/api/restricted_current.txt
M drawerlayout/drawerlayout/build.gradle
M drawerlayout/drawerlayout/src/main/java/androidx/drawerlayout/widget/DrawerLayout.java
M jetifier/jetifier/migration.config
M slidingpanelayout/slidingpanelayout/api/1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/current.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/public_plus_experimental_current.txt
M slidingpanelayout/slidingpanelayout/api/restricted_1.1.0-alpha01.txt
M slidingpanelayout/slidingpanelayout/api/restricted_current.txt
M slidingpanelayout/slidingpanelayout/src/main/java/androidx/slidingpanelayout/widget/SlidingPaneLayout.java

https://android-review.googlesource.com/940787

Issue 314931695

Description

Issue summary

Comments

ro...@gmail.com <ro...@gmail.com> #2Jan 31, 2024 07:05PM

cc...@google.com <cc...@google.com> Apr 26, 2024 08:41PM

ap...@google.com <ap...@google.com> #3Apr 26, 2024 09:23PM

pr...@google.com <pr...@google.com> #4May 14, 2024 05:22PM

Add comment

Issue metadata