Fixed
Status Update
Comments
mo...@google.com <mo...@google.com> #2
This is almost trivial to do. There is a generating script. Take a look at generateCollections.sh
. I'd recommend limiting it to DoubleList
and not adding any of the maps/sets for Double
. I mistakenly added Set
and Map
with Float
keys, but I recognize that those are likely a mistake.
Typically we don't have a strong need for Double
because Float
has sufficient precision. If you've found a need for a DoubleList, feel free to add it.
da...@google.com <da...@google.com> #3
Sounds good, I'll update DoubleList
and then wait for collection to be out of beta to further review and submit.
ap...@google.com <ap...@google.com> #4
Project: platform/frameworks/support
Branch: androidx-main
commit 2874e45e62d971a1b2a13a1071ea1f7bc6772d23
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Dec 06 09:49:56 2023
Add DoubleList optimized collections.
Bug: 315127635
Test: ./gradlew collection:collection:test
Relnote: "Add DoubleList, a List-like data structure optimized for Double values."
Change-Id: Ia10d192b1c24132272e7b005c10fea2446c9f933
M collection/collection/api/current.txt
M collection/collection/api/restricted_current.txt
A collection/collection/src/commonMain/kotlin/androidx/collection/DoubleList.kt
A collection/collection/src/commonMain/kotlin/androidx/collection/DoubleSet.kt
A collection/collection/src/commonTest/kotlin/androidx/collection/DoubleListTest.kt
M collection/collection/template/generateCollections.sh
https://android-review.googlesource.com/2862445
Branch: androidx-main
commit 2874e45e62d971a1b2a13a1071ea1f7bc6772d23
Author: Daniel Santiago Rivera <danysantiago@google.com>
Date: Wed Dec 06 09:49:56 2023
Add DoubleList optimized collections.
Bug: 315127635
Test: ./gradlew collection:collection:test
Relnote: "Add DoubleList, a List-like data structure optimized for Double values."
Change-Id: Ia10d192b1c24132272e7b005c10fea2446c9f933
M collection/collection/api/current.txt
M collection/collection/api/restricted_current.txt
A collection/collection/src/commonMain/kotlin/androidx/collection/DoubleList.kt
A collection/collection/src/commonMain/kotlin/androidx/collection/DoubleSet.kt
A collection/collection/src/commonTest/kotlin/androidx/collection/DoubleListTest.kt
M collection/collection/template/generateCollections.sh
da...@google.com <da...@google.com>
pr...@google.com <pr...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.collection:collection:1.5.0-alpha01
androidx.collection:collection-iosarm64:1.5.0-alpha01
androidx.collection:collection-iossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-iosx64:1.5.0-alpha01
androidx.collection:collection-jvm:1.5.0-alpha01
androidx.collection:collection-linuxarm64:1.5.0-alpha01
androidx.collection:collection-linuxx64:1.5.0-alpha01
androidx.collection:collection-macosarm64:1.5.0-alpha01
androidx.collection:collection-macosx64:1.5.0-alpha01
androidx.collection:collection-tvosarm64:1.5.0-alpha01
androidx.collection:collection-tvossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-tvosx64:1.5.0-alpha01
androidx.collection:collection-watchosarm32:1.5.0-alpha01
androidx.collection:collection-watchosarm64:1.5.0-alpha01
androidx.collection:collection-watchossimulatorarm64:1.5.0-alpha01
androidx.collection:collection-watchosx64:1.5.0-alpha01
Description
I updated the template to add `Double` and ran the script... Would efficient collections for `Double` be accepted as an API? Was there a reason `Double` is not part of the generated primitives list?
CL: aosp/2862445