R8 v8.2.33, "java.lang.VerifyError: Bad type on operand stack" runtime crash after upgrade [315186101]

Fixed

Bug

Status Update

No update yet.

Description

ma...@gmail.com

created issue #1

Dec 7, 2023 07:44AM

DESCRIBE THE ISSUE IN DETAIL: After upgrading R8 from 8.1.72 to 8.2.33 the app started to fail in runtime with

Error: Exception in thread "main" java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    org/intellij/markdown/parser/MarkdownParser.doParse(Lorg/intellij/markdown/MarkdownElementType;Ljava/lang/String;)Lorg/intellij/markdown/ast/ASTNodeImpl; @464: if_icmpne
  Reason:
    Type 'org/intellij/markdown/parser/markerblocks/MarkerBlock$ClosingAction$DEFAULT' (current frame, stack[1]) is not assignable to integer
  Current Frame:
    bci: @464
    flags: { }
    locals: { integer, top, top, top, 'org/intellij/markdown/flavours/gfm/GFMMarkerProcessor', top, top, integer, 'org/intellij/markdown/parser/markerblocks/MarkerBlockImpl', 'org/intellij/markdown/parser/markerblocks/MarkerBlock$ProcessingResult' }
    stack: { integer, 'org/intellij/markdown/parser/markerblocks/MarkerBlock$ClosingAction$DEFAULT' }
  Bytecode:
    0000000: bb00 1859 4e2a 2db7 0019 b400 12c0 001b
    0000010: b600 1f57 bb00 213a 04b2 0027 3a05 1904
    0000020: 2d19 05b7 002a b400 2e36 05bb 0030 592c
    0000030: b700 33b4 0037 3a06 1906 c604 292d 1906
    0000040: b400 40b5 002e 1906 b400 4302 a000 2dbb
    0000050: 0045 593a 0719 04b4 004b 1904 b400 4ec0
    0000060: 0050 1906 b600 5419 04b4 0058 b700 5b19
    0000070: 0419 07b5 005f a700 6719 04b4 005f b400
    0000080: 623a 0712 6419 07b8 006a 1906 b400 4319
    0000090: 0719 06b4 006e b800 74a0 0044 bb00 453a
    00000a0: 0719 04b4 005f b400 6259 3a08 c000 5019
    00000b0: 06b6 0077 593a 09c7 000d 1904 b400 5fb4
    00000c0: 0062 3a09 1907 1904 b400 583a 0a19 0819
    00000d0: 0919 0ab7 005b 1904 1907 b500 5f03 3607
    00000e0: 1906 b400 4019 04b4 007c a100 ff19 04b4
    00000f0: 0058 b600 8236 0715 079e 00ed 1507 0260
    0000100: 5936 0719 04b4 0058 b600 82a1 0006 a7ff
    0000110: e919 04b4 0058 1507 b600 86c0 0088 5959
    0000120: 3a08 1904 b400 5fb4 008b 3a09 b600 1f57
    0000130: 128c 1909 b800 6ab4 008f 5936 0a19 06b4
    0000140: 0040 5936 0b9f 0013 1908 b400 93c6 000b
    0000150: b200 983a 09a7 0051 150a 029f 0046 150a
    0000160: 150b a400 06a7 003c 150a 150b a200 1519
    0000170: 0819 06b6 009c 9a00 0bb2 009f 3a09 a700
    0000180: 2819 08b4 0093 593a 0ac6 000a 190a 3a09
    0000190: a700 1619 0819 0619 09b6 00a3 3a09 a700
    00001a0: 08b2 009f 3a09 1909 b200 9fb8 00a7 9900
    00001b0: 06a7 ff46 1909 59b4 00aa 3b19 0415 071a
    00001c0: b600 aeb4 00b1 5912 b35f b800 b9b2 00bf
    00001d0: a000 0819 08b6 00c2 1908 b600 c657 bb00
    00001e0: c859 b700 c9bf 0436 0719 04b4 005f b400
    00001f0: 8b3a 0812 6419 08b8 006a 1906 b400 4319
    0000200: 0819 06b4 006e b800 74a0 0141 1904 b400
    0000210: 58b8 00cf c000 8859 3a08 c600 0e19 08b6
    0000220: 00d3 9a00 06a7 0125 1904 b400 d73a 0812
    0000230: d819 08b8 006a 1906 b400 4302 a000 0d19
    0000240: 04b4 00dc 3a08 a700 bc19 04b4 005f b400
    0000250: 8b3a 0912 6419 09b8 006a 1906 b400 4319
    0000260: 0919 06b4 006e b800 74a0 00d6 1904 b400
    0000270: dfb6 00e3 3a09 1909 b900 e801 0099 0033
    0000280: 1909 b900 ec01 00c0 00ee 1904 b400 5f3a
    0000290: 0a19 0619 0819 0ab9 00f2 0400 593a 0ab9
    00002a0: 00f7 0100 0482 99ff d019 0a3a 08a7 0055
    00002b0: 1906 b400 4319 04b4 005f b400 6219 06b4
    00002c0: 006e b800 74a1 0038 1906 b600 fbc6 0030
    00002d0: bb00 fd59 1904 b400 5fb4 008b bb00 ff59
    00002e0: 1908 b701 0219 04b4 0106 b701 09b8 010f
    00002f0: 3a08 1301 1119 08b8 0114 a700 08b2 0119
    0000300: 3a08 1908 b901 1c01 003a 0819 08b9 00e8
    0000310: 0100 9900 3819 08b9 00ec 0100 c000 883a
    0000320: 0713 011e 1907 b800 6a19 04b4 0058 1907
    0000330: b601 2257 1904 b601 2504 3607 a7ff cfbb
    0000340: 0127 5913 0129 b701 2cbf 1507 9900 6c19
    0000350: 04b4 0058 b800 cfc0 0088 593a 07c6 0042
    0000360: 1907 b400 93c6 000f 1906 b400 4004 6036
    0000370: 07a7 0035 1907 b400 8f59 3608 029f 0018
    0000380: 1508 1906 b400 40a3 000e 1907 5919 06b6
    0000390: 0130 b500 8f19 07b4 008f 3607 a700 0a19
    00003a0: 06b6 0133 3607 1507 02a0 0008 1301 3436
    00003b0: 0719 0415 07b5 007c 1906 b400 4302 9f00
    00003c0: 2619 04b4 005f b400 8b3a 0712 6419 07b8
    00003d0: 006a 1906 b400 4319 0719 06b4 006e b800
    00003e0: 74a0 006c 1904 b400 5fb4 0062 1906 b400
    00003f0: 6eb8 0074 1906 b400 4359 3607 6459 3608
    0000400: 9e00 4d15 0702 9f00 3b19 04b4 005f b400
    0000410: 62c0 0050 b601 3719 04b4 004e c000 50b6
    0000420: 0137 a300 1f19 04b4 005f b400 623a 0719
    0000430: 04b4 00d7 3a09 1904 1906 1909 1907 b601
    0000440: 3b19 0615 08b6 013f 3a06 a7fb ee19 04b4
    0000450: 007c 1906 b400 4064 1906 5fb6 013f 3a06
    0000460: a7fb d82d 592c b601 42b5 002e b200 bf3a
    0000470: 0619 0402 1906 b600 aeb4 0145 bb01 4759
    0000480: bb01 4959 2b5f 1505 2db4 002e b701 4bb7
    0000490: 014e b601 2257 bb01 5059 4c2a 2cb7 0153
    00004a0: bb01 5559 2d5f 2bb7 0158 b401 45b6 015e
    00004b0: b0                                     
  Stackmap Table:
    full_frame(@56,{Object[#5],Object[#57],Object[#59],Object[#24],Object[#33],Integer,Object[#61]},{})
    same_frame_extended(@121)
    append_frame(@196,Uninitialized[#156],Object[#121],Object[#7])
    chop_frame(@221,3)
    append_frame(@247,Integer)
    same_frame(@273)
    full_frame(@344,{Object[#5],Object[#57],Object[#59],Object[#24],Object[#33],Integer,Object[#61],Integer,Object[#136],Object[#121],Integer,Integer},{})
    same_frame(@360)
    chop_frame(@385,2)
    same_frame(@403)
    chop_frame(@417,1)
    append_frame(@422,Object[#149])
    full_frame(@436,{Top,Top,Top,Top,Object[#33],Top,Top,Integer,Object[#136],Object[#149]},{})
    full_frame(@472,{Top,Top,Top,Top,Top,Top,Top,Top,Object[#136]},{})
    full_frame(@486,{Object[#5],Object[#57],Object[#59],Object[#24],Object[#33],Integer,Object[#61]},{})
    append_frame(@489,Integer)
    same_frame(@552)
    append_frame(@585,Object[#24])
    append_frame(@630,Object[#229])
    chop_frame(@688,1)
    chop_frame(@765,1)
    append_frame(@770,Object[#7])
    full_frame(@779,{Object[#5],Object[#57],Object[#59],Object[#24],Object[#33],Integer,Object[#61],Integer,Object[#229]},{})
    full_frame(@831,{},{})
    full_frame(@842,{Object[#5],Object[#57],Object[#59],Object[#24],Object[#33],Integer,Object[#61],Integer},{})
    full_frame(@884,{Object[#5],Object[#57],Object[#59],Object[#24],Object[#33],Integer,Object[#61],Object[#136]},{})
    same_frame(@917)
    chop_frame(@927,1)
    append_frame(@934,Integer)
    same_frame(@945)
    chop_frame(@952,1)
    same_frame(@996)
    append_frame(@1089,Top,Integer)
    chop_frame(@1101,2)
    chop_frame(@1123,1)

	at com.github.ajalt.mordant.markdown.Markdown.document(SourceFile:46)
	at com.github.ajalt.mordant.markdown.Markdown.measure(SourceFile:30)
	at com.github.ajalt.mordant.rendering.WidthRangeKt.maxWidthRange(SourceFile:24)
	at com.github.ajalt.mordant.widgets.DefinitionList.measure(SourceFile:19)
	at com.github.ajalt.mordant.rendering.WidthRangeKt.maxWidthRange(SourceFile:24)
	at com.github.ajalt.mordant.widgets.DefinitionList.render(SourceFile:19)
	at com.github.ajalt.mordant.table.VerticalLayout.render(SourceFile:68)
	at com.github.ajalt.mordant.terminal.Terminal.render(SourceFile:7)
	at com.jakewharton.diffuse.Diffuse.main(SourceFile:58)
Error: Process completed with exit code 1.

Related R8 setup:

configurations {
  r8
}

dependencies {
  r8 "com.android.tools:r8:8.2.33"
}

def r8JarProvider = tasks.register('r8Jar', JavaExec) { task ->
  task.javaLauncher.set(javaToolchains.launcherFor { spec ->
    spec.languageVersion.set(JavaLanguageVersion.of(JavaVersion.VERSION_17.majorVersion))
  })
  def fatJar = fatJarProvider.get()
  def fatJarFile = fatJar.archiveFile
  task.dependsOn(fatJar)
  task.inputs.file(fatJarFile)
  task.inputs.file(rulesFile)
  task.outputs.file(r8File)

  task.classpath(configurations.r8)
  task.mainClass.set('com.android.tools.r8.R8')
  task.args = [
    '--release',
    '--classfile',
    '--output', r8File.path,
    '--pg-conf', rulesFile.path,
    '--lib', System.getProperty('java.home').toString(),
    fatJarFile.get().toString(),
  ]
}

STEPS TO REPRODUCE:

Bump R8 dependency version

ATTACH SCREENSHOTS/RECORDINGS OF THE ISSUE
Renovate PR with the bump: https://github.com/usefulness/diffuse/pull/259

The pipeline builds the jar, and performs a smoke test java -jar {{outpu-r8-file.jar}}

ATTACH LOG FILES (Select Help > Show Log in Files, or Show Log in Finder on a Mac)

IMPORTANT: Please read https://developer.android.com/studio/report-bugs.html carefully and supply all required information.

Studio Build: Version of Gradle Plugin: Version of Gradle: Version of Java: OS:

Comments

rk...@google.com <rk...@google.com> Dec 7, 2023 06:51PM

Assigned to an...@google.com.

ch...@google.com <ch...@google.com> #2Dec 7, 2023 06:58PM

Reassigned to cl...@google.com.

This looks like a bug in enum unboxing.

Until a fix is in place I believe you should be able to workaround this issue with the following rule:

-keep,allowobfuscation,allowshrinking class org.intellij.markdown.parser.markerblocks.MarkerBlock$ClosingAction

ma...@gmail.com <ma...@gmail.com> #3Dec 7, 2023 07:36PM

Thanks for acknowledgement, I confirm the workaround does work. However, just in case that's unexpected, I'll note the new R8 version (with the workaround) produces larger output file (+10 KB on a 4MB jar)

cl...@google.com <cl...@google.com> #4Dec 8, 2023 12:59PM

The issue is that now we unbox enum with subtypes and the kotlin enum subclasses in this program are not marked with the enum flag.

I'll make a fix.

ap...@google.com <ap...@google.com> #5Dec 11, 2023 01:30PM

Project: r8
Branch: main

commit f6a533d424161b8b606a6e54e01582005dda7766
Author: Clément Béra <clementbera@google.com>
Date: Mon Dec 11 14:19:22 2023

Allow enums with subtypes without enum flag to be unboxed

Bug:

b/315186101

Change-Id: I98d002594af56c2f63e953d1236652f3d3c882f8

M src/main/java/com/android/tools/r8/graph/ClassAccessFlags.java
M src/main/java/com/android/tools/r8/graph/ObjectAllocationInfoCollectionImpl.java
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxerImpl.java
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxingCandidateAnalysis.java
M src/main/java/com/android/tools/r8/ir/optimize/enums/EnumUnboxingCandidateInfoCollection.java
M src/main/java/com/android/tools/r8/ir/optimize/enums/eligibility/Reason.java
M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/enumunboxing/enummerging/BasicEnumMergingKeepSubtypeTest.java
A src/test/java/com/android/tools/r8/enumunboxing/enummerging/NoEnumFlagEnumMergingTest.java

https://r8-review.googlesource.com/86980

cl...@google.com <cl...@google.com> #6Dec 12, 2023 08:02AM

We need to try to backport this at least 1 version back.

ap...@google.com <ap...@google.com> #7Dec 12, 2023 09:57AM

Project: r8
Branch: 8.2

commit 9bab7deb172bec5b51e3ef29724cca7cc83ee965
Author: Clément Béra <clementbera@google.com>
Date: Tue Dec 12 10:16:41 2023

Version 8.2.40

Bug:

b/315186101

Change-Id: I8de6a9af3eed89ea863d572ad9cee2b807503ff7

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/87041

ap...@google.com <ap...@google.com> #8Dec 12, 2023 09:57AM

Project: r8
Branch: 8.2

commit 31f36bdc54e066646651ca92d89e429d252fa728
Author: Clément Béra <clementbera@google.com>
Date: Tue Dec 12 09:59:19 2023

Allow enums with subtypes without enum flag to be unboxed

Bug:

b/315186101

https://r8-review.googlesource.com/87023

ap...@google.com <ap...@google.com> #9Dec 13, 2023 09:01AM

Project: r8
Branch: 8.3

commit 5392459e3e3c4a4bfe43afd702a0182f249901a4
Author: Clément Béra <clementbera@google.com>
Date: Wed Dec 13 09:30:46 2023

Allow enums with subtypes without enum flag to be unboxed

Bug:

b/315186101

https://r8-review.googlesource.com/87103

ap...@google.com <ap...@google.com> #10Dec 13, 2023 09:01AM

Project: r8
Branch: 8.3

commit ca1afe08bce1905c1dec94797333c7ebd8fb6c16
Author: Clément Béra <clementbera@google.com>
Date: Wed Dec 13 09:33:05 2023

Version 8.3.22

Bug:

b/315186101

Change-Id: I9175972e305acc6e603b52b3c469c00fe225c645

M src/main/java/com/android/tools/r8/Version.java

https://r8-review.googlesource.com/87104

cl...@google.com <cl...@google.com> #11Dec 13, 2023 01:39PM

Marked as fixed.

Should be fixed with 8.2.40 for the reporter. Closing the issue.

an...@google.com <an...@google.com> #12Dec 26, 2023 06:01PM

Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:

Android Studio Iguana | 2023.2.1 Beta 1
Android Gradle Plugin 8.3.0-beta01

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

Thank you for taking the time to submit feedback — we really appreciate it!

ah...@gmail.com <ah...@gmail.com> #13Dec 28, 2023 03:31AM

NetworkModule.kt https://github.com/usefulness/diffuse/pull/259” ma...@ #1 “ https://developer.android.com/studio/report-bugs.html ” ma...@ #1 “ does work ” ma...@ #3 “ https://r8-review.googlesource.com/86980 ” ap...@ #5 “ https://r8-review.googlesource.com/87041 ” ap...@ #7 “ https://r8-review.googlesource.com/87023 ” ap...@ #8 “ https://r8-review.googlesource.com/87103 ” ap...@ #9 “ https://r8-review.googlesource.com/87104 ” ap...@ #10

an...@google.com <an...@google.com> #14Jan 3, 2024 06:01PM

The fixes for this issue are now also available in:

Android Studio Hedgehog | 2023.1.1 Patch 1
Android Gradle Plugin 8.2.1

We encourage you to try the latest update.

If you notice further issues or have questions, please file a new bug report.

ma...@gmail.com <ma...@gmail.com> #15Jan 8, 2024 05:45PM

8.2.44 got published on google maven today. I confirm it has the issue fixed, thank you 🙏

edit: to not trigger unnecessary notifications, the project I linked in the first post uses R8 directly (without AGP presence at all), so this was the first moment I was able to test it :) Thanks again!

Message last modified on Jan 8, 2024 06:08PM

sg...@google.com <sg...@google.com> #16Jan 8, 2024 05:54PM

FYI, R8 8.2.44 is the version bundled with AGP 8.2.1.

fe...@gmail.com <fe...@gmail.com> #17Jan 17, 2024 07:17PM

Fetamohamed46@gmail.com

Issue 315186101

Description

Issue summary

Comments

rk...@google.com <rk...@google.com> Dec 7, 2023 06:51PM

ch...@google.com <ch...@google.com> #2Dec 7, 2023 06:58PM

ma...@gmail.com <ma...@gmail.com> #3Dec 7, 2023 07:36PM

cl...@google.com <cl...@google.com> #4Dec 8, 2023 12:59PM

ap...@google.com <ap...@google.com> #5Dec 11, 2023 01:30PM

cl...@google.com <cl...@google.com> #6Dec 12, 2023 08:02AM

ap...@google.com <ap...@google.com> #7Dec 12, 2023 09:57AM

ap...@google.com <ap...@google.com> #8Dec 12, 2023 09:57AM

ap...@google.com <ap...@google.com> #9Dec 13, 2023 09:01AM

ap...@google.com <ap...@google.com> #10Dec 13, 2023 09:01AM

cl...@google.com <cl...@google.com> #11Dec 13, 2023 01:39PM

an...@google.com <an...@google.com> #12Dec 26, 2023 06:01PM

ah...@gmail.com <ah...@gmail.com> #13Dec 28, 2023 03:31AM

an...@google.com <an...@google.com> #14Jan 3, 2024 06:01PM

ma...@gmail.com <ma...@gmail.com> #15Jan 8, 2024 05:45PM

sg...@google.com <sg...@google.com> #16Jan 8, 2024 05:54PM

fe...@gmail.com <fe...@gmail.com> #17Jan 17, 2024 07:17PM

Add comment

Issue metadata