Status Update
No update yet.
Comments
ap...@google.com
It's failing when accessing androidx.navigation.compose.BackStackEntryIdViewModel
ap...@google.com
Reproducible with navigation-compose:2.4.0-beta02, without hilt.
ap...@google.com
Could be related to this change
api("androidx.navigation:navigation-runtime:2.4.0-alpha10")
ap...@google.com
See also these relevant tickets:
so it appears this is not a Wear Compose specific issue.
ap...@google.com
Further info - if we revert the change mentioned in
ap...@google.com
Calling LocalOwnersProvider on a NavBackStackEntry that has either never been created (unlikely, given that a NavBackStackEntry is moved to CREATED before it is given to any Navigator) or that has already been moved to destroyed (most likely) is indicative of a problem in SwipeDismissableNavHost and how it handles onTransitionComplete() - you should only be marking a transition as complete after that / synchronized with the removal of that destination from your composable hierarchy - thus ensuring that LocalOwnersProvider won't be called on that particular NavBackStackEntry ever again.
NavHost does not run into this issue as it does handle transitions correctly, so this certainly seems to be something specific with SwipeDismissableNavHost.
ap...@google.com
Branch: androidx-main
commit 4a229ca6ef4cef2d5679334737290d71fe027d7b
Author: stevebower <stevebower@google.com>
Date: Wed Dec 01 13:04:01 2021
Do not show navigation content until Lifecycle state CREATED.
aosp/1871175 changed lifecycle state handling so that a
NavBackStackEntry starts in state INITIALIZED. Given that
WearNavigator pushes destinations without transitions,
SwipeDismissableNavHost must no longer show content until the
entry has reached at least state CREATED. Fixing this allows
us to build against latest navigation libraries.
Test: androidx.wear.compose.navigation
Bug: 207328687
Relnote: "Fixed an issue where NavBackStackEntry has lifecycle
state INITIALIZED and should not be shown until it has
lifecycle state CREATED."
Change-Id: I40a2ba51ec8805007dd11f531a5807e60f595a0d
M wear/compose/compose-navigation/build.gradle
M wear/compose/compose-navigation/src/main/java/androidx/wear/compose/navigation/SwipeDismissableNavHost.kt
ap...@google.com
Which version is this fixed in? It seemed to still happen with 1.0.0-Alpha12, but maybe I missed something else. Can reconfirm if it's meant to be already fixed in released alphas.
ap...@google.com
The fix was submitted after the 1.0.0-Alpha12 release - should be available as a SNAPSHOT build.
ap...@google.com
Branch: androidx-main
commit cd3d5e2927d3d3f5acdc9951b53d7959cff3c3be
Author: Clara Fok <clarafok@google.com>
Date: Thu Jan 18 11:34:30 2024
Re-add LoadStateUpdate yield and additional tests
PagingDataPresenter needed to yield on LoadStateUpdates in case RecyclerView was undergoing dispatch layouts. Otherwise, LoadStateUpdates pushed to LoadState-based RV will crash. See original
Added tests to assert that LoadStateUpdate yields to RecyclerView when it is dispatching layout.
Test: ./gradlew paging:paging-runtime:cC
Bug: 150162465
Bug: 315214786
Change-Id: I1df8b730bdf52b146a36a8c85792cb6ce62e8aca
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-runtime/build.gradle
M paging/paging-runtime/src/androidTest/java/androidx/paging/AsyncPagingDataDifferTest.kt
ap...@google.com
Branch: androidx-main
commit b7393370d402b1380be68b55549cb752842162b8
Author: Clara Fok <clarafok@google.com>
Date: Fri Jan 19 13:08:39 2024
Make PagingDataPresenter public
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:test
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:cC
Bug: 315214786
Relnote: "PagingDataPresenter is now a public class. Multiplatform presenters can now be built on top of PagingDataPresenter."
Change-Id: Id1f748af435e6f5d733bc731ef7e8cd12455845a
M paging/paging-common/api/current.txt
M paging/paging-common/api/restricted_current.txt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PlaceholderPaddedList.kt
ap...@google.com
Branch: androidx-main
commit 15804fb6a1c1805305e66d23fc4c5a30cbc28d40
Author: Clara Fok <clarafok@google.com>
Date: Fri Jan 19 13:00:51 2024
Rename NullPaddedList to PlaceholderPaddedList
Test: ANDROIDX_PROJECTS=INFRAROGUE ./gradlew paging:paging-common:allTest
Bug: 315214786
Change-Id: Id699b61a98e81e59c11b78f4d07315717324e33b
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedList.kt
M paging/paging-common/src/commonJvmAndroidMain/kotlin/androidx/paging/PagedStorage.jvm.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PageStore.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataEvent.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PlaceholderPaddedList.kt
M paging/paging-common/src/commonTest/kotlin/androidx/paging/PagingDataPresenterTest.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/PlaceholderPaddedListDiffHelperTest.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/PlaceholderPaddedListDiffWithRecyclerViewTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagedListDiffer.kt
M paging/paging-runtime/src/main/java/androidx/paging/PlaceholderPaddedDiffing.md
M paging/paging-runtime/src/main/java/androidx/paging/PlaceholderPaddedListDiffHelper.kt
M paging/paging-testing/src/commonMain/kotlin/androidx/paging/testing/SnapshotLoader.kt
ap...@google.com
Branch: androidx-main
commit 5c76ff18b0b1f721005807586b1bf136b954f856
Author: Clara Fok <clarafok@google.com>
Date: Thu Jan 18 16:49:49 2024
AsyncPagingDataDiffer LoadState emission to yield if getting item
Paging has existing logic to track if RecyclerView is running layouts and if so, yield before processing PageEvents. This was done by making PagingDataPresenter.collectFrom() yield on main dispatcher before processing Inserts, Drops, and LoadStateUpdates. See
As we move all RV logic out of PagingDataPresenter, we now throttle LoadStateUpdate emissions in AsyncPagingDataDiffer instead. This provides the guarantee that PagingDataAdapter and other RecyclerView.Adapters built on top of AsyncPagingDataDiffer can collect on LoadStateUpdates without crashing RV.
Test: paging.integration-tests.testapp does not crash when displaying header/footers for loadStates
Test: ./gradlew paging:paging-runtime:cC
Bug: 315214786
Change-Id: I7b9be5fc3d0a85a0ff2b3f7671f78626f74a80a1
M paging/paging-common/src/commonMain/kotlin/androidx/paging/PagingDataPresenter.kt
M paging/paging-runtime/src/androidTest/java/androidx/paging/AsyncPagingDataDifferTest.kt
M paging/paging-runtime/src/main/java/androidx/paging/AsyncPagingDataDiffer.kt
Description
Since we only implement the front end for Android, users of paging KMP will need their own custom front end built on top of paging-common for non-Android platforms. Therefore, we should open up paging-common so that external users of Paging KMP can implement their own Paging front end.