Fixed
Status Update
No update yet.
Comments
da...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
https://android-review.googlesource.com/1123258
https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1
Branch: androidx-master-dev
commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019
Change the way to detect mismatch between POJO and query
This fixes cursor mismatch warnings with expandProjection.
Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt
da...@google.com
da...@google.com
Project: platform/frameworks/support
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
https://android-review.googlesource.com/1288456
Branch: androidx-master-dev
commit bdde5a1a970ddc9007b28de4aa29d60ffa588f08
Author: Yigit Boyar <yboyar@google.com>
Date: Thu Apr 16 16:47:05 2020
Re-factor how errors are dismissed when query is re-written
This CL changes how we handle errors/warnings if query is
re-written.
There was a bug in expandProjection where we would report warnings
for things that Room already fixes automatically (
The solution to that problem (I7659002e5e0d1ef60fc1af2a625c0c36da0664d8)
solved it by deferring validating of columns until after re-write
decision is made. Unfortunately, this required changing PojoRowAdapter
to have a dummy mapping until it is validating, make it hard to use
as it does have a non-null mapping which is not useful.
This CL partially reverts that change and instead rely on the log
deferring logic we have in Context. This way, we don't need to break
the stability of PojoRowAdapter while still having the ability to
drop warnings that room fixes. This will also play nicer when we
have different query re-writing options that can use more information
about the query results.
Bug: 153387066
Bug: 140759491
Test: existing tests pass
Change-Id: I2ec967c763d33d7a3ff02c1a13c6953b460d1e5f
M room/compiler/src/main/kotlin/androidx/room/log/RLog.kt
M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Make androidx.room and androidx.sqlite target Kotlin 2.0
Expand for full commit details
Make androidx.room and androidx.sqlite target Kotlin 2.0
This required the following changes:
* Suppress 'ACTUAL_ANNOTATIONS_NOT_MATCH_EXPECT' in SQLiteException.android.kt and ThreadLocal.jvmAndroid.kt due to being impossible to match annotations in expect when actual is a typealias to a platform type. Meanwhile in room-common repeatable annotations in JVM use @JvmRepeatable while expect uses Kotlin's @Repeatable and while trying to match actual with expect, an error is produced due to @JvmRepeatable and @Repeatable being used together.
* Fix various annotations mismatch between actual / expect.
* Removing @JvmField from common code as expect properties have no backing field and @JvmField targets FIELD.
* Smart-cast is not possible for expect properties, therefore first store in local variable before smart-case usage. Observed in TableInfo, FtsTableInfo, ViewInfo and MigrationUtil.
* Adding load() and getRefreshKey() to expect LimitOffsetPagingSource to conform to modality of actual overriding those functions.
* Make a XProcessingEnvConfig a normal class (instead of a data class) since it has a private constructor with a public copy() usage which is now invalid.
* Set useKsp2=true on projects with KSP and Kotlin language 2.0 (Room KMP test apps).
* Workaround KSP2 issue with default value of annotations not appearing in value list. Added a get() that returns nullable XAnnotationValue.
* Workaround KSP2 issue of projecting value class constructor as member of (to support generics).
* Workaround XPoet creating JavaPoet types of invalid methods (internal) when XProcessingEnvConfig.excludeMethodsWithInvalidJvmSourceNames is set to true due to Kotlin codegen.
Bug: 315461431
Bug: 384600605
Test: Existing
Relnote: "Native APIs updated due to Kotlin 2.0"
Change-Id: I8efb015c88682921780370c8bed5931d9933a319
Files:
- M
development/build_log_simplifier/messages.ignore - M
room/integration-tests/kotlintestapp/build.gradle - M
room/integration-tests/multiplatformtestapp/build.gradle - M
room/room-common/bcv/native/current.txt - M
room/room-common/build.gradle - M
room/room-common/src/jvmMain/kotlin/androidx/room/DeleteColumn.jvm.kt - M
room/room-common/src/jvmMain/kotlin/androidx/room/DeleteTable.jvm.kt - M
room/room-common/src/jvmMain/kotlin/androidx/room/RenameColumn.jvm.kt - M
room/room-common/src/jvmMain/kotlin/androidx/room/RenameTable.jvm.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/InternalXAnnotation.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/JavaPoetExt.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/XAnnotation.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/XProcessingEnvConfig.kt - M
room/room-compiler-processing/src/main/java/androidx/room/compiler/processing/util/NamingUtils.kt - M
room/room-compiler-processing/src/test/java/androidx/room/compiler/processing/XAnnotationTest.kt - M
room/room-compiler/build.gradle - M
room/room-compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt - M
room/room-compiler/src/main/kotlin/androidx/room/solver/query/result/MultimapQueryResultAdapter.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/BaseDaoKotlinCodeGenTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DaoKotlinCodeGenTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DaoRelationshipKotlinCodeGenTest.kt - M
room/room-compiler/src/test/kotlin/androidx/room/writer/DatabaseKotlinCodeGenTest.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_daoProperty.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_internalVisibility.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_javaSource.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_simple.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/database_withFtsAndView.kt - M
room/room-compiler/src/test/test-data/kotlinCodeGen/guavaCallable_java.kt - M
room/room-ktx/build.gradle - M
room/room-migration/build.gradle - M
room/room-paging-guava/build.gradle - M
room/room-paging-rxjava2/build.gradle - M
room/room-paging-rxjava3/build.gradle - M
room/room-paging/build.gradle - M
room/room-paging/src/androidMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.android.kt - M
room/room-paging/src/commonMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.kt - M
room/room-paging/src/jvmNativeMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.jvmNative.kt - M
room/room-runtime/bcv/native/current.txt - M
room/room-runtime/build.gradle - M
room/room-runtime/src/commonMain/kotlin/androidx/room/RoomConnectionManager.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/FtsTableInfo.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/MigrationUtil.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/TableInfo.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/ViewInfo.kt - M
room/room-runtime/src/jvmAndroidMain/kotlin/androidx/room/concurrent/ThreadLocal.jvmAndroid.kt - M
room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/InvalidationTracker.jvmNative.kt - M
room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/util/TableInfo.jvmNative.kt - M
room/room-runtime/src/jvmNativeMain/kotlin/androidx/room/util/ViewInfo.jvmNative.kt - M
room/room-runtime/src/nativeMain/kotlin/androidx/room/concurrent/ThreadLocal.native.kt - M
room/room-rxjava2/build.gradle - M
room/room-rxjava3/build.gradle - M
room/room-testing/build.gradle - M
sqlite/sqlite-bundled/build.gradle - M
sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteConnection.kt - M
sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteDriver.kt - M
sqlite/sqlite-bundled/src/commonMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLiteStatement.kt - M
sqlite/sqlite-bundled/src/jvmAndroidMain/kotlin/androidx/sqlite/driver/bundled/BundledSQLite.jvmAndroid.kt - M
sqlite/sqlite-framework/build.gradle - M
sqlite/sqlite-ktx/build.gradle - M
sqlite/sqlite/build.gradle - M
sqlite/sqlite/src/androidMain/kotlin/androidx/sqlite/SQLiteException.android.kt - M
sqlite/sqlite/src/androidUnitTest/kotlin/androidx/sqlite/db/SimpleSQLiteQueryTest.kt
Hash: 6e1e6e154483b9346ffc27a0e57d14bd20f4359f
Date: Mon Dec 16 22:13:20 2024
ap...@google.com
Project: platform/frameworks/support
Branch: androidx-main
Author: Daniel Santiago Rivera <
Link:
Migrate androidx.sqlite to use KMP AutoCloseable
Expand for full commit details
Migrate androidx.sqlite to use KMP AutoCloseable
AutoCloseable common was added in Kotlin 2.0
Bug: 315461431
Test: Existing
Relnote: Migrate androidx.sqlite.use to Kotlin's AutoCloseable's use in the stdlib.
Change-Id: I470f02620d43bbe641c58e3fc3637119e8c44532
Files:
- M
room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseAutoMigrationTest.kt - M
room/integration-tests/multiplatformtestapp/src/commonTest/kotlin/androidx/room/integration/multiplatformtestapp/test/BaseMigrationTest.kt - M
room/room-paging/src/androidInstrumentedTest/kotlin/androidx/room/paging/LimitOffsetPagingSourceTest.kt - M
room/room-paging/src/androidMain/kotlin/androidx/room/paging/LimitOffsetPagingSource.android.kt - M
room/room-runtime/src/androidMain/kotlin/androidx/room/coroutines/AndroidSQLiteDriverConnectionPool.android.kt - M
room/room-runtime/src/androidMain/kotlin/androidx/room/driver/SupportSQLiteConnectionPool.android.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/EntityDeleteOrUpdateAdapter.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/EntityInsertAdapter.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/InvalidationTracker.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/RoomConnectionManager.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/coroutines/ConnectionPoolImpl.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/ConnectionUtil.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/DBUtil.kt - M
room/room-runtime/src/commonMain/kotlin/androidx/room/util/SchemaInfoUtil.kt - M
room/room-runtime/src/commonTest/kotlin/androidx/room/coroutines/BaseConnectionPoolTest.kt - M
room/room-testing/src/commonMain/kotlin/androidx/room/testing/MigrationTestHelper.kt - M
sqlite/integration-tests/driver-conformance-test/build.gradle - M
sqlite/integration-tests/driver-conformance-test/src/commonTest/kotlin/androidx/sqlite/driver/test/BaseBundledConformanceTest.kt - M
sqlite/integration-tests/driver-conformance-test/src/commonTest/kotlin/androidx/sqlite/driver/test/BaseConformanceTest.kt - M
sqlite/sqlite/api/current.txt - M
sqlite/sqlite/api/restricted_current.txt - M
sqlite/sqlite/bcv/native/current.txt - M
sqlite/sqlite/src/commonMain/kotlin/androidx/sqlite/SQLite.kt - M
sqlite/sqlite/src/commonMain/kotlin/androidx/sqlite/SQLiteConnection.kt - M
sqlite/sqlite/src/commonMain/kotlin/androidx/sqlite/SQLiteStatement.kt
Hash: 62cf305b742fc901c10da7d435f77d2a38f9d67e
Date: Mon Dec 16 11:39:49 2024
da...@google.com
na...@google.com
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.room:room-common:2.7.0-alpha13androidx.room:room-common-iosarm64:2.7.0-alpha13androidx.room:room-common-iossimulatorarm64:2.7.0-alpha13androidx.room:room-common-iosx64:2.7.0-alpha13androidx.room:room-common-jvm:2.7.0-alpha13androidx.room:room-common-linuxarm64:2.7.0-alpha13androidx.room:room-common-linuxx64:2.7.0-alpha13androidx.room:room-common-macosarm64:2.7.0-alpha13androidx.room:room-common-macosx64:2.7.0-alpha13androidx.room:room-compiler:2.7.0-alpha13androidx.room:room-compiler-processing:2.7.0-alpha13androidx.room:room-ktx:2.7.0-alpha13androidx.room:room-migration:2.7.0-alpha13androidx.room:room-migration-iosarm64:2.7.0-alpha13androidx.room:room-migration-iossimulatorarm64:2.7.0-alpha13androidx.room:room-migration-iosx64:2.7.0-alpha13androidx.room:room-migration-jvm:2.7.0-alpha13androidx.room:room-migration-linuxarm64:2.7.0-alpha13androidx.room:room-migration-linuxx64:2.7.0-alpha13androidx.room:room-migration-macosarm64:2.7.0-alpha13androidx.room:room-migration-macosx64:2.7.0-alpha13androidx.room:room-paging:2.7.0-alpha13androidx.room:room-paging-android:2.7.0-alpha13androidx.room:room-paging-guava:2.7.0-alpha13androidx.room:room-paging-iosarm64:2.7.0-alpha13androidx.room:room-paging-iossimulatorarm64:2.7.0-alpha13androidx.room:room-paging-iosx64:2.7.0-alpha13androidx.room:room-paging-jvm:2.7.0-alpha13androidx.room:room-paging-linuxarm64:2.7.0-alpha13androidx.room:room-paging-linuxx64:2.7.0-alpha13androidx.room:room-paging-macosarm64:2.7.0-alpha13androidx.room:room-paging-macosx64:2.7.0-alpha13androidx.room:room-paging-rxjava2:2.7.0-alpha13androidx.room:room-paging-rxjava3:2.7.0-alpha13androidx.room:room-runtime:2.7.0-alpha13androidx.room:room-runtime-android:2.7.0-alpha13androidx.room:room-runtime-iosarm64:2.7.0-alpha13androidx.room:room-runtime-iossimulatorarm64:2.7.0-alpha13androidx.room:room-runtime-iosx64:2.7.0-alpha13androidx.room:room-runtime-jvm:2.7.0-alpha13androidx.room:room-runtime-linuxarm64:2.7.0-alpha13androidx.room:room-runtime-linuxx64:2.7.0-alpha13androidx.room:room-runtime-macosarm64:2.7.0-alpha13androidx.room:room-runtime-macosx64:2.7.0-alpha13androidx.room:room-rxjava2:2.7.0-alpha13androidx.room:room-rxjava3:2.7.0-alpha13androidx.room:room-testing:2.7.0-alpha13androidx.room:room-testing-android:2.7.0-alpha13androidx.room:room-testing-iosarm64:2.7.0-alpha13androidx.room:room-testing-iossimulatorarm64:2.7.0-alpha13androidx.room:room-testing-iosx64:2.7.0-alpha13androidx.room:room-testing-jvm:2.7.0-alpha13androidx.room:room-testing-linuxarm64:2.7.0-alpha13androidx.room:room-testing-linuxx64:2.7.0-alpha13androidx.room:room-testing-macosarm64:2.7.0-alpha13androidx.room:room-testing-macosx64:2.7.0-alpha13androidx.sqlite:sqlite:2.5.0-alpha13androidx.sqlite:sqlite-android:2.5.0-alpha13androidx.sqlite:sqlite-bundled:2.5.0-alpha13androidx.sqlite:sqlite-bundled-android:2.5.0-alpha13androidx.sqlite:sqlite-bundled-iosarm64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-iossimulatorarm64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-iosx64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-jvm:2.5.0-alpha13androidx.sqlite:sqlite-bundled-linuxarm64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-linuxx64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-macosarm64:2.5.0-alpha13androidx.sqlite:sqlite-bundled-macosx64:2.5.0-alpha13androidx.sqlite:sqlite-framework:2.5.0-alpha13androidx.sqlite:sqlite-framework-android:2.5.0-alpha13androidx.sqlite:sqlite-framework-iosarm64:2.5.0-alpha13androidx.sqlite:sqlite-framework-iossimulatorarm64:2.5.0-alpha13androidx.sqlite:sqlite-framework-iosx64:2.5.0-alpha13androidx.sqlite:sqlite-framework-linuxarm64:2.5.0-alpha13androidx.sqlite:sqlite-framework-linuxx64:2.5.0-alpha13androidx.sqlite:sqlite-framework-macosarm64:2.5.0-alpha13androidx.sqlite:sqlite-framework-macosx64:2.5.0-alpha13androidx.sqlite:sqlite-iosarm64:2.5.0-alpha13androidx.sqlite:sqlite-iossimulatorarm64:2.5.0-alpha13androidx.sqlite:sqlite-iosx64:2.5.0-alpha13androidx.sqlite:sqlite-jvm:2.5.0-alpha13androidx.sqlite:sqlite-ktx:2.5.0-alpha13androidx.sqlite:sqlite-linuxarm64:2.5.0-alpha13androidx.sqlite:sqlite-linuxx64:2.5.0-alpha13androidx.sqlite:sqlite-macosarm64:2.5.0-alpha13androidx.sqlite:sqlite-macosx64:2.5.0-alpha13
Description
API checks and Java ecosystem recommends SQLiteConnection and SQLiteStatement to implement Closeable / AutoCloseable but there is no KMP common Closeable interface. Other art work has defined a expect Closeable in commonMain and have actual typealias to Java's interface and implemented utility function in native.
It would be also nice if we can add finalizers to close things and warn about leaks. JVM and Android has finalizer APIs (https://docs.oracle.com/javase/9/docs/api/java/lang/ref/Cleaner.html ) along with the soon-to-be-deprecated https://kotlinlang.org/docs/java-interop.html#finalize ) and in iOS there is https://kotlinlang.org/docs/native-ios-integration.html#deinitializers ). But I don't think there is anything available for native...
finalize()(deinit(