TraceSectionMetric label parameter should be after mode [315830077]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Dec 11, 2023 07:39PM

Component used: Macrobench 1.3.0-SNAPSHOT

Sorry, should've found this in the aosp/2853596 .

I think the label param should be after the mode param, because it forces using mode with named argument, or needs to be defined.

// works
TraceSectionMetric("Jit Compiling %")
TraceSectionMetric("Jit Compiling %", "jit_compiling"),
TraceSectionMetric("Jit Compiling %", "jit_compiling", Mode.Sum),

// doesn't work
TraceSectionMetric("installApk%", Mode.First)

// works, but requires named args
TraceSectionMetric("installApk%", mode=Mode.First, targetPackageOnly=false)

I suggest putting the label as the last argument, because it's the least likely to be defined.

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2024 09:24PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 3283536a57f7caf087786f6030f6bf246489df85
Author: Chris Craik <ccraik@google.com>
Date: Fri Feb 02 16:27:30 2024

Speculative fix for Failed to stop [ProcessPid(processName=perfetto...

Bug: 323601788
Bug: 307649002
Relnote: "Adjusted data source timeouts to attempt to fix java.lang.IllegalStateException: Failed to stop [ProcessPid(processName=perfetto, pid=...)]"

Test: ./gradlew bench:b-m:cC
Change-Id: I8dc7d5091ea1a8e68cb5effb21363f1c3196cf56

M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoConfig.kt
M benchmark/benchmark-common/src/main/java/androidx/benchmark/perfetto/PerfettoHelper.kt

https://android-review.googlesource.com/2947370

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

This is expected to be fixed with the change above, which made it into 1.3.0-alpha01.

Please let us know if you still see this issue after updating to that version

Issue 315830077

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2024 09:24PM

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

Add comment

Issue metadata