TraceSectionMetric label parameter should be after mode [315830077]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Dec 11, 2023 07:39PM

Component used: Macrobench 1.3.0-SNAPSHOT

Sorry, should've found this in the aosp/2853596 .

I think the label param should be after the mode param, because it forces using mode with named argument, or needs to be defined.

// works
TraceSectionMetric("Jit Compiling %")
TraceSectionMetric("Jit Compiling %", "jit_compiling"),
TraceSectionMetric("Jit Compiling %", "jit_compiling", Mode.Sum),

// doesn't work
TraceSectionMetric("installApk%", Mode.First)

// works, but requires named args
TraceSectionMetric("installApk%", mode=Mode.First, targetPackageOnly=false)

I suggest putting the label as the last argument, because it's the least likely to be defined.

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2024 09:24PM

Marked as fixed.

Any suggestions on where such an interface might live? I don't think it makes sense for the interface to be in the drawerlayout artifact if you're specifically going to use the interface to *not* use DrawerLayout.

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

androidx.customview would be a good candidate. This is used by all of the widget libraries.

Issue 315830077

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2024 09:24PM

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

Add comment

Issue metadata