TraceSectionMetric label parameter should be after mode [315830077]

Fixed

Feature Request

Status Update

No update yet.

Description

ml...@google.com

created issue #1

Dec 11, 2023 07:39PM

Component used: Macrobench 1.3.0-SNAPSHOT

Sorry, should've found this in the aosp/2853596 .

I think the label param should be after the mode param, because it forces using mode with named argument, or needs to be defined.

// works
TraceSectionMetric("Jit Compiling %")
TraceSectionMetric("Jit Compiling %", "jit_compiling"),
TraceSectionMetric("Jit Compiling %", "jit_compiling", Mode.Sum),

// doesn't work
TraceSectionMetric("installApk%", Mode.First)

// works, but requires named args
TraceSectionMetric("installApk%", mode=Mode.First, targetPackageOnly=false)

I suggest putting the label as the last argument, because it's the least likely to be defined.

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2024 09:24PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit b90079595f33f58fece04026a97faa0d243acdb1
Author: Yuichi Araki <yaraki@google.com>
Date: Wed Sep 18 16:55:49 2019

Change the way to detect mismatch between POJO and query

This fixes cursor mismatch warnings with expandProjection.

Bug: 140759491
Test: QueryMethodProcessorTest
Change-Id: I7659002e5e0d1ef60fc1af2a625c0c36da0664d8

M room/compiler/src/main/kotlin/androidx/room/processor/QueryMethodProcessor.kt
M room/compiler/src/main/kotlin/androidx/room/solver/TypeAdapterStore.kt
M room/compiler/src/main/kotlin/androidx/room/solver/query/result/PojoRowAdapter.kt
M room/compiler/src/test/kotlin/androidx/room/processor/QueryMethodProcessorTest.kt
M room/compiler/src/test/kotlin/androidx/room/testing/TestProcessor.kt

https://android-review.googlesource.com/1123258

https://goto.google.com/android-sha1/b90079595f33f58fece04026a97faa0d243acdb1

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

The following changes were cherrypicked through Coastguard (

https://android-build.googleplex.com/coastguard/)
Release Track: (

https://android-build.googleplex.com/coastguard/dashboard/6093116828680192/#/cherrypickHistory/all)
Created: 2019-10-14 17:23:42.610596+00:00
Changes: aosp/1123258

Issue 315830077

Description

Issue summary

Comments

ap...@google.com <ap...@google.com> #2Mar 25, 2024 09:24PM

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

Add comment

Issue metadata