Compose runtime can crash when remember() key comes from a Composable function [315855015]

Fixed

Bug

Status Update

No update yet.

Description

jw...@squareup.com

created issue #1

Dec 11, 2023 10:21PM

Jetpack Compose version:

androidx.compose.compiler:compiler:1.5.6
androidx.compose:compose-bom:2023.10.01

Jetpack Compose component used: compiler and runtime

Android Studio Build: Hedgehog | 2023.1.1 Build #AI-231.9392.1.2311.11076708, built on November 9, 2023

Kotlin version: 1.9.21

I encountered this crash upgrading Kotlin from 1.9.20 to 1.9.21. When I switched our project to Kotlin 1.9.21, one of our compositions started to crash.

In this view I’ve isolated the problem:

import android.annotation.SuppressLint
import android.content.Context
import androidx.compose.foundation.text.BasicText
import androidx.compose.runtime.Composable
import androidx.compose.runtime.ReadOnlyComposable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.ui.platform.AbstractComposeView

@SuppressLint("ViewConstructor")
class IsolatedView(
  context: Context,
) : AbstractComposeView(context) {
  @Composable
  @ReadOnlyComposable
  fun key1(): String = "key1"

  @Composable
  override fun Content() {
    val label by remember(key1()) {
      mutableStateOf("hello")
    }
    BasicText(text = label)
  }
}

import app.cash.paparazzi.Paparazzi
import org.junit.Rule
import org.junit.Test

class IsolatedTest {
  @get:Rule val paparazzi = Paparazzi()

  @Test fun test() {
    paparazzi.snapshot(IsolatedView(paparazzi.context))
  }
}

This sample uses Paparazzi to snapshot a composition in a test case. I don’t believe Paparazzi is necessary to reproduce this.

I believe the problem is that I’m using the result of a @Composable function as the argument to remember().

Stack trace:

androidx.compose.runtime.ComposeRuntimeError: Compose Runtime internal error. Unexpected or incorrect use of the Compose internal runtime API (Unexpected anchor value, expected a negative anchor). Please report to Google or use https://goo.gle/compose-feedback
        at app//androidx.compose.runtime.ComposerKt.composeRuntimeError(Composer.kt:4557)
        at app//androidx.compose.runtime.ComposerKt.composeRuntimeError(Composer.kt:4557)
        at app//androidx.compose.runtime.SlotWriter.moveSlotGapTo(SlotTable.kt:3597)
        at app//androidx.compose.runtime.SlotWriter.moveSlotGapTo(SlotTable.kt:3597)
        at app//androidx.compose.runtime.SlotWriter.close(SlotTable.kt:1341)
        at app//androidx.compose.runtime.SlotWriter.close(SlotTable.kt:1341)
        at app//androidx.compose.runtime.ComposerImpl.abortRoot(Composer.kt:1477)
        at app//androidx.compose.runtime.ComposerImpl.abortRoot(Composer.kt:1477)
        at app//androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3360)
        at app//androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3360)
        at app//androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3273)
        at app//androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3273)
        at app//androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:588)
        at app//androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:588)
        at app//androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1013)
        at app//androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1013)
        at app//androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
        at app//androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:142)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:142)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.AndroidComposeView.setOnViewTreeOwnersAvailable(AndroidComposeView.android.kt:1191)
        at app//androidx.compose.ui.platform.AndroidComposeView.setOnViewTreeOwnersAvailable(AndroidComposeView.android.kt:1191)
        at app//androidx.compose.ui.platform.WrappedComposition.setContent(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.WrappedComposition.setContent(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.WrappedComposition.onStateChanged(Wrapper.android.kt:183)
        at app//androidx.compose.ui.platform.WrappedComposition.onStateChanged(Wrapper.android.kt:183)
        at app//androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.kt:314)
        at app//androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.kt:314)
        at app//androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.kt:192)
        at app//androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.kt:192)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:140)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:140)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.AndroidComposeView.onAttachedToWindow(AndroidComposeView.android.kt:1266)
        at app//androidx.compose.ui.platform.AndroidComposeView.onAttachedToWindow(AndroidComposeView.android.kt:1266)
        at app//android.view.View.dispatchAttachedToWindow(View.java:21291)
        at app//android.view.View.dispatchAttachedToWindow(View.java:21291)
        at app//android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3491)
        at app//android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3491)
        at app//android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3498)
        at app//android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3498)
        at app//android.view.ViewGroup.addViewInner(ViewGroup.java:5291)
        at app//android.view.ViewGroup.addViewInner(ViewGroup.java:5291)
        at app//android.view.ViewGroup.addView(ViewGroup.java:5077)
        at app//android.view.ViewGroup.addView(ViewGroup.java:5077)
        at app//android.view.ViewGroup.addView(ViewGroup.java:5017)
        at app//android.view.ViewGroup.addView(ViewGroup.java:5017)
        at app//android.view.ViewGroup.addView(ViewGroup.java:4989)
        at app//android.view.ViewGroup.addView(ViewGroup.java:4989)
        at app//app.cash.paparazzi.Paparazzi.takeSnapshots(Paparazzi.kt:310)
        at app//app.cash.paparazzi.Paparazzi.takeSnapshots(Paparazzi.kt:310)
        at app//app.cash.paparazzi.Paparazzi.snapshot(Paparazzi.kt:207)
        at app//app.cash.paparazzi.Paparazzi.snapshot(Paparazzi.kt:207)
        at app//app.cash.paparazzi.Paparazzi.snapshot$default(Paparazzi.kt:206)
        at app//app.cash.paparazzi.Paparazzi.snapshot$default(Paparazzi.kt:206)
        at app//IsolatedTest.test(IsolatedTest.kt:12)

Comments

as...@google.com <as...@google.com> #2Dec 12, 2023 04:15AM

Reassigned to as...@google.com.

Project: platform/frameworks/support
Branch: androidx-master-dev

commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020

Semantics no-op cleanups

Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:

- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".

- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)

- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)

Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."

Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc

M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt

https://android-review.googlesource.com/1360099

ap...@google.com <ap...@google.com> #3Dec 14, 2023 09:42PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 90c191c06981868219a5487814798196b32d1b55
Author: Andrei Shikov <ashikov@google.com>
Date: Wed Dec 13 06:35:42 2023

Hoist remember parameters out of intrinsic remember

Pulls expressions that might contain calls (or side effects) outside of the remember group. The parameter can technically have a composable expression, which was interleaving `changed` calls and composable groups.

Test: updated compiler and runtime tests
Fixes: 315855015
Change-Id: If379f305f7c3db1fc297dc517b63b72fa662be4e

M compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.RememberIntrinsicTransformTests/testComposableCallInArgument[useFir = false].txt
M compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.RememberIntrinsicTransformTests/testComposableCallInArgument[useFir = true].txt
M compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.RememberIntrinsicTransformTests/testCompositionLocalCallAsInput[useFir = false].txt
M compose/compiler/compiler-hosted/integration-tests/src/test/resources/golden/androidx.compose.compiler.plugins.kotlin.RememberIntrinsicTransformTests/testCompositionLocalCallAsInput[useFir = true].txt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/AbstractComposeLowering.kt
M compose/compiler/compiler-hosted/src/main/java/androidx/compose/compiler/plugins/kotlin/lower/ComposableFunctionBodyTransformer.kt
M compose/runtime/runtime/src/nonEmulatorCommonTest/kotlin/androidx/compose/runtime/CompositionTests.kt

https://android-review.googlesource.com/2873554

Issue 315855015

Description

Issue summary

Comments

as...@google.com <as...@google.com> #2Dec 12, 2023 04:15AM

ap...@google.com <ap...@google.com> #3Dec 14, 2023 09:42PM

Add comment

Issue metadata