Compose runtime can crash when remember() key comes from a Composable function [315855015]

Fixed

Bug

Status Update

No update yet.

Description

jw...@squareup.com

created issue #1

Dec 11, 2023 10:21PM

Jetpack Compose version:

androidx.compose.compiler:compiler:1.5.6
androidx.compose:compose-bom:2023.10.01

Jetpack Compose component used: compiler and runtime

Android Studio Build: Hedgehog | 2023.1.1 Build #AI-231.9392.1.2311.11076708, built on November 9, 2023

Kotlin version: 1.9.21

I encountered this crash upgrading Kotlin from 1.9.20 to 1.9.21. When I switched our project to Kotlin 1.9.21, one of our compositions started to crash.

In this view I’ve isolated the problem:

import android.annotation.SuppressLint
import android.content.Context
import androidx.compose.foundation.text.BasicText
import androidx.compose.runtime.Composable
import androidx.compose.runtime.ReadOnlyComposable
import androidx.compose.runtime.getValue
import androidx.compose.runtime.mutableStateOf
import androidx.compose.runtime.remember
import androidx.compose.ui.platform.AbstractComposeView

@SuppressLint("ViewConstructor")
class IsolatedView(
  context: Context,
) : AbstractComposeView(context) {
  @Composable
  @ReadOnlyComposable
  fun key1(): String = "key1"

  @Composable
  override fun Content() {
    val label by remember(key1()) {
      mutableStateOf("hello")
    }
    BasicText(text = label)
  }
}

import app.cash.paparazzi.Paparazzi
import org.junit.Rule
import org.junit.Test

class IsolatedTest {
  @get:Rule val paparazzi = Paparazzi()

  @Test fun test() {
    paparazzi.snapshot(IsolatedView(paparazzi.context))
  }
}

This sample uses Paparazzi to snapshot a composition in a test case. I don’t believe Paparazzi is necessary to reproduce this.

I believe the problem is that I’m using the result of a @Composable function as the argument to remember().

Stack trace:

androidx.compose.runtime.ComposeRuntimeError: Compose Runtime internal error. Unexpected or incorrect use of the Compose internal runtime API (Unexpected anchor value, expected a negative anchor). Please report to Google or use https://goo.gle/compose-feedback
        at app//androidx.compose.runtime.ComposerKt.composeRuntimeError(Composer.kt:4557)
        at app//androidx.compose.runtime.ComposerKt.composeRuntimeError(Composer.kt:4557)
        at app//androidx.compose.runtime.SlotWriter.moveSlotGapTo(SlotTable.kt:3597)
        at app//androidx.compose.runtime.SlotWriter.moveSlotGapTo(SlotTable.kt:3597)
        at app//androidx.compose.runtime.SlotWriter.close(SlotTable.kt:1341)
        at app//androidx.compose.runtime.SlotWriter.close(SlotTable.kt:1341)
        at app//androidx.compose.runtime.ComposerImpl.abortRoot(Composer.kt:1477)
        at app//androidx.compose.runtime.ComposerImpl.abortRoot(Composer.kt:1477)
        at app//androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3360)
        at app//androidx.compose.runtime.ComposerImpl.doCompose(Composer.kt:3360)
        at app//androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3273)
        at app//androidx.compose.runtime.ComposerImpl.composeContent$runtime_release(Composer.kt:3273)
        at app//androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:588)
        at app//androidx.compose.runtime.CompositionImpl.composeContent(Composition.kt:588)
        at app//androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1013)
        at app//androidx.compose.runtime.Recomposer.composeInitial$runtime_release(Recomposer.kt:1013)
        at app//androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
        at app//androidx.compose.runtime.CompositionImpl.setContent(Composition.kt:520)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:142)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:142)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.AndroidComposeView.setOnViewTreeOwnersAvailable(AndroidComposeView.android.kt:1191)
        at app//androidx.compose.ui.platform.AndroidComposeView.setOnViewTreeOwnersAvailable(AndroidComposeView.android.kt:1191)
        at app//androidx.compose.ui.platform.WrappedComposition.setContent(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.WrappedComposition.setContent(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.WrappedComposition.onStateChanged(Wrapper.android.kt:183)
        at app//androidx.compose.ui.platform.WrappedComposition.onStateChanged(Wrapper.android.kt:183)
        at app//androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.kt:314)
        at app//androidx.lifecycle.LifecycleRegistry$ObserverWithState.dispatchEvent(LifecycleRegistry.kt:314)
        at app//androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.kt:192)
        at app//androidx.lifecycle.LifecycleRegistry.addObserver(LifecycleRegistry.kt:192)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:140)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:140)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.WrappedComposition$setContent$1.invoke(Wrapper.android.kt:133)
        at app//androidx.compose.ui.platform.AndroidComposeView.onAttachedToWindow(AndroidComposeView.android.kt:1266)
        at app//androidx.compose.ui.platform.AndroidComposeView.onAttachedToWindow(AndroidComposeView.android.kt:1266)
        at app//android.view.View.dispatchAttachedToWindow(View.java:21291)
        at app//android.view.View.dispatchAttachedToWindow(View.java:21291)
        at app//android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3491)
        at app//android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3491)
        at app//android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3498)
        at app//android.view.ViewGroup.dispatchAttachedToWindow(ViewGroup.java:3498)
        at app//android.view.ViewGroup.addViewInner(ViewGroup.java:5291)
        at app//android.view.ViewGroup.addViewInner(ViewGroup.java:5291)
        at app//android.view.ViewGroup.addView(ViewGroup.java:5077)
        at app//android.view.ViewGroup.addView(ViewGroup.java:5077)
        at app//android.view.ViewGroup.addView(ViewGroup.java:5017)
        at app//android.view.ViewGroup.addView(ViewGroup.java:5017)
        at app//android.view.ViewGroup.addView(ViewGroup.java:4989)
        at app//android.view.ViewGroup.addView(ViewGroup.java:4989)
        at app//app.cash.paparazzi.Paparazzi.takeSnapshots(Paparazzi.kt:310)
        at app//app.cash.paparazzi.Paparazzi.takeSnapshots(Paparazzi.kt:310)
        at app//app.cash.paparazzi.Paparazzi.snapshot(Paparazzi.kt:207)
        at app//app.cash.paparazzi.Paparazzi.snapshot(Paparazzi.kt:207)
        at app//app.cash.paparazzi.Paparazzi.snapshot$default(Paparazzi.kt:206)
        at app//app.cash.paparazzi.Paparazzi.snapshot$default(Paparazzi.kt:206)
        at app//IsolatedTest.test(IsolatedTest.kt:12)

Comments

as...@google.com <as...@google.com> #2Dec 12, 2023 04:15AM

Reassigned to as...@google.com.

You can provide your own regex to By.text().
For example, By.text(Pattern.compile("All albums.*", Pattern.DOTALL)) should be equivalent to a multi-line startsWith.

ap...@google.com <ap...@google.com> #3Dec 14, 2023 09:42PM

Marked as fixed.

I'm probably dumb but why would it be the default and wanted behavior if not documented properly?

Every known startWith / contains function in Java/Kotlin are multiline, the javadoc says: A UI element will be considered a match if its text value starts with the substring parameter

Many people will fall into this non standard default behavior and loose tons of time trying to figure out why.

If you still consider this default is the correct one, then please document it.

Issue 315855015

Description

Issue summary

Comments

as...@google.com <as...@google.com> #2Dec 12, 2023 04:15AM

ap...@google.com <ap...@google.com> #3Dec 14, 2023 09:42PM

Add comment

Issue metadata