Dagger Gutter Icons are not shown for multi module projects after Hedgehog update [315868244]

Fixed

Bug

Status Update

No update yet.

Description

am...@gmail.com

created issue #1

Dec 12, 2023 11:08AM

In earlier versions of Android Studio, such as Giraffe 2022.3.1 Patch 4 (Build #AI-223.8836.35.2231.11090377), Dagger Hilt for Dependency Injection (DI) displayed gutter icons for easy navigation. These icons included an Up Arrow for navigating to the source of dependency injection and a distinct icon for dependency consumers.

However, after updating to the latest stable version, Hedgehog (Build #AI-231.9392.1.2311.11076708), I noticed that these icons are missing in some cases. Specifically, the gutter icons are now only visible for dependencies that have been injected within the same module. If a dependency is injected from another module, for instance, when the WorkManager library provides HiltWorkerFactory, the gutter icon is not displayed in Hedgehog, unlike in Giraffe.

Have attached screenshots of the missing gutter icons with the file names respective to the AS version name

Studio Build: #AI-231.9392.1.2311.11076708
Version of Gradle Plugin: 8.1.2
Version of Gradle: 8.0
Version of Java: jbr-17 (17.0.6)
OS: macOS 14.1.2 (23B92)

Hedgehog.png

131 KB

View

Download

Giraffe.png

102 KB

View

Download

Comments

ps...@google.com <ps...@google.com> Dec 13, 2023 02:47PM

Assigned to an...@google.com.

an...@google.com <an...@google.com> Dec 14, 2023 06:04PM

Reassigned to an...@google.com.

an...@google.com <an...@google.com> Jun 12, 2024 10:41PM

Accepted by an...@google.com.

an...@google.com <an...@google.com> #2Jun 14, 2024 05:48PM

Marked as fixed.

Landed on main through https://r8-review.git.corp.google.com/c/r8/+/86022.

an...@google.com <an...@google.com> #3Jun 20, 2024 05:03PM

Project: r8
Branch: 8.2

commit ea625d87f24c2ae20f8705d04180cce9d98e448f
Author: Søren Gjesse <sgjesse@google.com>
Date: Wed Nov 22 14:14:53 2023

Desugar records again for Android U (API level 34)

Art had a bug in native record support in the initial release of
Android U.

This will be fixed with Art mainline updates, but turning record
desugaring on again for API level 34 to avoid hitting issues on
Android U where mainline updates are not been applied.

Also removed the predicate canUseNativeRecords and replaced with
isRecordsDesugaredForD8 and isRecordsDesugaredForR8. These two
together with runtimeWithRecordsSupport are now used in all record
tests.

Bug:

b/312443509

Change-Id: I111e9779b657492583cd7b9eb60788d8ec6d198e

M src/main/java/com/android/tools/r8/utils/InternalOptions.java
M src/test/java/com/android/tools/r8/TestBase.java
M src/test/java/com/android/tools/r8/ToolHelper.java
M src/test/java/com/android/tools/r8/desugar/records/EmptyRecordAnnotationTest.java
M src/test/java/com/android/tools/r8/desugar/records/RecordBlogTest.java
M src/test/java/com/android/tools/r8/desugar/records/RecordComponentAnnotationsTest.java
M src/test/java/com/android/tools/r8/desugar/records/RecordComponentSignatureTest.java
M src/test/java/com/android/tools/r8/desugar/records/RecordInterfaceTest.java
M src/test/java/com/android/tools/r8/desugar/records/RecordInvokeCustomSplitDesugaringTest.java
M src/test/java/com/android/tools/r8/desugar/records/RecordMergeTest.java
M src/test/java/com/android/tools/r8/desugar/records/SimpleRecordTest.java
M src/test/java/com/android/tools/r8/profile/art/completeness/RecordProfileRewritingTest.java

https://r8-review.googlesource.com/86240

Issue 315868244