Method reference is unstable [315869143]

Assigned

Bug

Status Update

No update yet.

Description

ts...@gmail.com

created issue #1

Dec 12, 2023 09:11AM

Jetpack Compose version: kotlinCompilerExtensionVersion = "1.5.6"

Jetpack Compose component used:

implementation("androidx.activity:activity-compose:1.8.1")
implementation(platform("androidx.compose:compose-bom:2023.08.00"))

Android Studio Build: Build #AI-231.9392.1.2311.11076708, built on November 9, 2023

Kotlin version: id("org.jetbrains.kotlin.android") version "1.9.21" apply false

Steps to Reproduce or Code Sample to Reproduce:

Clone repo - https://github.com/Nexen23/MethodReferenceComposeBug
Click Increment counter
See logcat

Stack trace (if applicable):

10:48:10.442 MY_TAG                   E  -------------------
10:48:10.587 MY_TAG                   E  [Lambda] stableObj::method=189974515
10:48:10.587 MY_TAG                   E  [MethodRef] stableObj::method=196724110
10:48:14.250 MY_TAG                   E  [MethodRef] stableObj::method=196724110
10:48:14.668 MY_TAG                   E  [MethodRef] stableObj::method=196724110
10:48:14.892 MY_TAG                   E  [MethodRef] stableObj::method=196724110

More info:

In debug in new Studio stableObj3 marked as Unstable100 (see screenshot) StableClass method references aren't remembered even though class is @Stable (data class or @Immutable doesn't help either). HashCode for stableObj3: () -> Int is also the same, as well as equals, but not reference equals.

If I change Composable logging to this:

Log.e("MY_TAG", "[$text] stableObj::method=${stableObj3.hashCode()}, " +
            "old==new is ${old == stableObj3}, old===new is ${old === stableObj3}")
old = stableObj3 // old is global: private var old: (() -> Int)? = null

(I removed composable with lambda for this test)

11:07:02.565 MY_TAG                   E  -------------------
11:07:02.655 MY_TAG                   E  [MethodRef] stableObj::method=-2143953908, old==new is false, old===new is false
11:07:07.583 MY_TAG                   E  [MethodRef] stableObj::method=-2143953908, old==new is true, old===new is false
11:07:08.001 MY_TAG                   E  [MethodRef] stableObj::method=-2143953908, old==new is true, old===new is false
11:07:08.434 MY_TAG                   E  [MethodRef] stableObj::method=-2143953908, old==new is true, old===new is false
11:07:08.868 MY_TAG                   E  [MethodRef] stableObj::method=-2143953908, old==new is true, old===new is false

Screenshot 2023-12-12 at 11.04.39.png

23 KB

View

Download

Comments

ts...@gmail.com <ts...@gmail.com> #2Dec 12, 2023 09:26AM

Also doesn't work in AS 2024.3.2 Canary 4 and Compose 1.8.0-beta01

as...@google.com <as...@google.com> #3Dec 14, 2023 12:26AM

Reassigned to as...@google.com.

Andrei: Is this the same as b/388030459?

le...@protonmail.com <le...@protonmail.com> #4Jan 1, 2024 05:53PM

Triage notes: Needs investigation. Assigning for later.

le...@protonmail.com <le...@protonmail.com> #5Jan 1, 2024 06:12PM

Could you share the AppScaffoldTopBar function that fails here? This seems different from b/388030459 since it fails with expression that is not captured.

m....@gmail.com <m....@gmail.com> #6Jan 23, 2024 07:36PM

Reconstructed from IR:

@Composable
fun AppScaffoldTopBar(
    showBackArrow: Boolean,
    showSearch: Boolean,
    title: String?,
    onBackClick: () -> Unit,
    modifier: Modifier = Modifier,
    actions: ImmutableList<AppScaffoldNavigationAction>
) {
    if (!showSearch) {
        TitledTopAppBar(
            title = title,
            showBackArrow = showBackArrow,
            modifier = modifier,
            actions = actions,
            onBackClick = onBackClick
        )
    } else {
        TopAppBar(
            title = {
                // Composable lambda for title
                AppScaffoldTopBarTitle(showBackArrow)
            },
            modifier = modifier,
            navigationIcon = {
                // Composable lambda for navigation icon
                AppScaffoldTopBarNavigationIcon(showBackArrow, onBackClick)
            },
            actions = {
                // Composable lambda for actions
                AppScaffoldTopBarActions(actions)
            }
        )
    }
}

This seems /extremely/ weird to me, because showSearch is just a regular parameter that is used in function body only once. We need more context about surrounding code to figure out why it crashed the compiler.

be...@gmail.com <be...@gmail.com> #7Jul 9, 2024 12:23PM

Comment has been deleted.

Message last modified on Jul 9, 2024 01:32PM

al...@google.com <al...@google.com> #8Feb 26, 2025 07:17PM

Triage notes: Issue is that we don't memoize property references. Keeping in backlog for now.