Fixed
Status Update
Comments
ch...@google.com <ch...@google.com>
ch...@google.com <ch...@google.com> #2
This was broken by 3bca759a5ff08352de831bb1e9b61b1ec2b3362d.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.
Fix (pending) is I2c2dc7b600603ee430fd0d91b23d52ea8aa29ca9.
ch...@google.com <ch...@google.com> #3
Almost 2 months later and this is still broken
ap...@google.com <ap...@google.com> #4
Since there is no progression, I wanted to share our quick-fix for the issue.
#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages
#sdkmanager --package_file=${PATH_WORKSPACE}/packages
while read p; do echo "y" | sdkmanager "${p}"; done <${PATH_WORKSPACE}/packages
ap...@google.com <ap...@google.com> #6
What is the status of this item?
ap...@google.com <ap...@google.com> #7
This has been fixed on master today (internal ref: ag/2945015) and will be available in the next SDK release.
ap...@google.com <ap...@google.com> #8
Any ETA on next release?
ap...@google.com <ap...@google.com> #9
Still broken and not updated? --package_file argument is not usable in it's current form on 26.1.1 straight from the developer site.
ap...@google.com <ap...@google.com> #10
Comfirmed that this seems to still be broken. Can we have an update please?
```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1
(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```
```
(15:58:11) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --version
26.1.1
(15:58:17) C02W513SHTD8:files aso$ /opt/android-sdk-macosx/tools/bin/sdkmanager --install --package_file=package_file
Warning: Unknown argument --package_file=package_file
```
ap...@google.com <ap...@google.com> #11
Hi, is there any update to this issue? Thanks.
sg...@google.com <sg...@google.com> #12
Hi Google. You claim it's been fixed on master, but we haven't had a new release since the broken version 26.1.1. Can you please release the fix?
an...@google.com <an...@google.com> #13
Yeah, still not fixed --'
an...@google.com <an...@google.com> #14
Can't believe this still isn't fixed 2 years later for a command line utility that sits on the main dev site.
mk...@opera.com <mk...@opera.com> #15
Any updates on this? The help for this command clearly states this argument is supported.
ch...@google.com <ch...@google.com> #16
Has anyone re-tried it?
We switched back to RUN sdkmanager --package_file=$ANDROID_HOME/packages.txt
in our Dockerfile back in March of 2021.
Description
Attached a sample project which reproduces the crash when the release variant is built. Change AGP back to 8.1.4 and the crash no longer occurs.
The bytecode after running through R8 looks wrong
The original code in the constructor of com.flurry.sdk.ft in the SDK is (according to the intellij decompiler)
With the R8 in 8.2.0, the whole constructor is inlined a few levels above, and the resulting bytecode assigns the field but looks like the local reference ends up in v1 instead of v0?
With 8.1.4 the inlining doesn't happen, and looks like there's some redundancy in the bytecode, but it's at least correct.