Status Update
Comments
le...@google.com <le...@google.com> #2
Branch: androidx-master-dev
commit c60f33e229e31ab328ef6b59dab63b264954831c
Author: Alexandre Elias <aelias@google.com>
Date: Fri Jul 10 16:23:09 2020
Semantics no-op cleanups
Partly in response to lmr's broad code review, I did a pass of
superficial API/implementation cleanup. The main changes are:
- I changed each Boolean SemanticsProperty where false is equivalent to
not being present to take "Unit" instead. This is conceptually
clearer: it avoids questions like "can I cancel out a semantics from a
merged child by setting it to false?" Because "property = Unit" looks
weird, I also changed the style of these to "property()".
- I moved the Semantics id generator closer to where it's used, in
SemanticsModifierCore. I made it internal and an AtomicInt.
(Note that integer ids are heavily used in the Android
AccessibilityNodeInfo APIs so I can't simply remove them entirely.)
- I deleted dead code. Some examples include SemanticsHintOverrides,
a public API not connected to anything, and SemanticsPropertyKey
merge() open method which is never called. (In both cases I have
a different plan in mind for accessibility.)
Fixes: 145951226
Fixes: 145955412
Test: existing tests
Relnote: "Single-value semantics properties now use a calling style.
For example, 'semantics { hidden = true }' is now written as:
'semantics { hidden() }'."
Change-Id: Ic1afd12ea22c926babc9662f1804d80b33aa0cfc
M ui/integration-tests/benchmark/src/androidTest/java/androidx/ui/benchmark/test/LayoutNodeModifierBenchmark.kt
M ui/ui-core/api/0.1.0-dev15.txt
M ui/ui-core/api/current.txt
M ui/ui-core/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-core/api/public_plus_experimental_current.txt
M ui/ui-core/api/restricted_0.1.0-dev15.txt
M ui/ui-core/api/restricted_current.txt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/graphics/vector/VectorTest.kt
M ui/ui-core/src/androidAndroidTest/kotlin/androidx/ui/semantics/SemanticsTests.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidActuals.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeView.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidComposeViewAccessibilityDelegateCompat.kt
M ui/ui-core/src/androidMain/kotlin/androidx/ui/core/AndroidPopup.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/Expect.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsConfiguration.kt
D ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsHintOverrides.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsModifier.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsNode.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsOwner.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/core/semantics/SemanticsWrapper.kt
M ui/ui-core/src/commonMain/kotlin/androidx/ui/semantics/SemanticsProperties.kt
M ui/ui-foundation/api/0.1.0-dev15.txt
M ui/ui-foundation/api/current.txt
M ui/ui-foundation/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-foundation/api/public_plus_experimental_current.txt
M ui/ui-foundation/api/restricted_0.1.0-dev15.txt
M ui/ui-foundation/api/restricted_current.txt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Clickable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Dialog.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/Scroller.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Selectable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/selection/Toggleable.kt
M ui/ui-foundation/src/main/java/androidx/ui/foundation/semantics/FoundationSemanticsProperties.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ButtonTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CardTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/CheckboxScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/RadioButtonScreenshotTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ScaffoldTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SnackbarTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/SurfaceTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/ripple/RippleIndicationTest.kt
M ui/ui-material/src/androidTest/java/androidx/ui/material/textfield/TextFieldScreenshotTest.kt
M ui/ui-material/src/main/java/androidx/ui/material/AppBar.kt
M ui/ui-material/src/main/java/androidx/ui/material/TextFieldImpl.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/AssertsTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/CallSemanticsActionTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ErrorMessagesTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/FindersTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/PrintToStringTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/ScrollToTest.kt
M ui/ui-test/src/androidTest/java/androidx/ui/test/TextActionsTest.kt
M ui/ui-test/src/main/java/androidx/ui/test/Actions.kt
M ui/ui-test/src/main/java/androidx/ui/test/Filters.kt
M ui/ui-text/api/0.1.0-dev15.txt
M ui/ui-text/api/current.txt
M ui/ui-text/api/public_plus_experimental_0.1.0-dev15.txt
M ui/ui-text/api/public_plus_experimental_current.txt
M ui/ui-text/api/restricted_0.1.0-dev15.txt
M ui/ui-text/api/restricted_current.txt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/CoreTextField.kt
M ui/ui-text/src/commonMain/kotlin/androidx/ui/text/TextSemanticsProperties.kt
la...@gmail.com <la...@gmail.com> #3
It should be the same problem. I used
androidx.camera:camera-video:1.4.0-alpha01
for testing, but the same problem still occurs. How can I solve this problem now?
le...@google.com <le...@google.com> #4
We will need to add this device to the workaround list.
To ensure the workaround work on your device, could you help to test the attached two APKs ?
core-test-app.apk
should have the same issue as you met. This is used to ensure the apk can reproduce the issue.
core-test-app_workaround.apk
add the device to the workaround list and is expected to fix the issue.
Install command:
adb install -r -t core-test-app.apk
Test steps:
- Launch the activity. There should be Video and Preview On.
For
core-test-app_workaround.apk
, it should pop up a "Workaround APK" toast. - Click RECORD button, wait for 3 seconds and then click STOP button. Video should be saved.
- Check the saved video in the photo viewer application.
Expected Result:
core-test-app.apk
should reproduce the issue.
core-test-app_workaround.apk
should fix the issue.
Note:
If the workaround doesn't work on the device, please share the device info to us.
You can get it by
adb shell getprop | egrep "ro.soc|ro.product"
If the workaround work, we will add and release it in next release.
la...@gmail.com <la...@gmail.com> #5
I just used core-test-app.apk
for testing, and the problem was indeed reproduced. Then I used core-test-app_workaround.apk
to test according to the steps. core-test-app_workaround.apk
can solve this problem and there will be no inconsistency in the time base reported by the camera. Thank you for your reply. How soon will the next version be released?
le...@google.com <le...@google.com> #6
Thanks for the confirmation!
The next release will be around the end of January (~1/24).
You can follow this website
ap...@google.com <ap...@google.com> #7
Branch: androidx-main
commit 0f9dd0c614267caab01464e3cee450dd42e58701
Author: leo huang <leohuang@google.com>
Date: Thu Dec 14 10:52:57 2023
Add Snapdragon 778G to timebase quirk
This chipset exhibits the same issue as the chipset added in
aosp/2807553, so it has been added to CameraUseInconsistentTimebaseQuirk
Relnote:"Fixed incorrect duration of video recording on devices using the Snapdragon 778G SoC."
Bug: 316057919
Test: tested by the reporter
Change-Id: If6aa766b7438145e957cae1e7b12f800eb84ce87
M camera/camera-video/src/main/java/androidx/camera/video/internal/compat/quirk/CameraUseInconsistentTimebaseQuirk.java
le...@google.com <le...@google.com> #8
Solution merged and will be released in next release 1.4.0-alpha04
.
na...@google.com <na...@google.com> #9
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.camera:camera-video:1.4.0-alpha04
la...@gmail.com <la...@gmail.com> #10
Thanks, I've tested it and there's no problem
le...@google.com <le...@google.com> #11
Thanks for the info!
Description
Please note: This component is for the CameraX API used in Jetpack. Please DO NOT file Pixel Camera issues here.
Please describe your issue and include details such as the version of CameraX you are using and any relevant logs related to your issue.
// If at all possible, capture an Android logcat (https://developer.android.com/studio/command-line/logcat ) when you're experiencing the issue, preferably while the camera is still active.
CAMERAX VERSION: 1.3.0
CAMERA APPLICATION NAME AND VERSION: Dazz复古胶片相机 31
ANDROID OS BUILD NUMBER: 12
DEVICE NAME: HUAWEI NOVE9 PRO
DESCRIPTION: When I use this device for video recording, the time of recording the video of the recording video displays abnormality val stats = event.recordingStats val size = stats.numBytesRecorded / 1000 val time = java.util.concurrent.TimeUnit.NANOSECONDS.toSeconds(stats.recordedDurationNanos) var text = "${event.getNameString()}: recorded ${size}KB, in ${time}second"
LIST ANY EXPERIMENTAL FEATURES: (As an example - @ExperimentalCamera2Interop)
STEPS TO REPRODUCE:
OBSERVED RESULTS: Displaying the time of the time to display abnormality during the recording
EXPECTED RESULTS: The time recovery in the recording shows normal, consistent with the length of shooting
REPRODUCIBILITY: 5 of 5
ADDITIONAL INFORMATION: See log.txt
CODE FRAGMENTS (this will help us troubleshoot your issues):