Project for reproduce issue: https://github.com/dimka-sark/android-34-theme-issue

Overview

ContextThemeWrapper.setTheme(id) on API <= 33 and API 34 are different implementation

In our project we found that issue in ThemeKey.

In 34 API at: https://cs.android.com/android/_/android/platform/frameworks/base/+/ab3cb30aa0ea166c8bcb0531a5a47ca119a000c3:core/java/android/content/res/Resources.java;l=2024

Theme can't be set more then one time. For example:

Set Theme A
Set Theme B
Set Theme A

Theme A not applied properly, drawable cache use last unique theme set (Theme B in example)

We see that in main branch source code of ThemeKey are changed. https://cs.android.com/android/_/android/platform/frameworks/base/+/c2ad00b665d75e3d1dc68c0feb382f852c4d75c5:core/java/android/content/res/Resources.java;l=2041?hl=ru

We have no option to check if new version are fix drawable cache issue, but we assume that hash code need also to be recalculated after move, for correct equals/hashcode contract

Workaround solution (may be need app compat version of this)

fun ContextThemeWrapper.setThemeCompat(@StyleRes id: Int) {
    // workaround for theme key issue in https://cs.android.com/android/_/android/platform/frameworks/base/+/ab3cb30aa0ea166c8bcb0531a5a47ca119a000c3:core/java/android/content/res/Resources.java;l=2024
    if (Build.VERSION.SDK_INT == Build.VERSION_CODES.UPSIDE_DOWN_CAKE) {
        theme = null
    }
    setTheme(id)
}

Issue 316073981

Links (3)

Issue metadata