Fixed
Status Update
Comments
cc...@google.com <cc...@google.com> #2
Project: r8
Branch: main
commit 77b38bac8b835605eb4858334278b12933c007a4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 11:41:49 2022
Consult api database during type strengthening
Bug: b/236294139
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
https://r8-review.googlesource.com/69142
Branch: main
commit 77b38bac8b835605eb4858334278b12933c007a4
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 11:41:49 2022
Consult api database during type strengthening
Bug:
Change-Id: I9e070782a2da544eba90b15c41d5b7281142cc3b
M src/main/java/com/android/tools/r8/optimize/argumentpropagation/ArgumentPropagatorProgramOptimizer.java
M src/main/java/com/android/tools/r8/androidapi/ComputedApiLevel.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningTest.java
A src/test/java/com/android/tools/r8/apimodel/ApiModelTypeStrengtheningAboveMinApiTest.java
M src/main/java/com/android/tools/r8/utils/AndroidApiLevelUtils.java
cc...@google.com <cc...@google.com> #3
Project: r8
Branch: 3.2
commit b6be4ce67ec9f9389dab9e8f4cac1b7bd97f38ca
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:46:55 2022
Version 3.2.69
Bug: b/236294139
Change-Id: I6aa6dabc3902e9fa1cd5b8289ed3cbf0ba2a0548
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/69146
Branch: 3.2
commit b6be4ce67ec9f9389dab9e8f4cac1b7bd97f38ca
Author: Christoffer Quist Adamsen <christofferqa@google.com>
Date: Fri Jun 17 12:46:55 2022
Version 3.2.69
Bug:
Change-Id: I6aa6dabc3902e9fa1cd5b8289ed3cbf0ba2a0548
M src/main/java/com/android/tools/r8/Version.java
Description
After turning method tracing on in microbench by default in all cases, we have over time found multiple issues where runtime performance is drastically reduced after capturing a method trace, depending on OS version and ART mainline version.
We also found that it was necessary to suppress method traces on long running benchmarks to avoid ANRs, as even a single loop of a compose benchmark can take several seconds to trace. This made numbers and tracing behavior both less predictable, because duration of benchmark now defines whether it gets a method trace, since it's used to predict if simply taking a method trace on the UI thread will cause an ANR. See b/311412125
Currently, method tracing is off by default, everywhere, we want to turn it back on safely.
Tasks: