IssueTracker

Background

I've been re-evaluating the effectiveness of our baseline profiles. Thanks to some of the new commands in profgen-cli, it's easy for me to grab the base.dm file delivered by Play Store and dump the profile data.

However, I ran into two issues.

1. A NPE exception is thrown when I use the following:

bromano@ND9264Y7H7 bin % ./profgen extractProfile dumpProfile --apk ~/Downloads/base.apk --profile ~/Downloads/outputs/primary.prof --map ~/Downloads/mapping.txt --output output
Exception in thread "main" java.lang.NullPointerException
	at com.android.tools.profgen.cli.ProfileDumpCommand.execute(BinCommand.kt:162)
	at kotlinx.cli.ArgParser.parse(ArgParser.kt:643)
	at kotlinx.cli.ArgParser.parse(ArgParser.kt:523)
	at com.android.tools.profgen.cli.MainKt.main(main.kt:32)

I worked around this by removing the following line:

require(outFile.parentFile.exists()) { "Directory does not exist: ${outFile.parent}" }

from here.

2. When using this command I see entries that are not being deobfuscated. I think it has to due with not handling residual signatures.

For example, I see this entry:

# Still obfuscated
HSPLel6;->q1(Ljava/lang/String;)Ljava/lang/String;

and this proguard entry:

    3:10:java.lang.String kotlin.text.StringsKt__IndentKt.trimMargin$default(java.lang.String,java.lang.String,int,java.lang.Object):0 -> q1
      # {"id":"com.android.tools.r8.residualsignature","signature":"(Ljava/lang/String;)Ljava/lang/String;"}

I can share the artifacts over email for reproduction.

Side Note

From my exploration so far, it appears that methods from the baseline profile are still being missed in the final binary profile. I suspect that is due to r8 rewriter. I'm working on upgrading from R8 8.1 -> 8.3 in hopes that it'll address some of these issues. I'll file a separate bug report if the issues remain after we upgrade (likely early to mid January).