Migrate ViewUtils.computeFitSystemWindows to use public APIs [316905984]

Fixed

Feature Request

Status Update

No update yet.

Description

al...@google.com

created issue #1

Dec 18, 2023 05:41PM

See

b/315363401

. We should migrate to the new window insets method, which is a drop-in replacement for the old private API.

Comments

al...@google.com <al...@google.com> #2Dec 19, 2023 03:53PM

We should also deprecate makeOptionalFitsSystemWindows, but it's unclear if that should move to using PFLAG4_FRAMEWORK_OPTIONAL_FITS_SYSTEM_WINDOWS which is hidden. Consider creating a new bug and handing it off to the WindowManager team.

al...@google.com <al...@google.com> Dec 19, 2023 05:30PM

Accepted by al...@google.com.

al...@google.com <al...@google.com> #3Dec 19, 2023 08:03PM

+cc Jorim for advice on comment#2. It doesn't look like we have a migration path for this call.

al...@google.com <al...@google.com> #4Jan 3, 2024 05:37PM

Split off makeOptional to b/318521413.

ap...@google.com <ap...@google.com> #5Jan 3, 2024 07:00PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit 2a1aeedb3f4951527040c36e13ab860a38550fd9
Author: Alan Viverette <alanv@google.com>
Date: Wed Jan 03 12:25:52 2024

Migrate computeFitSystemWindows to use new APIs in SDK 29

Also adds nullability annotations to computeFitSystemWindows.

Relnote: Migrate ViewUtils.computeFitSystemWindows to use public APIs
Fixes: 316905984
Test: AppCompat tests
Change-Id: Icbfb8cda980c49329e599864463a6dd330f7b448

M appcompat/appcompat/api/restricted_current.txt
M appcompat/appcompat/src/main/java/androidx/appcompat/widget/ViewUtils.java

https://android-review.googlesource.com/2882386

Issue 316905984