Fixed
Status Update
Comments
xi...@google.com <xi...@google.com>
ac...@google.com <ac...@google.com> #2
Project: r8
Branch: main
commit 39f08f72219210c78d964f356552efd6c8a3275a
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 19 14:12:31 2023
[Metadata] Update kotlin-metadata-jvm to version 0.6.0
Bug: b/265108171
Change-Id: I2441b7c328acda8efa13c4e0a7c334cf275f0b44
M build.gradle
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassLevelInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFileFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassPartInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/test/java/com/android/tools/r8/kotlin/coroutines/KotlinxCoroutinesTestRunner.java
M src/test/java/com/android/tools/r8/kotlin/metadata/KotlinMetadataTestBase.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteBoxedTypesTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlineClassTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlinePropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteLocalDelegatedPropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewritePassThroughTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteRawTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteUnitPrimitiveTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteValueClassTest.java
https://r8-review.googlesource.com/75218
Branch: main
commit 39f08f72219210c78d964f356552efd6c8a3275a
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 19 14:12:31 2023
[Metadata] Update kotlin-metadata-jvm to version 0.6.0
Bug:
Change-Id: I2441b7c328acda8efa13c4e0a7c334cf275f0b44
M build.gradle
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassLevelInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFileFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassPartInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/test/java/com/android/tools/r8/kotlin/coroutines/KotlinxCoroutinesTestRunner.java
M src/test/java/com/android/tools/r8/kotlin/metadata/KotlinMetadataTestBase.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteBoxedTypesTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlineClassTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlinePropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteLocalDelegatedPropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewritePassThroughTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteRawTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteUnitPrimitiveTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteValueClassTest.java
sa...@google.com <sa...@google.com> #3
Project: r8
Branch: main
commit dde8cf4cd2e452225400d77819767cd48406cd41
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Jan 23 17:32:03 2023
[Metadata] Update service import in sanity check test
Bug: b/265108171
Change-Id: I25d5a272b8a3cab18e638e85553bbf5b98997b60
M src/test/java/com/android/tools/r8/SanityCheck.java
https://r8-review.googlesource.com/75322
Branch: main
commit dde8cf4cd2e452225400d77819767cd48406cd41
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Mon Jan 23 17:32:03 2023
[Metadata] Update service import in sanity check test
Bug:
Change-Id: I25d5a272b8a3cab18e638e85553bbf5b98997b60
M src/test/java/com/android/tools/r8/SanityCheck.java
ac...@google.com <ac...@google.com> #4
The public work of this has now been completed. I created
sa...@google.com <sa...@google.com> #5
Project: r8
Branch: 8.0
commit 177f2a32494e4e9baedd895eb920bc41825ef77b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:22:14 2023
Version 8.0.27
Bug: b/265108171
Bug: b/266177488
Bug: b/266396725
Change-Id: Iebc28bdd06d6330116a8b12336f25be201603745
M src/main/java/com/android/tools/r8/Version.java
https://r8-review.googlesource.com/75409
Branch: 8.0
commit 177f2a32494e4e9baedd895eb920bc41825ef77b
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:22:14 2023
Version 8.0.27
Bug:
Bug:
Bug:
Change-Id: Iebc28bdd06d6330116a8b12336f25be201603745
M src/main/java/com/android/tools/r8/Version.java
no...@google.com <no...@google.com> #6
Project: r8
Branch: 8.0
commit 1c9ab7b7cff3bdc3de67ce8b6cd032907f72c8ef
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:21:40 2023
[Metadata] Update service import in sanity check test
Bug: b/265108171
Change-Id: I25d5a272b8a3cab18e638e85553bbf5b98997b60
M src/test/java/com/android/tools/r8/SanityCheck.java
https://r8-review.googlesource.com/75406
Branch: 8.0
commit 1c9ab7b7cff3bdc3de67ce8b6cd032907f72c8ef
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:21:40 2023
[Metadata] Update service import in sanity check test
Bug:
Change-Id: I25d5a272b8a3cab18e638e85553bbf5b98997b60
M src/test/java/com/android/tools/r8/SanityCheck.java
sa...@google.com <sa...@google.com> #7
Project: r8
Branch: 8.0
commit 1db3d77589ae2bc16ba2501f9848d40afb780139
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:21:27 2023
Reland "[Metadata] Update kotlin-metadata-jvm to version 0.6.0"
This reverts commit 87b372dde22f9052f9fb86770921bdf6cb008ba6.
Change-Id: I7b361c05a686fbfffd399f5a7ee10f65c8513b2f
Bug: b/265108171
M build.gradle
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassLevelInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFileFacadeInfo.java
A src/main/java/com/android/tools/r8/kotlin/KotlinMetadataAnnotationWrapper.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassPartInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/test/java/com/android/tools/r8/kotlin/coroutines/KotlinxCoroutinesTestRunner.java
M src/test/java/com/android/tools/r8/kotlin/metadata/KotlinMetadataTestBase.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteBoxedTypesTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlineClassTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlinePropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteLocalDelegatedPropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewritePassThroughTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteRawTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteUnitPrimitiveTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteValueClassTest.java
https://r8-review.googlesource.com/75405
Branch: 8.0
commit 1db3d77589ae2bc16ba2501f9848d40afb780139
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Wed Jan 25 13:21:27 2023
Reland "[Metadata] Update kotlin-metadata-jvm to version 0.6.0"
This reverts commit 87b372dde22f9052f9fb86770921bdf6cb008ba6.
Change-Id: I7b361c05a686fbfffd399f5a7ee10f65c8513b2f
Bug:
M build.gradle
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassLevelInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassMetadataReader.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFileFacadeInfo.java
A src/main/java/com/android/tools/r8/kotlin/KotlinMetadataAnnotationWrapper.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataRewriter.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassFacadeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMultiFileClassPartInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/test/java/com/android/tools/r8/kotlin/coroutines/KotlinxCoroutinesTestRunner.java
M src/test/java/com/android/tools/r8/kotlin/metadata/KotlinMetadataTestBase.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteBoxedTypesTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlineClassTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteInlinePropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteKeepTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteLocalDelegatedPropertyTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewritePassThroughTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteRawTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteUnitPrimitiveTest.java
M src/test/java/com/android/tools/r8/kotlin/metadata/MetadataRewriteValueClassTest.java
ac...@google.com <ac...@google.com> #8
Project: r8
Branch: main
commit 4ff176f892492b8bbb1a647f83cc0a9e679b40d9
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 26 09:58:05 2023
[Metadata] Move away from deprecated metadata visitors
Bug: b/265108171
Change-Id: I3cd8f4b0a78ef6bfe9d9c38e2629b89315d0c9d1
D src/main/java/com/android/tools/r8/kotlin/KmVisitorProviders.java
M src/main/java/com/android/tools/r8/kotlin/KotlinAnnotationInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinConstructorInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinContractInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinDeclarationContainerInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectExpressionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFlexibleTypeUpperBoundInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFunctionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinJvmMethodSignatureInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLambdaInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLocalDelegatedPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPackageInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeAliasInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeProjectionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinValueParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinVersionRequirementInfo.java
https://r8-review.googlesource.com/75336
Branch: main
commit 4ff176f892492b8bbb1a647f83cc0a9e679b40d9
Author: Morten Krogh-Jespersen <mkroghj@google.com>
Date: Thu Jan 26 09:58:05 2023
[Metadata] Move away from deprecated metadata visitors
Bug:
Change-Id: I3cd8f4b0a78ef6bfe9d9c38e2629b89315d0c9d1
D src/main/java/com/android/tools/r8/kotlin/KmVisitorProviders.java
M src/main/java/com/android/tools/r8/kotlin/KotlinAnnotationInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinConstructorInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinContractInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinDeclarationContainerInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectExpressionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinEffectInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFlexibleTypeUpperBoundInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinFunctionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinJvmMethodSignatureInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLambdaInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinLocalDelegatedPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinMetadataUtils.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPackageInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinPropertyInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinSyntheticClassInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeAliasInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinTypeProjectionInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinValueParameterInfo.java
M src/main/java/com/android/tools/r8/kotlin/KotlinVersionRequirementInfo.java
sa...@google.com <sa...@google.com> #9
Now, this is a big change (ddmlib -> adblib) with subsequent bug fixes.
ac...@google.com <ac...@google.com> #10
I believe there isn't much we need / can do.
Please report back if you are seeing this after Jellyfish Canary 11
sa...@google.com <sa...@google.com> #11
ag/26788330 it the fix (being reviewed)
an...@google.com <an...@google.com> #12
Thank you for your patience while our engineering team worked to resolve this issue. A fix for this issue is now available in:
- Android Studio Koala | 2024.1.1 Canary 4
- Android Gradle Plugin 8.5.0-alpha04
We encourage you to try the latest update.
If you notice further issues or have questions, please file a new bug report.
Thank you for taking the time to submit feedback — we really appreciate it!
br...@gmail.com <br...@gmail.com> #13
Comment has been deleted.
Description
When using Profile/debug APK on macOS, trying to run the APK on the device / emulator fails when the APK name has spaces in it. I verified it works correctly when I renamed the APK to a simple name without spaces or " (1)".
In case it matters, I set up profiling on startup first, but I think regular Run also fails.
Log: