IconButton does not honor LocalContentColor.current [318428829]

Fixed

Bug

Status Update

No update yet.

Description

ky...@gmail.com

created issue #1

Jan 3, 2024 03:55AM

Steps to Reproduce or Code Sample to Reproduce:

@Composable
fun Foo(contentColor: Color) {
    CompositionLocalProvider(LocalContentColor provides contentColor) {
        IconButton(onClick = {}) {
            Icon(Icons.Default.Info, null)
        }
    }
}

@Composable
fun Bar() {
    Row {
        // Both icons have the same color
        Foo(Color.Red)
        Foo(Color.Blue)
    }
}

This is introduced by https://android-review.googlesource.com/c/platform/frameworks/support/+/2881006.

In that CL, iconButtonColors() will use defaultIconButtonColors.

internal val ColorScheme.defaultIconButtonColors: IconButtonColors
    @Composable
    get() {
        return defaultIconButtonColorsCached ?: IconButtonColors(
            containerColor = Color.Transparent,
            contentColor = LocalContentColor.current,
            disabledContainerColor = Color.Transparent,
            disabledContentColor =
            LocalContentColor.current.copy(alpha = IconButtonTokens.DisabledIconOpacity)
        ).also {
            defaultIconButtonColorsCached = it
        }
    }

So LocalContentColor.current will only be read once.

Comments

ma...@google.com <ma...@google.com> Jan 3, 2024 06:22PM

Reassigned to ma...@google.com.

co...@google.com <co...@google.com> Jan 8, 2024 03:52PM

Reassigned to co...@google.com.

co...@google.com <co...@google.com> Jan 8, 2024 10:28PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #2Jan 9, 2024 12:53AM

deleted

ap...@google.com <ap...@google.com> #3Jan 9, 2024 07:36PM

co...@google.com <co...@google.com> Jan 10, 2024 03:34PM

Marked as fixed.

pr...@google.com <pr...@google.com> #4Jan 16, 2024 06:24PM

Project: platform/frameworks/support
Branch: androidx-main

commit 46eea23c96f45f0ee1e57d8aef2f1375507b0dec
Author: José Figueroa Santos <serniebanders@google.com>
Date: Tue Apr 11 14:38:58 2023

[M3][ModalBottomSheet] Enable edge to edge functionality for ModalBottomSheet

Bug: 274872542
Bug: 272973615
Bug: 272334475
Bug: 268432129
Bug: 275849044
Bug: 275486106
Bug: 268433162
RelNote: Add window insets parameter to ModalBottomSheet.
RelNote: Scrim for ModalBottomSheet may now be drawn behind status bar with windowInsets set to zero
RelNote: Updated default ModalBottomSheet functionality to stay outside of system bars including navigation
RelNote: Status bar inset handling is provided by drag handle in edge-to-edge mode.
RelNote: BottomSheetDefaults includes window insets for BottomSheetWindow.
Test: Parameterizes existing tests to work with and without edgeToEdge enabled.
Test: Manual EdgeToEdge testing on various devices and android APIs
Change-Id: I312008e48573ebd21326f77216be0bcd0372aa78

M compose/material3/material3/api/public_plus_experimental_current.txt
M compose/material3/material3/samples/src/main/java/androidx/compose/material3/samples/BottomSheetSamples.kt
M compose/material3/material3/src/androidAndroidTest/kotlin/androidx/compose/material3/ModalBottomSheetTest.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/ModalBottomSheet.android.kt
M compose/material3/material3/src/androidMain/kotlin/androidx/compose/material3/Strings.android.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/SheetDefaults.kt

https://android-review.googlesource.com/2531428

na...@google.com <na...@google.com> #5Jan 24, 2024 07:53PM

Bottom sheet window can now be moved outside of specified inset areas with windowInsets parameter. However, there is a known issue where even if the top level insets are zero'd out, they seem to be consumed preventing content from using system bar padding. Currently investigating.