IconButton does not honor LocalContentColor.current [318428829]

Fixed

Bug

Status Update

No update yet.

Description

ky...@gmail.com

created issue #1

Jan 3, 2024 03:55AM

Steps to Reproduce or Code Sample to Reproduce:

@Composable
fun Foo(contentColor: Color) {
    CompositionLocalProvider(LocalContentColor provides contentColor) {
        IconButton(onClick = {}) {
            Icon(Icons.Default.Info, null)
        }
    }
}

@Composable
fun Bar() {
    Row {
        // Both icons have the same color
        Foo(Color.Red)
        Foo(Color.Blue)
    }
}

This is introduced by https://android-review.googlesource.com/c/platform/frameworks/support/+/2881006.

In that CL, iconButtonColors() will use defaultIconButtonColors.

internal val ColorScheme.defaultIconButtonColors: IconButtonColors
    @Composable
    get() {
        return defaultIconButtonColorsCached ?: IconButtonColors(
            containerColor = Color.Transparent,
            contentColor = LocalContentColor.current,
            disabledContainerColor = Color.Transparent,
            disabledContentColor =
            LocalContentColor.current.copy(alpha = IconButtonTokens.DisabledIconOpacity)
        ).also {
            defaultIconButtonColorsCached = it
        }
    }

So LocalContentColor.current will only be read once.

Comments

ma...@google.com <ma...@google.com> Jan 3, 2024 06:22PM

Reassigned to ma...@google.com.

co...@google.com <co...@google.com> Jan 8, 2024 03:52PM

Reassigned to co...@google.com.

co...@google.com <co...@google.com> Jan 8, 2024 10:28PM

Accepted by co...@google.com.

ap...@google.com <ap...@google.com> #2Jan 9, 2024 12:53AM

Project: platform/frameworks/support
Branch: androidx-main
Author: Louis Pullen-Freilich <lpf@google.com>
Link: https://android-review.googlesource.com/3328184

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling

Expand for full commit details

Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling 
 
These APIs allow overscroll to have events dispatched to it by one component, and rendered in a separate component. 
 
Fixes: b/266550551 
Fixes: b/204650733 
Fixes: b/255554340 
Fixes: b/229537244 
Test: OverscrollTest 
Relnote: "Adds OverscrollEffect#withoutDrawing and OverscrollEffect#withoutEventHandling APIs - these APIs create a wrapped instance of the provided overscroll effect that doesn't draw / handle events respectively, which allows for rendering  overscroll in a separate component from the component that is dispatching events. For example, disabling drawing the overscroll inside a lazy list, and then drawing the overscroll separately on top / elsewhere." 
Change-Id: Idbb3d91546b49c1987a041f959bce4b2b09a9f61

Files:

M compose/foundation/foundation/api/current.txt
M compose/foundation/foundation/api/restricted_current.txt
M compose/foundation/foundation/integration-tests/foundation-demos/src/main/java/androidx/compose/foundation/demos/OverscrollDemo.kt
M compose/foundation/foundation/samples/src/main/java/androidx/compose/foundation/samples/OverscrollSample.kt
M compose/foundation/foundation/src/androidInstrumentedTest/kotlin/androidx/compose/foundation/OverscrollTest.kt
M compose/foundation/foundation/src/commonMain/kotlin/androidx/compose/foundation/Overscroll.kt

Hash: f64e25b7a473c757d080521e7dd97b3f6670f60d
Date: Fri Nov 01 18:43:56 2024

ap...@google.com <ap...@google.com> #3Jan 9, 2024 07:36PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.foundation:foundation:1.8.0-alpha06
androidx.compose.foundation:foundation-android:1.8.0-alpha06
androidx.compose.foundation:foundation-jvmstubs:1.8.0-alpha06
androidx.compose.foundation:foundation-linuxx64stubs:1.8.0-alpha06

co...@google.com <co...@google.com> Jan 10, 2024 03:34PM

Marked as fixed.

pr...@google.com <pr...@google.com> #4Jan 16, 2024 06:24PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.2.0-beta02
androidx.compose.material3:material3-android:1.2.0-beta02
androidx.compose.material3:material3-desktop:1.2.0-beta02

na...@google.com <na...@google.com> #5Jan 24, 2024 07:53PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.2.0-rc01
androidx.compose.material3:material3-android:1.2.0-rc01
androidx.compose.material3:material3-desktop:1.2.0-rc01

Issue 318428829

Description

Issue summary

Comments

ma...@google.com <ma...@google.com> Jan 3, 2024 06:22PM

co...@google.com <co...@google.com> Jan 8, 2024 03:52PM

co...@google.com <co...@google.com> Jan 8, 2024 10:28PM

ap...@google.com <ap...@google.com> #2Jan 9, 2024 12:53AM

ap...@google.com <ap...@google.com> #3Jan 9, 2024 07:36PM

co...@google.com <co...@google.com> Jan 10, 2024 03:34PM

pr...@google.com <pr...@google.com> #4Jan 16, 2024 06:24PM

na...@google.com <na...@google.com> #5Jan 24, 2024 07:53PM

Add comment

Issue metadata