Fixed
Status Update
Comments
ma...@google.com <ma...@google.com>
co...@google.com <co...@google.com>
co...@google.com <co...@google.com>
ap...@google.com <ap...@google.com> #2
Project: platform/frameworks/support
Branch: androidx-main
commit 0207d845b08b9f30e45d427669484699c55fc762
Author: Connie Shi <connieshi@google.com>
Date: Mon Jan 08 17:11:37 2024
defaultIconButtonColorsCached will be updated whenever LocalContentColor changes.
Fixed typo in IconButtonColors.copy().
Bug: 318428829
Test: Added tests.
Relnote: N/A
Change-Id: If8872fbbc5c42ba3a0783b039136d2b686d488e6
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/IconButtonTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/IconButton.kt
https://android-review.googlesource.com/2901907
Branch: androidx-main
commit 0207d845b08b9f30e45d427669484699c55fc762
Author: Connie Shi <connieshi@google.com>
Date: Mon Jan 08 17:11:37 2024
defaultIconButtonColorsCached will be updated whenever LocalContentColor changes.
Fixed typo in IconButtonColors.copy().
Bug: 318428829
Test: Added tests.
Relnote: N/A
Change-Id: If8872fbbc5c42ba3a0783b039136d2b686d488e6
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/IconButtonTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/IconButton.kt
ap...@google.com <ap...@google.com> #3
Project: platform/frameworks/support
Branch: androidx-main
commit 4bc920841d65837b2827116ac407bed763217f97
Author: Connie Shi <connieshi@google.com>
Date: Tue Jan 09 11:30:35 2024
Fix bug in disabledContentColor introduced in aosp/2901907 and add small optimization.
Bug: b/318428829
Test: Added test.
Relnote: N/A
Change-Id: I6dda1a8531aaa21a8e679155861e9c2eb063f123
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/IconButtonTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/IconButton.kt
https://android-review.googlesource.com/2902867
Branch: androidx-main
commit 4bc920841d65837b2827116ac407bed763217f97
Author: Connie Shi <connieshi@google.com>
Date: Tue Jan 09 11:30:35 2024
Fix bug in disabledContentColor introduced in aosp/2901907 and add small optimization.
Bug:
Test: Added test.
Relnote: N/A
Change-Id: I6dda1a8531aaa21a8e679155861e9c2eb063f123
M compose/material3/material3/src/androidInstrumentedTest/kotlin/androidx/compose/material3/IconButtonTest.kt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/IconButton.kt
co...@google.com <co...@google.com>
pr...@google.com <pr...@google.com> #4
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.0-beta02
androidx.compose.material3:material3-android:1.2.0-beta02
androidx.compose.material3:material3-desktop:1.2.0-beta02
na...@google.com <na...@google.com> #5
The following release(s) address this bug.It is possible this bug has only been partially addressed:
androidx.compose.material3:material3:1.2.0-rc01
androidx.compose.material3:material3-android:1.2.0-rc01
androidx.compose.material3:material3-desktop:1.2.0-rc01
Description
Steps to Reproduce or Code Sample to Reproduce:
This is introduced byhttps://android-review.googlesource.com/c/platform/frameworks/support/+/2881006 .
In that CL,
iconButtonColors()
will usedefaultIconButtonColors
.So
LocalContentColor.current
will only be read once.