Outline of disabled OutlinedButton doesn't match spec [318461363]

Fixed

Bug

Status Update

No update yet.

Description

mt...@parsyl.com

created issue #1

Jan 3, 2024 04:49PM

Jetpack Compose version: 2023.10.01 BOM

Jetpack Compose component used: Material 3

Android Studio Build: AI-232.10227.8.2321.11231672 (Iguana | 2023.2.1 Beta 1)

Kotlin version: 1.9.21

Description

The OutlinedButton outline doesn't visually match what the Material 3 spec calls for in the disabled state. I've attached screenshots of the expected and actual outlines.

Steps to reproduce:

Wrap a disabled OutlinedButton in MaterialTheme and Surface like so:

@Preview
@Composable
fun DisabledOutlinedButtonPreview() {
    MaterialTheme {
        Surface {
            OutlinedButton(onClick = {}, enabled = false) {
                Text("Click me")
            }
        }
    }
}

ActualOutlines.png

75 KB

View

Download

ExpectedOutlines.png

34 KB

View

Download

Comments

ma...@google.com <ma...@google.com> Jan 3, 2024 06:15PM

Reassigned to ma...@google.com.

co...@google.com <co...@google.com> Apr 1, 2024 04:39PM

Reassigned to ke...@google.com.

ap...@google.com <ap...@google.com> #2Apr 4, 2024 08:50PM

Marked as fixed.

Project: platform/frameworks/support
Branch: androidx-main

commit a74c92d7ccc6b439e63a5c4119fe3df1489b75fb
Author: kentfan <kentfan@google.com>
Date: Thu Mar 28 16:31:48 2024

Fix disabled OutlinedButton border color

Test:

https://hsv.googleplex.com/6049676993232896

Relnote: """Fixed the border color of `OutlinedButton` when disabled.
Added `ButtonDefaults.outlinedButtonBorder("enabled")` overload that
takes the enabled state."""

Fix:

b/318461363

Change-Id: Ie650bd6f38d9802f4040c0f1c90688d66446019b

M compose/material3/material3/api/current.txt
M compose/material3/material3/api/restricted_current.txt
M compose/material3/material3/src/commonMain/kotlin/androidx/compose/material3/Button.kt

https://android-review.googlesource.com/3018072

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

The following release(s) address this bug.It is possible this bug has only been partially addressed:

androidx.compose.material3:material3:1.3.0-alpha05
androidx.compose.material3:material3-android:1.3.0-alpha05
androidx.compose.material3:material3-desktop:1.3.0-alpha05

Issue 318461363

Description

Description

Steps to reproduce:

Issue summary

Comments

ma...@google.com <ma...@google.com> Jan 3, 2024 06:15PM

co...@google.com <co...@google.com> Apr 1, 2024 04:39PM

ap...@google.com <ap...@google.com> #2Apr 4, 2024 08:50PM

na...@google.com <na...@google.com> #3Apr 17, 2024 05:17PM

Add comment

Issue metadata